target/linux/s3c24xx/patches-2.6.26/0246-checkpatch-fixes.patch.patch

   1 From edb431ebc8be9f2ab47c2ea5e585a6ba8ac3a16e Mon Sep 17 00:00:00 2001
   2 From: Andy Green <andy@openmoko.com>
   3 Date: Sun, 10 Aug 2008 09:14:15 +0100
   4 Subject: [PATCH] checkpatch-fixes.patch
   5
   6 This cleans out some random externs in C files that checkpatch does not like
   7 and introduces a couple of .h files to contain them.  Plus some other minor
   8 checkpatch style complaints.
   9
  10 Signed-off-by: Andy Green <andy@openmoko.com>
  11 ---
  12  arch/arm/mach-s3c2410/mach-gta01.c     |    4 ++--
  13  arch/arm/mach-s3c2440/mach-gta02.c     |    4 ++--
  14  arch/arm/plat-s3c24xx/neo1973_pm_gsm.c |    6 +-----
  15  drivers/video/backlight/gta01_bl.c     |    2 +-
  16  4 files changed, 6 insertions(+), 10 deletions(-)
  17
  18 diff --git a/arch/arm/mach-s3c2410/mach-gta01.c b/arch/arm/mach-s3c2410/mach-gta01.c
  19 index 4927cd4..a364b76 100644
  20 --- a/arch/arm/mach-s3c2410/mach-gta01.c
  21 +++ b/arch/arm/mach-s3c2410/mach-gta01.c
  22 @@ -73,6 +73,8 @@
  23  #include <asm/plat-s3c24xx/pm.h>
  24  #include <asm/plat-s3c24xx/udc.h>
  25  #include <asm/plat-s3c24xx/neo1973.h>
  26 +#include <asm/arch-s3c2410/neo1973-pm-gsm.h>
  27 +
  28  #include <linux/jbt6k74.h>
  29
  30  static struct map_desc gta01_iodesc[] __initdata = {
  31 @@ -666,8 +668,6 @@ static void __init gta01_map_io(void)
  32         s3c24xx_init_uarts(gta01_uartcfgs, ARRAY_SIZE(gta01_uartcfgs));
  33  }
  34
  35 -extern int gta_gsm_interrupts;
  36 -
  37  static irqreturn_t gta01_modem_irq(int irq, void *param)
  38  {
  39         printk(KERN_DEBUG "GSM wakeup interrupt (IRQ %d)\n", irq);
  40 diff --git a/arch/arm/mach-s3c2440/mach-gta02.c b/arch/arm/mach-s3c2440/mach-gta02.c
  41 index b37d1c4..1658fa0 100644
  42 --- a/arch/arm/mach-s3c2440/mach-gta02.c
  43 +++ b/arch/arm/mach-s3c2440/mach-gta02.c
  44 @@ -78,6 +78,8 @@
  45  #include <asm/plat-s3c24xx/pm.h>
  46  #include <asm/plat-s3c24xx/udc.h>
  47  #include <asm/plat-s3c24xx/neo1973.h>
  48 +#include <asm/arch-s3c2410/neo1973-pm-gsm.h>
  49 +
  50  #include <linux/jbt6k74.h>
  51
  52  #include <linux/glamofb.h>
  53 @@ -1531,8 +1533,6 @@ static void __init gta02_map_io(void)
  54         s3c24xx_init_uarts(gta02_uartcfgs, ARRAY_SIZE(gta02_uartcfgs));
  55  }
  56
  57 -extern int gta_gsm_interrupts;
  58 -
  59  static irqreturn_t gta02_modem_irq(int irq, void *param)
  60  {
  61         printk(KERN_DEBUG "modem wakeup interrupt\n");
  62 diff --git a/arch/arm/plat-s3c24xx/neo1973_pm_gsm.c b/arch/arm/plat-s3c24xx/neo1973_pm_gsm.c
  63 index 8d5e41c..9873568 100644
  64 --- a/arch/arm/plat-s3c24xx/neo1973_pm_gsm.c
  65 +++ b/arch/arm/plat-s3c24xx/neo1973_pm_gsm.c
  66 @@ -18,12 +18,12 @@
  67  #include <linux/console.h>
  68  #include <linux/errno.h>
  69  #include <linux/interrupt.h>
  70 -#include <linux/resume-dependency.h>
  71
  72  #include <asm/gpio.h>
  73  #include <asm/mach-types.h>
  74  #include <asm/arch/gta01.h>
  75  #include <asm/plat-s3c24xx/neo1973.h>
  76 +#include <asm/arch/s3c24xx-serial.h>
  77
  78  #ifdef CONFIG_MACH_NEO1973_GTA02
  79  #include <asm/arch/gta02.h>
  80 @@ -31,10 +31,6 @@
  81  #include <asm/arch/regs-gpioj.h>
  82  #endif
  83
  84 -extern void s3c24xx_serial_console_set_silence(int silence);
  85 -extern void s3c24xx_serial_register_resume_dependency(struct resume_dependency *
  86 -                                            resume_dependency, int uart_index);
  87 -
  88  int gta_gsm_interrupts;
  89  EXPORT_SYMBOL(gta_gsm_interrupts);
  90
  91 diff --git a/drivers/video/backlight/gta01_bl.c b/drivers/video/backlight/gta01_bl.c
  92 index 34c19c8..a7170df 100644
  93 --- a/drivers/video/backlight/gta01_bl.c
  94 +++ b/drivers/video/backlight/gta01_bl.c
  95 @@ -152,7 +152,7 @@ EXPORT_SYMBOL_GPL(gta01bl_deferred_resume);
  96
  97  static int gta01bl_resume(struct platform_device *dev)
  98  {
  99 -       if (! gta01bl_defer_resume_backlight)
 100 +       if (!gta01bl_defer_resume_backlight)
 101                 gta01bl_deferred_resume();
 102         return 0;
 103  }
 104 --
 105 1.5.6.3
 106