projects
/
project
/
odhcpd.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(from parent 1:
4591b36
)
dhcpv4: fix out of bound access in dhcpv4_put
author
Hans Dedecker
<dedeckeh@gmail.com>
Tue, 15 May 2018 20:22:30 +0000
(22:22 +0200)
committer
Hans Dedecker
<dedeckeh@gmail.com>
Tue, 15 May 2018 20:22:30 +0000
(22:22 +0200)
Detected by Coverity in CID
1433363
and
1432121
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
src/dhcpv4.c
patch
|
blob
|
history
diff --git
a/src/dhcpv4.c
b/src/dhcpv4.c
index
2b30307
..
b803359
100644
(file)
--- a/
src/dhcpv4.c
+++ b/
src/dhcpv4.c
@@
-493,7
+493,9
@@
static void dhcpv4_put(struct dhcpv4_message *msg, uint8_t **cookie,
uint8_t type, uint8_t len, const void *data)
{
uint8_t *c = *cookie;
- if (*cookie + 2 + len > (uint8_t*)&msg[1])
+ uint8_t *end = (uint8_t *)msg + sizeof(*msg);
+
+ if (*cookie + 2 + len > end)
return;
*c++ = type;