1 From ec31dc882de68b041b6ac36e3de7e17cf256c222 Mon Sep 17 00:00:00 2001
2 From: Colin Ian King <colin.king@canonical.com>
3 Date: Wed, 2 Sep 2015 07:47:51 -0400
4 Subject: [PATCH 175/203] bcm2835: memcpy port data to m rather than rmsg
6 static analysis by cppcheck detected a memcpy to rmsg which is
7 not actually initialized at that point. The memcpy should be copying
10 Signed-off-by: Colin Ian King <colin.king@canonical.com>
12 drivers/media/platform/bcm2835/mmal-vchiq.c | 2 +-
13 1 file changed, 1 insertion(+), 1 deletion(-)
15 --- a/drivers/media/platform/bcm2835/mmal-vchiq.c
16 +++ b/drivers/media/platform/bcm2835/mmal-vchiq.c
17 @@ -851,7 +851,7 @@ static int port_info_set(struct vchiq_mm
18 sizeof(union mmal_es_specific_format));
20 m.u.port_info_set.format.extradata_size = port->format.extradata_size;
21 - memcpy(rmsg->u.port_info_set.extradata, port->format.extradata,
22 + memcpy(&m.u.port_info_set.extradata, port->format.extradata,
23 port->format.extradata_size);
25 ret = send_synchronous_mmal_msg(instance, &m,