modules/admin-full: fix dhcp page

[project/luci.git] / modules / admin-full / luasrc / model / cbi / admin_network / dhcp.lua

diff --git a/modules/admin-full/luasrc/model/cbi/admin_network/dhcp.lua b/modules/admin-full/luasrc/model/cbi/admin_network/dhcp.lua
index b22f735..1e3e4c4 100644 (file)
--- a/modules/admin-full/luasrc/model/cbi/admin_network/dhcp.lua
+++ b/modules/admin-full/luasrc/model/cbi/admin_network/dhcp.lua
@@ -11,43 +11,71 @@ You may obtain a copy of the License at
 
 $Id$
 ]]--
+require("luci.tools.webadmin")
 require("luci.model.uci")
-require("luci.sys")
+require("luci.util")
 
-m = Map("dhcp", "DHCP")
+m = Map("dhcp",
+       translate("Dynamic <abbr title=\"Dynamic Host Configuration Protocol\">DHCP</abbr>"),
+       translate("With <abbr title=\"Dynamic Host Configuration Protocol\">DHCP</abbr> network " ..
+               "members can automatically receive their network settings (<abbr title=" ..
+               "\"Internet Protocol\">IP</abbr>-address, netmask, <abbr title=\"Domain Name " ..
+               "System\">DNS</abbr>-server, ...)."))
 
 s = m:section(TypedSection, "dhcp", "")
 s.addremove = true
 s.anonymous = true
 
-iface = s:option(ListValue, "interface", translate("interface"))
-luci.model.uci.foreach("network", "interface",
+iface = s:option(ListValue, "interface", translate("Interface"))
+luci.tools.webadmin.cbi_add_networks(iface)
+
+local uci = luci.model.uci.cursor()
+uci:foreach("network", "interface",
        function (section)
                if section[".name"] ~= "loopback" then
-                       iface:value(section[".name"])
+                       iface.default = iface.default or section[".name"]
                        s:depends("interface", section[".name"])
                end
        end)
 
-s:option(Value, "start", translate("start")).rmempty = true
+uci:foreach("network", "alias",
+       function (section)
+               iface:value(section[".name"])
+               s:depends("interface", section[".name"])
+       end)
 
-s:option(Value, "limit", translate("limit")).rmempty = true
+s:option(Value, "start", translate("Start")).rmempty = true
 
-s:option(Value, "leasetime").rmempty = true
+s:option(Value, "limit", translate("Limit")).rmempty = true
 
-s:option(Flag, "dynamicdhcp").rmempty = true
+s:option(Value, "leasetime", translate("Leasetime")).rmempty = true
+
+local dd = s:option(Flag, "dynamicdhcp", translate("dynamic"))
+dd.rmempty = false
+function dd.cfgvalue(self, section)
+       return Flag.cfgvalue(self, section) or "1"
+end
 
-s:option(Value, "name", translate("name")).optional = true
+s:option(Value, "name", translate("Name")).optional = true
 
-s:option(Flag, "ignore").optional = true
+ignore = s:option(Flag, "ignore",
+       translate("Ignore interface"),
+       translate("disable <abbr title=\"Dynamic Host Configuration Protocol\">DHCP</abbr> for " ..
+               "this interface"))
 
-s:option(Value, "netmask", translate("netmask")).optional = true
+ignore.optional = true
 
-s:option(Flag, "force").optional = true
+s:option(Value, "netmask", translate("<abbr title=\"Internet Protocol Version 4\">IPv4</abbr>-Netmask")).optional = true
 
-for i, line in pairs(luci.sys.execl("dnsmasq --help dhcp")) do
-       k, v = line:match("([^ ]+) +([^ ]+)")
-       s:option(Value, "dhcp"..k, v).optional = true
+s:option(Flag, "force", translate("Force")).optional = true
+
+s:option(DynamicList, "dhcp_option", translate("DHCP-Options")).optional = true
+
+
+for i, n in ipairs(s.children) do
+       if n ~= iface and n ~= ignore then
+               n:depends("ignore", "")
+       end
 end
-       
-return m
\ No newline at end of file
+
+return m