ar71xx: ag71xx: show PHY interface mode in dmesg
[openwrt.git] / target / linux / ar71xx / files / drivers / net / ethernet / atheros / ag71xx / ag71xx_main.c
index a69ed27..2eeb269 100644 (file)
@@ -134,6 +134,7 @@ static void ag71xx_ring_tx_clean(struct ag71xx *ag)
 {
        struct ag71xx_ring *ring = &ag->tx_ring;
        struct net_device *dev = ag->dev;
+       u32 bytes_compl = 0, pkts_compl = 0;
 
        while (ring->curr != ring->dirty) {
                u32 i = ring->dirty % ring->size;
@@ -143,17 +144,19 @@ static void ag71xx_ring_tx_clean(struct ag71xx *ag)
                        dev->stats.tx_errors++;
                }
 
-               if (ring->buf[i].skb)
+               if (ring->buf[i].skb) {
+                       bytes_compl += ring->buf[i].skb->len;
+                       pkts_compl++;
                        dev_kfree_skb_any(ring->buf[i].skb);
-
+               }
                ring->buf[i].skb = NULL;
-
                ring->dirty++;
        }
 
        /* flush descriptors */
        wmb();
 
+       netdev_completed_queue(dev, pkts_compl, bytes_compl);
 }
 
 static void ag71xx_ring_tx_init(struct ag71xx *ag)
@@ -174,6 +177,7 @@ static void ag71xx_ring_tx_init(struct ag71xx *ag)
 
        ring->curr = 0;
        ring->dirty = 0;
+       netdev_reset_queue(ag->dev);
 }
 
 static void ag71xx_ring_rx_clean(struct ag71xx *ag)
@@ -185,37 +189,53 @@ static void ag71xx_ring_rx_clean(struct ag71xx *ag)
                return;
 
        for (i = 0; i < ring->size; i++)
-               if (ring->buf[i].skb) {
+               if (ring->buf[i].rx_buf) {
                        dma_unmap_single(&ag->dev->dev, ring->buf[i].dma_addr,
-                                        AG71XX_RX_PKT_SIZE, DMA_FROM_DEVICE);
-                       kfree_skb(ring->buf[i].skb);
+                                        AG71XX_RX_BUF_SIZE, DMA_FROM_DEVICE);
+                       kfree(ring->buf[i].rx_buf);
                }
 }
 
-static int ag71xx_rx_reserve(struct ag71xx *ag)
+static int ag71xx_buffer_offset(struct ag71xx *ag)
 {
-       int reserve = 0;
+       int offset = NET_SKB_PAD;
 
-       if (ag71xx_get_pdata(ag)->is_ar724x) {
-               if (!ag71xx_has_ar8216(ag))
-                       reserve = 2;
+       /*
+        * On AR71xx/AR91xx packets must be 4-byte aligned.
+        *
+        * When using builtin AR8216 support, hardware adds a 2-byte header,
+        * so we don't need any extra alignment in that case.
+        */
+       if (!ag71xx_get_pdata(ag)->is_ar724x || ag71xx_has_ar8216(ag))
+               return offset;
 
-               if (ag->phy_dev)
-                       reserve += 4 - (ag->phy_dev->pkt_align % 4);
+       return offset + NET_IP_ALIGN;
+}
 
-               reserve %= 4;
-       }
+static bool ag71xx_fill_rx_buf(struct ag71xx *ag, struct ag71xx_buf *buf,
+                              int offset)
+{
+       void *data;
 
-       return reserve + AG71XX_RX_PKT_RESERVE;
-}
+       data = kmalloc(AG71XX_RX_BUF_SIZE +
+                      SKB_DATA_ALIGN(sizeof(struct skb_shared_info)),
+                      GFP_ATOMIC);
+       if (!data)
+               return false;
 
+       buf->rx_buf = data;
+       buf->dma_addr = dma_map_single(&ag->dev->dev, data,
+                                      AG71XX_RX_BUF_SIZE, DMA_FROM_DEVICE);
+       buf->desc->data = (u32) buf->dma_addr + offset;
+       return true;
+}
 
 static int ag71xx_ring_rx_init(struct ag71xx *ag)
 {
        struct ag71xx_ring *ring = &ag->rx_ring;
-       unsigned int reserve = ag71xx_rx_reserve(ag);
        unsigned int i;
        int ret;
+       int offset = ag71xx_buffer_offset(ag);
 
        ret = 0;
        for (i = 0; i < ring->size; i++) {
@@ -228,24 +248,11 @@ static int ag71xx_ring_rx_init(struct ag71xx *ag)
        }
 
        for (i = 0; i < ring->size; i++) {
-               struct sk_buff *skb;
-               dma_addr_t dma_addr;
-
-               skb = dev_alloc_skb(AG71XX_RX_PKT_SIZE + reserve);
-               if (!skb) {
+               if (!ag71xx_fill_rx_buf(ag, &ring->buf[i], offset)) {
                        ret = -ENOMEM;
                        break;
                }
 
-               skb->dev = ag->dev;
-               skb_reserve(skb, reserve);
-
-               dma_addr = dma_map_single(&ag->dev->dev, skb->data,
-                                         AG71XX_RX_PKT_SIZE,
-                                         DMA_FROM_DEVICE);
-               ring->buf[i].skb = skb;
-               ring->buf[i].dma_addr = dma_addr;
-               ring->buf[i].desc->data = (u32) dma_addr;
                ring->buf[i].desc->ctrl = DESC_EMPTY;
        }
 
@@ -261,8 +268,8 @@ static int ag71xx_ring_rx_init(struct ag71xx *ag)
 static int ag71xx_ring_rx_refill(struct ag71xx *ag)
 {
        struct ag71xx_ring *ring = &ag->rx_ring;
-       unsigned int reserve = ag71xx_rx_reserve(ag);
        unsigned int count;
+       int offset = ag71xx_buffer_offset(ag);
 
        count = 0;
        for (; ring->curr - ring->dirty > 0; ring->dirty++) {
@@ -270,25 +277,9 @@ static int ag71xx_ring_rx_refill(struct ag71xx *ag)
 
                i = ring->dirty % ring->size;
 
-               if (ring->buf[i].skb == NULL) {
-                       dma_addr_t dma_addr;
-                       struct sk_buff *skb;
-
-                       skb = dev_alloc_skb(AG71XX_RX_PKT_SIZE + reserve);
-                       if (skb == NULL)
-                               break;
-
-                       skb_reserve(skb, reserve);
-                       skb->dev = ag->dev;
-
-                       dma_addr = dma_map_single(&ag->dev->dev, skb->data,
-                                                 AG71XX_RX_PKT_SIZE,
-                                                 DMA_FROM_DEVICE);
-
-                       ring->buf[i].skb = skb;
-                       ring->buf[i].dma_addr = dma_addr;
-                       ring->buf[i].desc->data = (u32) dma_addr;
-               }
+               if (!ring->buf[i].rx_buf &&
+                   !ag71xx_fill_rx_buf(ag, &ring->buf[i], offset))
+                       break;
 
                ring->buf[i].desc->ctrl = DESC_EMPTY;
                count++;
@@ -326,6 +317,7 @@ static void ag71xx_rings_cleanup(struct ag71xx *ag)
        ag71xx_ring_free(&ag->rx_ring);
 
        ag71xx_ring_tx_clean(ag);
+       netdev_reset_queue(ag->dev);
        ag71xx_ring_free(&ag->tx_ring);
 }
 
@@ -691,6 +683,7 @@ static netdev_tx_t ag71xx_hard_start_xmit(struct sk_buff *skb,
        dma_addr = dma_map_single(&dev->dev, skb->data, skb->len,
                                  DMA_TO_DEVICE);
 
+       netdev_sent_queue(dev, skb->len);
        ring->buf[i].skb = skb;
        ring->buf[i].timestamp = jiffies;
 
@@ -822,11 +815,11 @@ static int ag71xx_tx_packets(struct ag71xx *ag)
 {
        struct ag71xx_ring *ring = &ag->tx_ring;
        struct ag71xx_platform_data *pdata = ag71xx_get_pdata(ag);
-       int sent;
+       int sent = 0;
+       int bytes_compl = 0;
 
        DBG("%s: processing TX ring\n", ag->dev->name);
 
-       sent = 0;
        while (ring->dirty != ring->curr) {
                unsigned int i = ring->dirty % ring->size;
                struct ag71xx_desc *desc = ring->buf[i].desc;
@@ -841,6 +834,7 @@ static int ag71xx_tx_packets(struct ag71xx *ag)
 
                ag71xx_wr(ag, AG71XX_REG_TX_STATUS, TX_STATUS_PS);
 
+               bytes_compl += skb->len;
                ag->dev->stats.tx_bytes += skb->len;
                ag->dev->stats.tx_packets++;
 
@@ -853,6 +847,7 @@ static int ag71xx_tx_packets(struct ag71xx *ag)
 
        DBG("%s: %d packets sent out\n", ag->dev->name, sent);
 
+       netdev_completed_queue(ag->dev, sent, bytes_compl);
        if ((ring->curr - ring->dirty) < (ring->size * 3) / 4)
                netif_wake_queue(ag->dev);
 
@@ -863,6 +858,7 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit)
 {
        struct net_device *dev = ag->dev;
        struct ag71xx_ring *ring = &ag->rx_ring;
+       int offset = ag71xx_buffer_offset(ag);
        int done = 0;
 
        DBG("%s: rx packets, limit=%d, curr=%u, dirty=%u\n",
@@ -885,18 +881,25 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit)
 
                ag71xx_wr(ag, AG71XX_REG_RX_STATUS, RX_STATUS_PR);
 
-               skb = ring->buf[i].skb;
                pktlen = ag71xx_desc_pktlen(desc);
                pktlen -= ETH_FCS_LEN;
 
                dma_unmap_single(&dev->dev, ring->buf[i].dma_addr,
-                                AG71XX_RX_PKT_SIZE, DMA_FROM_DEVICE);
+                                AG71XX_RX_BUF_SIZE, DMA_FROM_DEVICE);
 
                dev->last_rx = jiffies;
                dev->stats.rx_packets++;
                dev->stats.rx_bytes += pktlen;
 
+               skb = build_skb(ring->buf[i].rx_buf, 0);
+               if (!skb) {
+                       kfree(ring->buf[i].rx_buf);
+                       goto next;
+               }
+
+               skb_reserve(skb, offset);
                skb_put(skb, pktlen);
+
                if (ag71xx_has_ar8216(ag))
                        err = ag71xx_remove_ar8216_header(ag, skb, pktlen);
 
@@ -906,15 +909,12 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit)
                } else {
                        skb->dev = dev;
                        skb->ip_summed = CHECKSUM_NONE;
-                       if (ag->phy_dev) {
-                               ag->phy_dev->netif_receive_skb(skb);
-                       } else {
-                               skb->protocol = eth_type_trans(skb, dev);
-                               netif_receive_skb(skb);
-                       }
+                       skb->protocol = eth_type_trans(skb, dev);
+                       netif_receive_skb(skb);
                }
 
-               ring->buf[i].skb = NULL;
+next:
+               ring->buf[i].rx_buf = NULL;
                done++;
 
                ring->curr++;
@@ -948,7 +948,7 @@ static int ag71xx_poll(struct napi_struct *napi, int limit)
        ag71xx_debugfs_update_napi_stats(ag, rx_done, tx_done);
 
        rx_ring = &ag->rx_ring;
-       if (rx_ring->buf[rx_ring->dirty % rx_ring->size].skb == NULL)
+       if (rx_ring->buf[rx_ring->dirty % rx_ring->size].rx_buf == NULL)
                goto oom;
 
        status = ag71xx_rr(ag, AG71XX_REG_RX_STATUS);
@@ -1056,6 +1056,27 @@ static const struct net_device_ops ag71xx_netdev_ops = {
 #endif
 };
 
+static __devinit const char *ag71xx_get_phy_if_mode_name(phy_interface_t mode)
+{
+       switch (mode) {
+       case PHY_INTERFACE_MODE_MII:
+               return "MII";
+       case PHY_INTERFACE_MODE_GMII:
+               return "GMII";
+       case PHY_INTERFACE_MODE_RMII:
+               return "RMII";
+       case PHY_INTERFACE_MODE_RGMII:
+               return "RGMII";
+       case PHY_INTERFACE_MODE_SGMII:
+               return "SGMII";
+       default:
+               break;
+       }
+
+       return "unknown";
+}
+
+
 static int __devinit ag71xx_probe(struct platform_device *pdev)
 {
        struct net_device *dev;
@@ -1071,7 +1092,7 @@ static int __devinit ag71xx_probe(struct platform_device *pdev)
                goto err_out;
        }
 
-       if (pdata->mii_bus_dev == NULL) {
+       if (pdata->mii_bus_dev == NULL && pdata->phy_mask) {
                dev_err(&pdev->dev, "no MII bus device specified\n");
                err = -EINVAL;
                goto err_out;
@@ -1149,8 +1170,9 @@ static int __devinit ag71xx_probe(struct platform_device *pdev)
                goto err_free_desc;
        }
 
-       pr_info("%s: Atheros AG71xx at 0x%08lx, irq %d\n",
-               dev->name, dev->base_addr, dev->irq);
+       pr_info("%s: Atheros AG71xx at 0x%08lx, irq %d, mode:%s\n",
+               dev->name, dev->base_addr, dev->irq,
+               ag71xx_get_phy_if_mode_name(pdata->phy_if_mode));
 
        ag71xx_dump_regs(ag);