ath9k: fix an invalid pointer access in the tx path
[openwrt.git] / package / mac80211 / patches / 300-pending_work.patch
index 87a30ef..9044396 100644 (file)
---- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
-+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
-@@ -510,7 +510,11 @@ int ath9k_hw_process_rxdesc_edma(struct 
-                */
-               if (rxsp->status11 & AR_CRCErr)
-                       rxs->rs_status |= ATH9K_RXERR_CRC;
--              else if (rxsp->status11 & AR_PHYErr) {
-+              else if (rxsp->status11 & AR_DecryptCRCErr)
-+                      rxs->rs_status |= ATH9K_RXERR_DECRYPT;
-+              else if (rxsp->status11 & AR_MichaelErr)
-+                      rxs->rs_status |= ATH9K_RXERR_MIC;
-+              if (rxsp->status11 & AR_PHYErr) {
-                       phyerr = MS(rxsp->status11, AR_PHYErrCode);
-                       /*
-                        * If we reach a point here where AR_PostDelimCRCErr is
-@@ -532,11 +536,7 @@ int ath9k_hw_process_rxdesc_edma(struct 
-                               rxs->rs_status |= ATH9K_RXERR_PHY;
-                               rxs->rs_phyerr = phyerr;
-                       }
--
--              } else if (rxsp->status11 & AR_DecryptCRCErr)
--                      rxs->rs_status |= ATH9K_RXERR_DECRYPT;
--              else if (rxsp->status11 & AR_MichaelErr)
--                      rxs->rs_status |= ATH9K_RXERR_MIC;
-+              };
-       }
+--- a/drivers/net/wireless/ath/ath5k/base.c
++++ b/drivers/net/wireless/ath/ath5k/base.c
+@@ -2417,6 +2417,22 @@ ath5k_tx_complete_poll_work(struct work_
+ * Initialization routines *
+ \*************************/
  
-       if (rxsp->status11 & AR_KeyMiss)
---- a/drivers/net/wireless/ath/carl9170/tx.c
-+++ b/drivers/net/wireless/ath/carl9170/tx.c
-@@ -1236,6 +1236,7 @@ static bool carl9170_tx_ps_drop(struct a
++static const struct ieee80211_iface_limit if_limits[] = {
++      { .max = 2048,  .types = BIT(NL80211_IFTYPE_STATION) },
++      { .max = 4,     .types =
++#ifdef CONFIG_MAC80211_MESH
++                               BIT(NL80211_IFTYPE_MESH_POINT) |
++#endif
++                               BIT(NL80211_IFTYPE_AP) },
++};
++
++static const struct ieee80211_iface_combination if_comb = {
++      .limits = if_limits,
++      .n_limits = ARRAY_SIZE(if_limits),
++      .max_interfaces = 2048,
++      .num_different_channels = 1,
++};
++
+ int __devinit
+ ath5k_init_ah(struct ath5k_hw *ah, const struct ath_bus_ops *bus_ops)
  {
-       struct ieee80211_sta *sta;
-       struct carl9170_sta_info *sta_info;
-+      struct ieee80211_tx_info *tx_info;
-       rcu_read_lock();
-       sta = __carl9170_get_tx_sta(ar, skb);
-@@ -1243,12 +1244,13 @@ static bool carl9170_tx_ps_drop(struct a
-               goto out_rcu;
-       sta_info = (void *) sta->drv_priv;
--      if (unlikely(sta_info->sleeping)) {
--              struct ieee80211_tx_info *tx_info;
-+      tx_info = IEEE80211_SKB_CB(skb);
-+      if (unlikely(sta_info->sleeping) &&
-+          !(tx_info->flags & (IEEE80211_TX_CTL_NO_PS_BUFFER |
-+                              IEEE80211_TX_CTL_CLEAR_PS_FILT))) {
-               rcu_read_unlock();
--              tx_info = IEEE80211_SKB_CB(skb);
-               if (tx_info->flags & IEEE80211_TX_CTL_AMPDU)
-                       atomic_dec(&ar->tx_ampdu_upload);
---- a/drivers/net/wireless/iwlegacy/4965-mac.c
-+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
-@@ -1694,7 +1694,7 @@ il4965_tx_skb(struct il_priv *il, struct
-               sta_priv = (void *)sta->drv_priv;
-       if (sta_priv && sta_priv->asleep &&
--          (info->flags & IEEE80211_TX_CTL_POLL_RESPONSE)) {
-+          (info->flags & IEEE80211_TX_CTL_NO_PS_BUFFER)) {
-               /*
-                * This sends an asynchronous command to the device,
-                * but we can rely on it being processed before the
---- a/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
-+++ b/drivers/net/wireless/iwlwifi/iwl-agn-tx.c
-@@ -322,7 +322,7 @@ int iwlagn_tx_skb(struct iwl_priv *priv,
-               sta_priv = (void *)info->control.sta->drv_priv;
-       if (sta_priv && sta_priv->asleep &&
--          (info->flags & IEEE80211_TX_CTL_POLL_RESPONSE)) {
-+          (info->flags & IEEE80211_TX_CTL_NO_PS_BUFFER)) {
-               /*
-                * This sends an asynchronous command to the device,
-                * but we can rely on it being processed before the
-@@ -331,6 +331,10 @@ int iwlagn_tx_skb(struct iwl_priv *priv,
-                * counter.
-                * For now set the counter to just 1 since we do not
-                * support uAPSD yet.
-+               *
-+               * FIXME: If we get two non-bufferable frames one
-+               * after the other, we might only send out one of
-+               * them because this is racy.
-                */
-               iwl_sta_modify_sleep_tx_count(priv, sta_id, 1);
-       }
---- a/drivers/net/wireless/p54/txrx.c
-+++ b/drivers/net/wireless/p54/txrx.c
-@@ -690,7 +690,7 @@ static void p54_tx_80211_header(struct p
-       if (!(info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ))
-               *flags |= P54_HDR_FLAG_DATA_OUT_SEQNR;
--      if (info->flags & IEEE80211_TX_CTL_POLL_RESPONSE)
-+      if (info->flags & IEEE80211_TX_CTL_NO_PS_BUFFER)
-               *flags |= P54_HDR_FLAG_DATA_OUT_NOCANCEL;
-       if (info->flags & IEEE80211_TX_CTL_CLEAR_PS_FILT)
---- a/include/net/mac80211.h
-+++ b/include/net/mac80211.h
-@@ -341,9 +341,9 @@ struct ieee80211_bss_conf {
-  *    used to indicate that a frame was already retried due to PS
-  * @IEEE80211_TX_INTFL_DONT_ENCRYPT: completely internal to mac80211,
-  *    used to indicate frame should not be encrypted
-- * @IEEE80211_TX_CTL_POLL_RESPONSE: This frame is a response to a poll
-- *    frame (PS-Poll or uAPSD) and should be sent although the station
-- *    is in powersave mode.
-+ * @IEEE80211_TX_CTL_NO_PS_BUFFER: This frame is a response to a poll
-+ *    frame (PS-Poll or uAPSD) or a non-bufferable MMPDU and must
-+ *    be sent although the station is in powersave mode.
-  * @IEEE80211_TX_CTL_MORE_FRAMES: More frames will be passed to the
-  *    transmit function after the current frame, this can be used
-  *    by drivers to kick the DMA queue only if unset or when the
-@@ -399,7 +399,7 @@ enum mac80211_tx_control_flags {
-       IEEE80211_TX_INTFL_NEED_TXPROCESSING    = BIT(14),
-       IEEE80211_TX_INTFL_RETRIED              = BIT(15),
-       IEEE80211_TX_INTFL_DONT_ENCRYPT         = BIT(16),
--      IEEE80211_TX_CTL_POLL_RESPONSE          = BIT(17),
-+      IEEE80211_TX_CTL_NO_PS_BUFFER           = BIT(17),
-       IEEE80211_TX_CTL_MORE_FRAMES            = BIT(18),
-       IEEE80211_TX_INTFL_RETRANSMISSION       = BIT(19),
-       /* hole at 20, use later */
-@@ -425,7 +425,7 @@ enum mac80211_tx_control_flags {
-       IEEE80211_TX_CTL_SEND_AFTER_DTIM | IEEE80211_TX_CTL_AMPDU |           \
-       IEEE80211_TX_STAT_TX_FILTERED | IEEE80211_TX_STAT_ACK |               \
-       IEEE80211_TX_STAT_AMPDU | IEEE80211_TX_STAT_AMPDU_NO_BACK |           \
--      IEEE80211_TX_CTL_RATE_CTRL_PROBE | IEEE80211_TX_CTL_POLL_RESPONSE |   \
-+      IEEE80211_TX_CTL_RATE_CTRL_PROBE | IEEE80211_TX_CTL_NO_PS_BUFFER |    \
-       IEEE80211_TX_CTL_MORE_FRAMES | IEEE80211_TX_CTL_LDPC |                \
-       IEEE80211_TX_CTL_STBC | IEEE80211_TX_STATUS_EOSP)
-@@ -1634,7 +1634,7 @@ void ieee80211_free_txskb(struct ieee802
-  * the station sends a PS-Poll or a uAPSD trigger frame, mac80211
-  * will inform the driver of this with the @allow_buffered_frames
-  * callback; this callback is optional. mac80211 will then transmit
-- * the frames as usual and set the %IEEE80211_TX_CTL_POLL_RESPONSE
-+ * the frames as usual and set the %IEEE80211_TX_CTL_NO_PS_BUFFER
-  * on each frame. The last frame in the service period (or the only
-  * response to a PS-Poll) also has %IEEE80211_TX_STATUS_EOSP set to
-  * indicate that it ends the service period; as this frame must have
-@@ -1642,6 +1642,9 @@ void ieee80211_free_txskb(struct ieee802
-  * When TX status is reported for this frame, the service period is
-  * marked has having ended and a new one can be started by the peer.
-  *
-+ * Additionally, non-bufferable MMPDUs can also be transmitted by
-+ * mac80211 with the %IEEE80211_TX_CTL_NO_PS_BUFFER set in them.
-+ *
-  * Another race condition can happen on some devices like iwlwifi
-  * when there are frames queued for the station and it wakes up
-  * or polls; the frames that are already queued could end up being
-@@ -2140,7 +2143,7 @@ enum ieee80211_frame_release_type {
-  * @allow_buffered_frames: Prepare device to allow the given number of frames
-  *    to go out to the given station. The frames will be sent by mac80211
-  *    via the usual TX path after this call. The TX information for frames
-- *    released will also have the %IEEE80211_TX_CTL_POLL_RESPONSE flag set
-+ *    released will also have the %IEEE80211_TX_CTL_NO_PS_BUFFER flag set
-  *    and the last one will also have %IEEE80211_TX_STATUS_EOSP set. In case
-  *    frames from multiple TIDs are released and the driver might reorder
-  *    them between the TIDs, it must set the %IEEE80211_TX_STATUS_EOSP flag
+@@ -2438,6 +2454,9 @@ ath5k_init_ah(struct ath5k_hw *ah, const
+               BIT(NL80211_IFTYPE_ADHOC) |
+               BIT(NL80211_IFTYPE_MESH_POINT);
++      hw->wiphy->iface_combinations = &if_comb;
++      hw->wiphy->n_iface_combinations = 1;
++
+       /* SW support for IBSS_RSN is provided by mac80211 */
+       hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
 --- a/net/mac80211/agg-rx.c
 +++ b/net/mac80211/agg-rx.c
-@@ -187,6 +187,8 @@ static void ieee80211_send_addba_resp(st
+@@ -145,15 +145,20 @@ static void sta_rx_agg_session_timer_exp
+       struct tid_ampdu_rx *tid_rx;
+       unsigned long timeout;
++      rcu_read_lock();
+       tid_rx = rcu_dereference(sta->ampdu_mlme.tid_rx[*ptid]);
+-      if (!tid_rx)
++      if (!tid_rx) {
++              rcu_read_unlock();
+               return;
++      }
+       timeout = tid_rx->last_rx + TU_TO_JIFFIES(tid_rx->timeout);
+       if (time_is_after_jiffies(timeout)) {
+               mod_timer(&tid_rx->session_timer, timeout);
++              rcu_read_unlock();
+               return;
+       }
++      rcu_read_unlock();
+ #ifdef CONFIG_MAC80211_HT_DEBUG
+       printk(KERN_DEBUG "rx session timer expired on tid %d\n", (u16)*ptid);
+@@ -200,6 +205,8 @@ static void ieee80211_send_addba_resp(st
                memcpy(mgmt->bssid, sdata->u.mgd.bssid, ETH_ALEN);
        else if (sdata->vif.type == NL80211_IFTYPE_ADHOC)
                memcpy(mgmt->bssid, sdata->u.ibss.bssid, ETH_ALEN);
                memcpy(mgmt->bssid, sdata->vif.addr, ETH_ALEN);
        else if (sdata->vif.type == NL80211_IFTYPE_STATION)
                memcpy(mgmt->bssid, sdata->u.mgd.bssid, ETH_ALEN);
-@@ -471,6 +472,7 @@ int ieee80211_start_tx_ba_session(struct
+@@ -490,6 +491,7 @@ int ieee80211_start_tx_ba_session(struct
            sdata->vif.type != NL80211_IFTYPE_MESH_POINT &&
            sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
            sdata->vif.type != NL80211_IFTYPE_AP &&
        test_sta_flag(sta, WLAN_STA_##flg) ? #flg "\n" : ""
  
        int res = scnprintf(buf, sizeof(buf),
--                          "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
-+                          "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
+-                          "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
++                          "%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s",
                            TEST(AUTH), TEST(ASSOC), TEST(PS_STA),
                            TEST(PS_DRIVER), TEST(AUTHORIZED),
                            TEST(SHORT_PREAMBLE),
                            TEST(TDLS_PEER_AUTH), TEST(4ADDR_EVENT),
 --- a/net/mac80211/iface.c
 +++ b/net/mac80211/iface.c
-@@ -178,7 +178,6 @@ static int ieee80211_do_open(struct net_
+@@ -284,7 +284,6 @@ static int ieee80211_do_open(struct net_
  {
        struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
        struct ieee80211_local *local = sdata->local;
        u32 changed = 0;
        int res;
        u32 hw_reconf_flags = 0;
-@@ -309,28 +308,6 @@ static int ieee80211_do_open(struct net_
+@@ -430,28 +429,6 @@ static int ieee80211_do_open(struct net_
  
        set_bit(SDATA_STATE_RUNNING, &sdata->state);
  
        /*
         * set_multicast_list will be invoked by the networking core
         * which will check whether any increments here were done in
-@@ -357,8 +334,7 @@ static int ieee80211_do_open(struct net_
-       netif_tx_start_all_queues(dev);
-       return 0;
-- err_del_interface:
--      drv_remove_interface(local, sdata);
-+
-  err_stop:
-       if (!local->open_count)
-               drv_stop(local);
-@@ -722,6 +698,70 @@ static void ieee80211_if_setup(struct ne
+@@ -642,6 +619,8 @@ static void ieee80211_do_stop(struct iee
+               ieee80211_configure_filter(local);
+               break;
+       default:
++              flush_work(&local->hw_roc_start);
++              flush_work(&local->hw_roc_done);
+               flush_work(&sdata->work);
+               /*
+                * When we get here, the interface is marked down.
+@@ -848,6 +827,72 @@ static void ieee80211_if_setup(struct ne
        dev->destructor = free_netdev;
  }
  
 +      ieee802_11_parse_elems(mgmt->u.probe_resp.variable,
 +                             skb->len - baselen, &elems);
 +
-+      rates = ieee80211_sta_get_rates(local, &elems, band);
++      rates = ieee80211_sta_get_rates(local, &elems, band, NULL);
 +
 +      rcu_read_lock();
 +
 +              set_sta_flag(sta, WLAN_STA_WME);
 +
 +      if (new) {
-+              set_sta_flag(sta, WLAN_STA_AUTHORIZED);
++              sta_info_pre_move_state(sta, IEEE80211_STA_AUTH);
++              sta_info_pre_move_state(sta, IEEE80211_STA_ASSOC);
++              sta_info_pre_move_state(sta, IEEE80211_STA_AUTHORIZED);
 +              rate_control_rate_init(sta);
 +              sta_info_insert_rcu(sta);
 +      }
  static void ieee80211_iface_work(struct work_struct *work)
  {
        struct ieee80211_sub_if_data *sdata =
-@@ -826,6 +866,9 @@ static void ieee80211_iface_work(struct 
+@@ -952,6 +997,9 @@ static void ieee80211_iface_work(struct 
                                break;
                        ieee80211_mesh_rx_queued_mgmt(sdata, skb);
                        break;
                        break;
 --- a/net/mac80211/rx.c
 +++ b/net/mac80211/rx.c
-@@ -2282,6 +2282,7 @@ ieee80211_rx_h_action(struct ieee80211_r
+@@ -2284,6 +2284,7 @@ ieee80211_rx_h_action(struct ieee80211_r
                    sdata->vif.type != NL80211_IFTYPE_MESH_POINT &&
                    sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
                    sdata->vif.type != NL80211_IFTYPE_AP &&
                    sdata->vif.type != NL80211_IFTYPE_ADHOC)
                        break;
  
-@@ -2492,14 +2493,15 @@ ieee80211_rx_h_mgmt(struct ieee80211_rx_
+@@ -2498,14 +2499,15 @@ ieee80211_rx_h_mgmt(struct ieee80211_rx_
  
        if (!ieee80211_vif_is_mesh(&sdata->vif) &&
            sdata->vif.type != NL80211_IFTYPE_ADHOC &&
                break;
        case cpu_to_le16(IEEE80211_STYPE_ASSOC_RESP):
        case cpu_to_le16(IEEE80211_STYPE_REASSOC_RESP):
-@@ -2853,10 +2855,16 @@ static int prepare_for_handlers(struct i
+@@ -2839,10 +2841,16 @@ static int prepare_for_handlers(struct i
                }
                break;
        case NL80211_IFTYPE_WDS:
                break;
        default:
                /* should never get here */
---- a/net/mac80211/sta_info.c
-+++ b/net/mac80211/sta_info.c
-@@ -1050,7 +1050,7 @@ static void ieee80211_send_null_response
-        * exchange. Also set EOSP to indicate this packet
-        * ends the poll/service period.
-        */
--      info->flags |= IEEE80211_TX_CTL_POLL_RESPONSE |
-+      info->flags |= IEEE80211_TX_CTL_NO_PS_BUFFER |
-                      IEEE80211_TX_STATUS_EOSP |
-                      IEEE80211_TX_CTL_REQ_TX_STATUS;
-@@ -1177,7 +1177,7 @@ ieee80211_sta_ps_deliver_response(struct
-                        * STA may still remain is PS mode after this frame
-                        * exchange.
-                        */
--                      info->flags |= IEEE80211_TX_CTL_POLL_RESPONSE;
-+                      info->flags |= IEEE80211_TX_CTL_NO_PS_BUFFER;
-                       /*
-                        * Use MoreData flag to indicate whether there are
 --- a/net/mac80211/sta_info.h
 +++ b/net/mac80211/sta_info.h
-@@ -31,7 +31,6 @@
+@@ -32,7 +32,6 @@
   * @WLAN_STA_SHORT_PREAMBLE: Station is capable of receiving short-preamble
   *    frames.
   * @WLAN_STA_WME: Station is a QoS-STA.
   * @WLAN_STA_CLEAR_PS_FILT: Clear PS filter in hardware (using the
   *    IEEE80211_TX_CTL_CLEAR_PS_FILT control flag) when the next
   *    frame to this station is transmitted.
-@@ -62,7 +61,6 @@ enum ieee80211_sta_info_flags {
+@@ -64,7 +63,6 @@ enum ieee80211_sta_info_flags {
        WLAN_STA_AUTHORIZED,
        WLAN_STA_SHORT_PREAMBLE,
        WLAN_STA_WME,
        WLAN_STA_CLEAR_PS_FILT,
        WLAN_STA_MFP,
        WLAN_STA_BLOCK_BA,
---- a/net/mac80211/tx.c
-+++ b/net/mac80211/tx.c
-@@ -448,18 +448,23 @@ ieee80211_tx_h_unicast_ps_buf(struct iee
-       struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)tx->skb->data;
-       struct ieee80211_local *local = tx->local;
--      if (unlikely(!sta ||
--                   ieee80211_is_probe_resp(hdr->frame_control) ||
--                   ieee80211_is_auth(hdr->frame_control) ||
--                   ieee80211_is_assoc_resp(hdr->frame_control) ||
--                   ieee80211_is_reassoc_resp(hdr->frame_control)))
-+      if (unlikely(!sta))
-               return TX_CONTINUE;
-       if (unlikely((test_sta_flag(sta, WLAN_STA_PS_STA) ||
-                     test_sta_flag(sta, WLAN_STA_PS_DRIVER)) &&
--                   !(info->flags & IEEE80211_TX_CTL_POLL_RESPONSE))) {
-+                   !(info->flags & IEEE80211_TX_CTL_NO_PS_BUFFER))) {
-               int ac = skb_get_queue_mapping(tx->skb);
-+              /* only deauth, disassoc and action are bufferable MMPDUs */
-+              if (ieee80211_is_mgmt(hdr->frame_control) &&
-+                  !ieee80211_is_deauth(hdr->frame_control) &&
-+                  !ieee80211_is_disassoc(hdr->frame_control) &&
-+                  !ieee80211_is_action(hdr->frame_control)) {
-+                      info->flags |= IEEE80211_TX_CTL_NO_PS_BUFFER;
-+                      return TX_CONTINUE;
-+              }
+--- a/net/mac80211/util.c
++++ b/net/mac80211/util.c
+@@ -804,7 +804,7 @@ void ieee80211_set_wmm_default(struct ie
+       struct ieee80211_local *local = sdata->local;
+       struct ieee80211_tx_queue_params qparam;
+       int ac;
+-      bool use_11b;
++      bool use_11b, enable_qos;
+       int aCWmin, aCWmax;
+       if (!local->ops->conf_tx)
+@@ -818,6 +818,13 @@ void ieee80211_set_wmm_default(struct ie
+       use_11b = (local->hw.conf.channel->band == IEEE80211_BAND_2GHZ) &&
+                !(sdata->flags & IEEE80211_SDATA_OPERATING_GMODE);
++      /*
++       * By default disable QoS in STA mode for old access points, which do
++       * not support 802.11e. New APs will provide proper queue parameters,
++       * that we will configure later.
++       */
++      enable_qos = (sdata->vif.type != NL80211_IFTYPE_STATION);
 +
- #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
-               printk(KERN_DEBUG "STA %pM aid %d: PS buffer for AC %d\n",
-                      sta->sta.addr, sta->sta.aid, ac);
---- a/net/mac80211/ieee80211_i.h
-+++ b/net/mac80211/ieee80211_i.h
-@@ -480,7 +480,7 @@ struct ieee80211_if_ibss {
-       bool control_port;
--      u8 bssid[ETH_ALEN];
-+      u8 bssid[ETH_ALEN] __aligned(2);
-       u8 ssid[IEEE80211_MAX_SSID_LEN];
-       u8 ssid_len, ie_len;
-       u8 *ie;
+       for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) {
+               /* Set defaults according to 802.11-2007 Table 7-37 */
+               aCWmax = 1023;
+@@ -826,38 +833,47 @@ void ieee80211_set_wmm_default(struct ie
+               else
+                       aCWmin = 15;
+-              switch (ac) {
+-              case IEEE80211_AC_BK:
+-                      qparam.cw_max = aCWmax;
+-                      qparam.cw_min = aCWmin;
+-                      qparam.txop = 0;
+-                      qparam.aifs = 7;
+-                      break;
+-              default: /* never happens but let's not leave undefined */
+-              case IEEE80211_AC_BE:
++              if (enable_qos) {
++                      switch (ac) {
++                      case IEEE80211_AC_BK:
++                              qparam.cw_max = aCWmax;
++                              qparam.cw_min = aCWmin;
++                              qparam.txop = 0;
++                              qparam.aifs = 7;
++                              break;
++                      /* never happens but let's not leave undefined */
++                      default:
++                      case IEEE80211_AC_BE:
++                              qparam.cw_max = aCWmax;
++                              qparam.cw_min = aCWmin;
++                              qparam.txop = 0;
++                              qparam.aifs = 3;
++                              break;
++                      case IEEE80211_AC_VI:
++                              qparam.cw_max = aCWmin;
++                              qparam.cw_min = (aCWmin + 1) / 2 - 1;
++                              if (use_11b)
++                                      qparam.txop = 6016/32;
++                              else
++                                      qparam.txop = 3008/32;
++                              qparam.aifs = 2;
++                              break;
++                      case IEEE80211_AC_VO:
++                              qparam.cw_max = (aCWmin + 1) / 2 - 1;
++                              qparam.cw_min = (aCWmin + 1) / 4 - 1;
++                              if (use_11b)
++                                      qparam.txop = 3264/32;
++                              else
++                                      qparam.txop = 1504/32;
++                              qparam.aifs = 2;
++                              break;
++                      }
++              } else {
++                      /* Confiure old 802.11b/g medium access rules. */
+                       qparam.cw_max = aCWmax;
+                       qparam.cw_min = aCWmin;
+                       qparam.txop = 0;
+-                      qparam.aifs = 3;
+-                      break;
+-              case IEEE80211_AC_VI:
+-                      qparam.cw_max = aCWmin;
+-                      qparam.cw_min = (aCWmin + 1) / 2 - 1;
+-                      if (use_11b)
+-                              qparam.txop = 6016/32;
+-                      else
+-                              qparam.txop = 3008/32;
+                       qparam.aifs = 2;
+-                      break;
+-              case IEEE80211_AC_VO:
+-                      qparam.cw_max = (aCWmin + 1) / 2 - 1;
+-                      qparam.cw_min = (aCWmin + 1) / 4 - 1;
+-                      if (use_11b)
+-                              qparam.txop = 3264/32;
+-                      else
+-                              qparam.txop = 1504/32;
+-                      qparam.aifs = 2;
+-                      break;
+               }
+               qparam.uapsd = false;
+@@ -866,12 +882,8 @@ void ieee80211_set_wmm_default(struct ie
+               drv_conf_tx(local, sdata, ac, &qparam);
+       }
+-      /* after reinitialize QoS TX queues setting to default,
+-       * disable QoS at all */
+-
+       if (sdata->vif.type != NL80211_IFTYPE_MONITOR) {
+-              sdata->vif.bss_conf.qos =
+-                      sdata->vif.type != NL80211_IFTYPE_STATION;
++              sdata->vif.bss_conf.qos = enable_qos;
+               if (bss_notify)
+                       ieee80211_bss_info_change_notify(sdata,
+                                                        BSS_CHANGED_QOS);
+--- a/drivers/net/wireless/ath/ath9k/beacon.c
++++ b/drivers/net/wireless/ath/ath9k/beacon.c
+@@ -48,7 +48,10 @@ int ath_beaconq_config(struct ath_softc 
+               txq = sc->tx.txq_map[WME_AC_BE];
+               ath9k_hw_get_txq_props(ah, txq->axq_qnum, &qi_be);
+               qi.tqi_aifs = qi_be.tqi_aifs;
+-              qi.tqi_cwmin = 4*qi_be.tqi_cwmin;
++              if (ah->slottime == ATH9K_SLOT_TIME_20)
++                      qi.tqi_cwmin = 2*qi_be.tqi_cwmin;
++              else
++                      qi.tqi_cwmin = 4*qi_be.tqi_cwmin;
+               qi.tqi_cwmax = qi_be.tqi_cwmax;
+       }
+--- a/net/mac80211/mlme.c
++++ b/net/mac80211/mlme.c
+@@ -1220,6 +1220,22 @@ static void ieee80211_sta_wmm_params(str
+       sdata->vif.bss_conf.qos = true;
+ }
++static void __ieee80211_stop_poll(struct ieee80211_sub_if_data *sdata)
++{
++      lockdep_assert_held(&sdata->local->mtx);
++
++      sdata->u.mgd.flags &= ~(IEEE80211_STA_CONNECTION_POLL |
++                              IEEE80211_STA_BEACON_POLL);
++      ieee80211_run_deferred_scan(sdata->local);
++}
++
++static void ieee80211_stop_poll(struct ieee80211_sub_if_data *sdata)
++{
++      mutex_lock(&sdata->local->mtx);
++      __ieee80211_stop_poll(sdata);
++      mutex_unlock(&sdata->local->mtx);
++}
++
+ static u32 ieee80211_handle_bss_capability(struct ieee80211_sub_if_data *sdata,
+                                          u16 capab, bool erp_valid, u8 erp)
+ {
+@@ -1285,8 +1301,7 @@ static void ieee80211_set_associated(str
+       sdata->u.mgd.flags |= IEEE80211_STA_RESET_SIGNAL_AVE;
+       /* just to be sure */
+-      sdata->u.mgd.flags &= ~(IEEE80211_STA_CONNECTION_POLL |
+-                              IEEE80211_STA_BEACON_POLL);
++      ieee80211_stop_poll(sdata);
+       ieee80211_led_assoc(local, 1);
+@@ -1456,8 +1471,7 @@ static void ieee80211_reset_ap_probe(str
+               return;
+       }
+-      ifmgd->flags &= ~(IEEE80211_STA_CONNECTION_POLL |
+-                        IEEE80211_STA_BEACON_POLL);
++      __ieee80211_stop_poll(sdata);
+       mutex_lock(&local->iflist_mtx);
+       ieee80211_recalc_ps(local, -1);
+@@ -1477,7 +1491,6 @@ static void ieee80211_reset_ap_probe(str
+                 round_jiffies_up(jiffies +
+                                  IEEE80211_CONNECTION_IDLE_TIME));
+ out:
+-      ieee80211_run_deferred_scan(local);
+       mutex_unlock(&local->mtx);
+ }
+@@ -2413,7 +2426,11 @@ static void ieee80211_rx_mgmt_beacon(str
+                              "to a received beacon\n", sdata->name);
+               }
+ #endif
++              mutex_lock(&local->mtx);
+               ifmgd->flags &= ~IEEE80211_STA_BEACON_POLL;
++              ieee80211_run_deferred_scan(local);
++              mutex_unlock(&local->mtx);
++
+               mutex_lock(&local->iflist_mtx);
+               ieee80211_recalc_ps(local, -1);
+               mutex_unlock(&local->iflist_mtx);
+@@ -2600,8 +2617,7 @@ static void ieee80211_sta_connection_los
+       struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
+       u8 frame_buf[DEAUTH_DISASSOC_LEN];
+-      ifmgd->flags &= ~(IEEE80211_STA_CONNECTION_POLL |
+-                        IEEE80211_STA_BEACON_POLL);
++      ieee80211_stop_poll(sdata);
+       ieee80211_set_disassoc(sdata, IEEE80211_STYPE_DEAUTH, reason,
+                              false, frame_buf);
+@@ -2879,8 +2895,7 @@ static void ieee80211_restart_sta_timer(
+       u32 flags;
+       if (sdata->vif.type == NL80211_IFTYPE_STATION) {
+-              sdata->u.mgd.flags &= ~(IEEE80211_STA_BEACON_POLL |
+-                                      IEEE80211_STA_CONNECTION_POLL);
++              __ieee80211_stop_poll(sdata);
+               /* let's probe the connection once */
+               flags = sdata->local->hw.flags;
+@@ -2949,7 +2964,10 @@ void ieee80211_sta_restart(struct ieee80
+       if (test_and_clear_bit(TMR_RUNNING_CHANSW, &ifmgd->timers_running))
+               add_timer(&ifmgd->chswitch_timer);
+       ieee80211_sta_reset_beacon_monitor(sdata);
++
++      mutex_lock(&sdata->local->mtx);
+       ieee80211_restart_sta_timer(sdata);
++      mutex_unlock(&sdata->local->mtx);
+ }
+ #endif
+--- a/drivers/net/wireless/ath/ath9k/ath9k.h
++++ b/drivers/net/wireless/ath/ath9k/ath9k.h
+@@ -214,6 +214,7 @@ struct ath_frame_info {
+       enum ath9k_key_type keytype;
+       u8 keyix;
+       u8 retries;
++      bool short_preamble;
+ };
+ struct ath_buf_state {
+--- a/drivers/net/wireless/ath/ath9k/xmit.c
++++ b/drivers/net/wireless/ath/ath9k/xmit.c
+@@ -938,6 +938,7 @@ static void ath_buf_set_rate(struct ath_
+       struct ieee80211_tx_rate *rates;
+       const struct ieee80211_rate *rate;
+       struct ieee80211_hdr *hdr;
++      struct ath_frame_info *fi = get_frame_info(bf->bf_mpdu);
+       int i;
+       u8 rix = 0;
+@@ -957,8 +958,7 @@ static void ath_buf_set_rate(struct ath_
+       rate = ieee80211_get_rts_cts_rate(sc->hw, tx_info);
+       info->rtscts_rate = rate->hw_value;
+-      if (tx_info->control.vif &&
+-          tx_info->control.vif->bss_conf.use_short_preamble)
++      if (fi->short_preamble)
+               info->rtscts_rate |= rate->hw_value_short;
+       for (i = 0; i < 4; i++) {
+@@ -1779,6 +1779,11 @@ static void setup_frame_info(struct ieee
+       struct ath_frame_info *fi = get_frame_info(skb);
+       struct ath_node *an = NULL;
+       enum ath9k_key_type keytype;
++      bool short_preamble = false;
++
++      if (tx_info->control.vif &&
++          tx_info->control.vif->bss_conf.use_short_preamble)
++              short_preamble = true;
+       keytype = ath9k_cmn_get_hw_crypto_keytype(skb);
+@@ -1794,6 +1799,7 @@ static void setup_frame_info(struct ieee
+               fi->keyix = ATH9K_TXKEYIX_INVALID;
+       fi->keytype = keytype;
+       fi->framelen = framelen;
++      fi->short_preamble = short_preamble;
+ }
+ u8 ath_txchainmask_reduction(struct ath_softc *sc, u8 chainmask, u32 rate)