only overwrite config files at commit time when actual changes were made

[project/uci.git] / list.c

diff --git a/list.c b/list.c
index ab2683c..24382c8 100644 (file)
--- a/list.c
+++ b/list.c
@@ -2,9 +2,9 @@
  * libuci - Library for the Unified Configuration Interface
  * Copyright (C) 2008 Felix Fietkau <nbd@openwrt.org>
  *
- * this program is free software; you can redistribute it and/or modify
- * it under the terms of the gnu lesser general public license version 2.1
- * as published by the free software foundation
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License version 2.1
+ * as published by the Free Software Foundation
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -163,7 +163,7 @@ uci_add_history(struct uci_context *ctx, struct uci_package *p, int cmd, char *s
                return;
 
        if (value)
-               size += strlen(section) + 1;
+               size += strlen(value) + 1;
 
        h = uci_alloc_element(ctx, history, option, size);
        ptr = uci_dataptr(h);
@@ -339,7 +339,7 @@ int uci_set_element_value(struct uci_context *ctx, struct uci_element **element,
        list = e->list.prev;
        switch(e->type) {
        case UCI_TYPE_SECTION:
-               UCI_ASSERT(ctx, uci_validate_name(value));
+               UCI_ASSERT(ctx, uci_validate_str(value, false));
                size = sizeof(struct uci_section);
                s = uci_to_section(e);
                section = e->name;
@@ -433,7 +433,7 @@ int uci_set(struct uci_context *ctx, struct uci_package *p, char *section, char
                UCI_ASSERT(ctx, uci_validate_name(option));
                UCI_ASSERT(ctx, value != NULL);
        } else {
-               UCI_ASSERT(ctx, uci_validate_name(value));
+               UCI_ASSERT(ctx, uci_validate_str(value, false));
        }
 
        /*
@@ -446,7 +446,7 @@ int uci_set(struct uci_context *ctx, struct uci_package *p, char *section, char
                goto notfound;
 
        s = uci_to_section(e);
-       if (ctx->pctx)
+       if (ctx->pctx && ctx->pctx->merge)
                ctx->pctx->section = s;
 
        if (option) {
@@ -485,7 +485,7 @@ notfound:
                uci_alloc_option(s, option, value);
        else {
                s = uci_alloc_section(p, value, section);
-               if (ctx->pctx)
+               if (ctx->pctx && ctx->pctx->merge)
                        ctx->pctx->section = s;
        }