change uci_list_configs api for proper exception handling

[project/uci.git] / cli.c

diff --git a/cli.c b/cli.c
index 043ba1a..3d25b7c 100644 (file)
--- a/cli.c
+++ b/cli.c
@@ -12,6 +12,7 @@
  */
 #include <strings.h>
 #include <stdlib.h>
+#include <unistd.h>
 #include "uci.h"
 
 static const char *appname = "uci";
@@ -32,6 +33,10 @@ static void uci_usage(int argc, char **argv)
                "\tshow     [<config>[.<section>[.<option>]]]\n"
                "\tget      <config>.<section>[.<option>]\n"
                "\tset      <config>.<section>[.<option>]=<value>\n"
+               "\n"
+               "Options:\n"
+               "\t-s       force strict mode (stop on parser errors)\n"
+               "\t-S       disable strict mode\n"
                "\n",
                argv[0]
        );
@@ -65,16 +70,17 @@ static int uci_show(int argc, char **argv)
 {
        char *section = (argc > 2 ? argv[2] : NULL);
        struct uci_package *package;
-       char **configs;
+       char **configs = NULL;
        char **p;
 
-       configs = uci_list_configs(ctx);
-       if (!configs)
-               return 0;
+       if ((uci_list_configs(ctx, &configs) != UCI_OK) || !configs) {
+               uci_perror(ctx, appname);
+               return 1;
+       }
 
        if (argc >= 2) {
                if (uci_load(ctx, argv[1], &package) != UCI_OK) {
-                       uci_perror(ctx, NULL);
+                       uci_perror(ctx, appname);
                        return 1;
                }
                uci_show_package(package, section);
@@ -85,7 +91,7 @@ static int uci_show(int argc, char **argv)
        for (p = configs; *p; p++) {
                if ((argc < 2) || !strcmp(argv[1], *p)) {
                        if (uci_load(ctx, *p, &package) != UCI_OK) {
-                               uci_perror(ctx, NULL);
+                               uci_perror(ctx, appname);
                                return 1;
                        }
                        uci_show_package(package, section);
@@ -98,11 +104,13 @@ static int uci_show(int argc, char **argv)
 
 static int uci_do_export(int argc, char **argv)
 {
-       char **configs = uci_list_configs(ctx);
+       char **configs = NULL;
        char **p;
 
-       if (!configs)
-               return 0;
+       if ((uci_list_configs(ctx, &configs) != UCI_OK) || !configs) {
+               uci_perror(ctx, appname);
+               return 1;
+       }
 
        for (p = configs; *p; p++) {
                if ((argc < 2) || !strcmp(argv[1], *p)) {
@@ -208,13 +216,39 @@ static int uci_cmd(int argc, char **argv)
 int main(int argc, char **argv)
 {
        int ret;
+       int c;
 
        ctx = uci_alloc_context();
+       if (!ctx) {
+               fprintf(stderr, "Out of memory\n");
+               return 1;
+       }
+
+       while((c = getopt(argc, argv, "sS")) != -1) {
+               switch(c) {
+                       case 's':
+                               ctx->flags |= UCI_FLAG_STRICT;
+                               break;
+                       case 'S':
+                               ctx->flags &= ~UCI_FLAG_STRICT;
+                               ctx->flags |= UCI_FLAG_PERROR;
+                               break;
+                       default:
+                               uci_usage(argc, argv);
+                               break;
+               }
+       }
+       if (optind > 1)
+               argv[optind - 1] = argv[0];
+       argv += optind - 1;
+       argc -= optind - 1;
+
        if (argc < 2)
                uci_usage(argc, argv);
        ret = uci_cmd(argc - 1, argv + 1);
        if (ret == 255)
                uci_usage(argc, argv);
+
        uci_free_context(ctx);
 
        return ret;