From: Felix Fietkau <nbd@openwrt.org>
Date: Tue, 12 Feb 2013 16:25:56 +0000 (+0100)
Subject: add validation for hotplug commands
X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fprocd.git;a=commitdiff_plain;h=144991354372ae010c84ec7d9efecb03ad3fae74

add validation for hotplug commands

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---

diff --git a/hotplug-rule.c b/hotplug-rule.c
index a2d8892..7508b1d 100644
--- a/hotplug-rule.c
+++ b/hotplug-rule.c
@@ -379,6 +379,11 @@ static int cmd_process_strings(struct blob_attr *attr, struct blob_attr *msg)
 		if (args++ < 0)
 			continue;
 
+		if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING) {
+			rule_error(attr, "Invalid argument in command");
+			return -1;
+		}
+
 		cmd_add_string(blobmsg_data(cur), msg);
 	}
 
@@ -398,7 +403,10 @@ static int __rule_process_cmd(struct blob_attr *cur, struct blob_attr *msg)
 		return ret;
 
 	name = blobmsg_data(blobmsg_data(cur));
-	cmd_process_strings(cur, msg);
+	ret = cmd_process_strings(cur, msg);
+	if (ret)
+		return ret;
+
 	rule_handle_command(name, blob_data(b.head));
 
 	return 0;