X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=main.c;h=c918203b259cc35b83551f41f86b528c4f523bea;hp=6419fe9167dc978f34479636cba5f6c3b35f7c65;hb=39f9caf261f99a4c944c59ad2be0473051fd43ec;hpb=6b3f6f4466e5584f2bdefc55b3ca34186b65acb9 diff --git a/main.c b/main.c index 6419fe9..c918203 100644 --- a/main.c +++ b/main.c @@ -3,6 +3,9 @@ #include #include #include +#include +#include +#include #include "netifd.h" #include "ubus.h" @@ -18,12 +21,106 @@ static char **global_argv; static struct list_head process_list = LIST_HEAD_INIT(process_list); static struct list_head fds = LIST_HEAD_INIT(fds); +#ifdef DUMMY_MODE +#define use_syslog false +#else +static bool use_syslog = true; +#endif + + +static void +netifd_delete_process(struct netifd_process *proc) +{ + if (proc->uloop.pending) + uloop_process_delete(&proc->uloop); + list_del(&proc->list); + netifd_fd_delete(&proc->log_fd); +} + +void +netifd_log_message(int priority, const char *format, ...) +{ + va_list vl; + + va_start(vl, format); + if (use_syslog) + vsyslog(priority, format, vl); + else + vfprintf(stderr, format, vl); + va_end(vl); +} + +static void +netifd_process_log_cb(struct uloop_fd *fd, unsigned int events) +{ + struct netifd_process *proc; + const char *log_prefix; + char *buf, *cur; + int maxlen, len, read_len; + + proc = container_of(fd, struct netifd_process, log_uloop); + + if (!proc->log_buf) + proc->log_buf = malloc(LOG_BUF_SIZE + 1); + + buf = proc->log_buf + proc->log_buf_ofs; + maxlen = LOG_BUF_SIZE - proc->log_buf_ofs; + + log_prefix = proc->log_prefix; + if (!log_prefix) + log_prefix = "process"; + +retry: + read_len = len = read(fd->fd, buf, maxlen); + if (len <= 0) { + if (errno == EINTR) + goto retry; + + return; + } + proc->log_buf_ofs += len; + + cur = buf; + buf = proc->log_buf; + while ((cur = memchr(cur, '\n', len))) { + *cur = 0; + + if (!proc->log_overflow) + netifd_log_message(LOG_NOTICE, "%s (%d): %s\n", + log_prefix, proc->uloop.pid, buf); + else + proc->log_overflow = false; + + cur++; + len -= cur - buf; + buf = cur; + } + + if (buf > proc->log_buf && len > 0) + memmove(buf, proc->log_buf, len); + + if (len == LOG_BUF_SIZE) { + if (!proc->log_overflow) { + proc->log_buf[LOG_BUF_SIZE] = 0; + netifd_log_message(LOG_NOTICE, "%s (%d): %s [...]\n", + log_prefix, proc->uloop.pid, proc->log_buf); + proc->log_overflow = true; + } + len = 0; + } + proc->log_buf_ofs = len; + + if (read_len == maxlen) + goto retry; +} + static void netifd_process_cb(struct uloop_process *proc, int ret) { struct netifd_process *np; np = container_of(proc, struct netifd_process, uloop); - list_del(&np->list); + netifd_process_log_cb(&np->log_uloop, 0); + netifd_delete_process(np); return np->cb(np, ret); } @@ -31,13 +128,17 @@ int netifd_start_process(const char **argv, char **env, struct netifd_process *proc) { struct netifd_fd *fd; + int pfds[2]; int pid; netifd_kill_process(proc); - if ((pid = fork()) < 0) + if (pipe(pfds) < 0) return -1; + if ((pid = fork()) < 0) + goto error; + if (!pid) { if (env) { while (*env) { @@ -55,19 +156,37 @@ netifd_start_process(const char **argv, char **env, struct netifd_process *proc) close(fd->fd); } + dup2(pfds[1], 0); + dup2(pfds[1], 1); + dup2(pfds[1], 2); + + close(pfds[0]); + close(pfds[1]); + execvp(argv[0], (char **) argv); exit(127); } if (pid < 0) - return -1; + goto error; + close(pfds[1]); proc->uloop.cb = netifd_process_cb; proc->uloop.pid = pid; uloop_process_add(&proc->uloop); list_add_tail(&proc->list, &process_list); + proc->log_uloop.fd = proc->log_fd.fd = pfds[0]; + proc->log_uloop.cb = netifd_process_log_cb; + netifd_fd_add(&proc->log_fd); + uloop_fd_add(&proc->log_uloop, ULOOP_EDGE_TRIGGER | ULOOP_READ); + return 0; + +error: + close(pfds[0]); + close(pfds[1]); + return -1; } void @@ -77,8 +196,7 @@ netifd_kill_process(struct netifd_process *proc) return; kill(proc->uloop.pid, SIGTERM); - uloop_process_delete(&proc->uloop); - list_del(&proc->list); + netifd_delete_process(proc); } void @@ -127,6 +245,7 @@ static int usage(const char *progname) " -p : Path to netifd addons (default: %s)\n" " -h : Path to the hotplug script\n" " -r : Path to resolv.conf\n" + " -S: Use stderr instead of syslog for log messages\n" " (default: "DEFAULT_HOTPLUG_PATH")\n" "\n", progname, main_path); @@ -151,6 +270,9 @@ netifd_setup_signals(void) sigaction(SIGTERM, &s, NULL); sigaction(SIGUSR1, &s, NULL); sigaction(SIGUSR2, &s, NULL); + + s.sa_handler = SIG_IGN; + sigaction(SIGPIPE, &s, NULL); } static void @@ -169,7 +291,7 @@ int main(int argc, char **argv) global_argv = argv; - while ((ch = getopt(argc, argv, "d:s:p:h:r:")) != -1) { + while ((ch = getopt(argc, argv, "d:s:p:h:r:S")) != -1) { switch(ch) { case 'd': debug_mask = strtoul(optarg, NULL, 0); @@ -186,11 +308,19 @@ int main(int argc, char **argv) case 'r': resolv_conf = optarg; break; +#ifndef DUMMY_MODE + case 'S': + use_syslog = false; + break; +#endif default: return usage(argv[0]); } } + if (use_syslog) + openlog("netifd", 0, LOG_DAEMON); + netifd_setup_signals(); if (netifd_ubus_init(socket) < 0) { fprintf(stderr, "Failed to connect to ubus\n"); @@ -209,5 +339,8 @@ int main(int argc, char **argv) netifd_ubus_done(); + if (use_syslog) + closelog(); + return 0; }