X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=main.c;h=2fc3733faaf9a4e5205efee68915b282a221ffa5;hp=f180c30b1826dbfbd136e6df2476a6e4b8aaddf8;hb=8f689d09814add5e1b22577cc104e2eb5e16c66f;hpb=8699ae1f82f685b26cc8fcbcc4779c7988e0cb17

diff --git a/main.c b/main.c
index f180c30..2fc3733 100644
--- a/main.c
+++ b/main.c
@@ -46,6 +46,10 @@ netifd_delete_process(struct netifd_process *proc)
 		uloop_process_delete(&proc->uloop);
 	list_del(&proc->list);
 	netifd_fd_delete(&proc->log_fd);
+	if (proc->log_buf) {
+		free(proc->log_buf);
+		proc->log_buf = NULL;
+	}
 }
 
 void
@@ -77,17 +81,16 @@ netifd_process_log_cb(struct uloop_fd *fd, unsigned int events)
 	if (!proc->log_buf)
 		proc->log_buf = malloc(LOG_BUF_SIZE + 1);
 
-	buf = proc->log_buf + proc->log_buf_ofs;
-	maxlen = LOG_BUF_SIZE - proc->log_buf_ofs;
-
 	log_prefix = proc->log_prefix;
 	if (!log_prefix)
 		log_prefix = "process";
 
 retry:
+	buf = proc->log_buf + proc->log_buf_ofs;
+	maxlen = LOG_BUF_SIZE - proc->log_buf_ofs;
 	read_len = len = read(fd->fd, buf, maxlen);
 	if (len < 0) {
-		if (errno == EAGAIN)
+		if (errno == EINTR)
 			goto retry;
 
 		goto out;
@@ -98,7 +101,7 @@ retry:
 
 	cur = buf;
 	buf = proc->log_buf;
-	while ((cur = memchr(cur, '\n', len))) {
+	while (len > 0 && (cur = memchr(cur, '\n', len))) {
 		*cur = 0;
 
 		if (!proc->log_overflow)
@@ -126,7 +129,7 @@ retry:
 	}
 	proc->log_buf_ofs = len;
 
-	if (read_len == maxlen)
+	if (read_len > 0)
 		goto retry;
 
 out:
@@ -196,6 +199,7 @@ netifd_start_process(const char **argv, char **env, struct netifd_process *proc)
 	uloop_process_add(&proc->uloop);
 	list_add_tail(&proc->list, &process_list);
 
+	proc->log_buf_ofs = 0;
 	proc->log_uloop.fd = proc->log_fd.fd = pfds[0];
 	proc->log_uloop.cb = netifd_process_log_cb;
 	netifd_fd_add(&proc->log_fd);