X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=interface.c;h=93016280227f02c3100c0743594078451bc8a2e0;hp=902f55b802e119819520b13cdd370252cf4739c5;hb=23bb091077348d3b87b9900ae3ff923cdd25a662;hpb=b7d1c27b752df3e6c5dfe6a5b789d6cb0c87d0f6 diff --git a/interface.c b/interface.c index 902f55b..9301628 100644 --- a/interface.c +++ b/interface.c @@ -81,6 +81,42 @@ void interface_add_error(struct interface *iface, const char *subsystem, } static void +interface_data_del(struct interface *iface, struct interface_data *data) +{ + avl_delete(&iface->data, &data->node); + free(data); +} + +static void +interface_data_flush(struct interface *iface) +{ + struct interface_data *d, *tmp; + + avl_for_each_element_safe(&iface->data, d, node, tmp) + interface_data_del(iface, d); +} + +int +interface_add_data(struct interface *iface, const struct blob_attr *data) +{ + struct interface_data *n, *o; + + if (!blobmsg_check_attr(data, true)) + return UBUS_STATUS_INVALID_ARGUMENT; + + n = calloc(1, sizeof(*data) + blob_pad_len(data)); + memcpy(n->data, data, blob_pad_len(data)); + n->node.key = blobmsg_name(data); + + o = avl_find_element(&iface->data, n->node.key, o, node); + if (o) + interface_data_del(iface, o); + + avl_insert(&iface->data, &n->node); + return 0; +} + +static void interface_event(struct interface *iface, enum interface_event ev) { struct interface_user *dep, *tmp; @@ -98,6 +134,7 @@ interface_flush_state(struct interface *iface) device_release(&iface->main_dev); if (iface->l3_dev.dev) device_release(&iface->l3_dev); + interface_data_flush(iface); } static void @@ -105,7 +142,10 @@ mark_interface_down(struct interface *iface) { if (iface->state == IFS_UP) interface_event(iface, IFEV_DOWN); + interface_ip_set_enabled(&iface->config_ip, false); + interface_ip_flush(&iface->proto_ip); interface_flush_state(iface); + system_flush_routes(); iface->state = IFS_DOWN; } @@ -121,8 +161,6 @@ __interface_set_down(struct interface *iface, bool force) if (iface->state == IFS_UP) interface_event(iface, IFEV_DOWN); iface->state = IFS_TEARDOWN; - interface_ip_flush(&iface->config_ip); - interface_ip_flush(&iface->proto_ip); interface_proto_event(iface->proto, PROTO_CMD_TEARDOWN, force); if (force) interface_flush_state(iface); @@ -205,6 +243,7 @@ interface_cleanup(struct interface *iface, bool reload) list_for_each_entry_safe(dep, tmp, &iface->users, list) interface_remove_user(dep); + interface_dequeue_event(iface); interface_ip_flush(&iface->config_ip); interface_flush_state(iface); interface_clear_errors(iface); @@ -272,8 +311,6 @@ interface_proto_cb(struct interface_proto_state *state, enum interface_proto_eve return; netifd_log_message(L_NOTICE, "Interface '%s' is now down\n", iface->name); - interface_ip_set_enabled(&iface->config_ip, false); - system_flush_routes(); mark_interface_down(iface); interface_handle_config_change(iface); break; @@ -282,8 +319,7 @@ interface_proto_cb(struct interface_proto_state *state, enum interface_proto_eve return; netifd_log_message(L_NOTICE, "Interface '%s' has lost the connection\n", iface->name); - if (iface->state == IFS_UP) - interface_event(iface, IFEV_DOWN); + mark_interface_down(iface); iface->state = IFS_SETUP; break; } @@ -316,8 +352,8 @@ interface_init(struct interface *iface, const char *name, INIT_LIST_HEAD(&iface->errors); INIT_LIST_HEAD(&iface->users); INIT_LIST_HEAD(&iface->hotplug_list); - interface_ip_init(&iface->proto_ip, iface); - interface_ip_init(&iface->config_ip, iface); + interface_ip_init(iface); + avl_init(&iface->data, avl_strcmp, false, NULL); iface->config_ip.enabled = false; iface->main_dev.cb = interface_cb; @@ -382,10 +418,10 @@ interface_set_main_dev(struct interface *iface, struct device *dev) if (iface->main_dev.dev == dev) return; - device_add_user(&iface->main_dev, dev); if (set_l3) interface_set_l3_dev(iface, dev); + device_add_user(&iface->main_dev, dev); if (claimed) device_claim(&iface->l3_dev); @@ -510,15 +546,7 @@ interface_update_start(struct interface *iface) void interface_update_complete(struct interface *iface) { - struct device_route *route; - interface_ip_update_complete(&iface->proto_ip); - vlist_for_each_element(&iface->config_ip.route, route, node) { - if (iface->l3_dev.dev) { - system_add_route(iface->l3_dev.dev, route); - route->enabled = true; - } - } } static void