X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=interface-ip.c;h=914ec07132d5a2a7706e2a757eabf7d53acfbf01;hp=7f10120f878617900ef87f5ae576b8ce343684b4;hb=46d52638f04c471a0e86d07ccae6a188f1a05ef5;hpb=73a32ab092ae32ec97e20b61512998c8411b8bd5

diff --git a/interface-ip.c b/interface-ip.c
index 7f10120..914ec07 100644
--- a/interface-ip.c
+++ b/interface-ip.c
@@ -64,6 +64,7 @@ interface_ip_add_route(struct interface *iface, struct blob_attr *attr, bool v6)
 	if (!route)
 		return;
 
+	route->flags = v6 ? DEVADDR_INET6 : DEVADDR_INET4;
 	route->mask = v6 ? 128 : 32;
 	if ((cur = tb[ROUTE_MASK]) != NULL) {
 		route->mask = parse_netmask_string(blobmsg_data(cur), v6);
@@ -83,19 +84,17 @@ interface_ip_add_route(struct interface *iface, struct blob_attr *attr, bool v6)
 			DPRINTF("Failed to parse route gateway: %s\n", (char *) blobmsg_data(cur));
 			goto error;
 		}
-	} else {
-		route->flags |= DEVADDR_DEVICE;
 	}
 
-	if ((cur = tb[ROUTE_METRIC]) != NULL)
+	if ((cur = tb[ROUTE_METRIC]) != NULL) {
 		route->metric = blobmsg_get_u32(cur);
-	else
-		route->metric = -1;
+		route->flags |= DEVROUTE_METRIC;
+	}
 
 	if ((cur = tb[ROUTE_MTU]) != NULL)
 		route->mtu = blobmsg_get_u32(cur);
 
-	vlist_add(&ip->route, &route->node);
+	vlist_add(&ip->route, &route->node, &route->flags);
 	return;
 
 error:
@@ -106,14 +105,14 @@ static int
 addr_cmp(const void *k1, const void *k2, void *ptr)
 {
 	return memcmp(k1, k2, sizeof(struct device_addr) -
-		      offsetof(struct device_addr, mask));
+		      offsetof(struct device_addr, flags));
 }
 
 static int
 route_cmp(const void *k1, const void *k2, void *ptr)
 {
 	return memcmp(k1, k2, sizeof(struct device_route) -
-		      offsetof(struct device_route, mask));
+		      offsetof(struct device_route, flags));
 }
 
 static void
@@ -129,7 +128,7 @@ interface_update_proto_addr(struct vlist_tree *tree,
 
 	ip = container_of(tree, struct interface_ip_settings, addr);
 	iface = ip->iface;
-	dev = iface->l3_dev->dev;
+	dev = iface->l3_dev.dev;
 
 	if (node_new) {
 		a_new = container_of(node_new, struct device_addr, node);
@@ -178,7 +177,7 @@ enable_route(struct interface_ip_settings *ip, struct device_route *route)
 	if (ip->no_defaultroute && !route->mask)
 		return false;
 
-	return true;
+	return ip->enabled;
 }
 
 static void
@@ -194,7 +193,7 @@ interface_update_proto_route(struct vlist_tree *tree,
 
 	ip = container_of(tree, struct interface_ip_settings, route);
 	iface = ip->iface;
-	dev = iface->l3_dev->dev;
+	dev = iface->l3_dev.dev;
 
 	route_old = container_of(node_old, struct device_route, node);
 	route_new = container_of(node_new, struct device_route, node);
@@ -214,6 +213,7 @@ interface_update_proto_route(struct vlist_tree *tree,
 		if (!(route_new->flags & DEVADDR_EXTERNAL) && !keep && _enabled)
 			system_add_route(dev, route_new);
 
+		route_new->iface = iface;
 		route_new->enabled = _enabled;
 	}
 }
@@ -354,7 +354,7 @@ void interface_ip_set_enabled(struct interface_ip_settings *ip, bool enabled)
 	struct device *dev;
 
 	ip->enabled = enabled;
-	dev = ip->iface->l3_dev->dev;
+	dev = ip->iface->l3_dev.dev;
 	if (!dev)
 		return;
 
@@ -378,9 +378,12 @@ void interface_ip_set_enabled(struct interface_ip_settings *ip, bool enabled)
 		if (route->enabled == _enabled)
 			continue;
 
-		if (_enabled)
+		if (_enabled) {
+			if (!(route->flags & DEVROUTE_METRIC))
+				route->metric = ip->iface->metric;
+
 			system_add_route(dev, route);
-		else
+		} else
 			system_del_route(dev, route);
 		route->enabled = _enabled;
 	}
@@ -420,8 +423,6 @@ interface_ip_init(struct interface_ip_settings *ip, struct interface *iface)
 	ip->enabled = true;
 	vlist_simple_init(&ip->dns_search, struct dns_search_domain, node);
 	vlist_simple_init(&ip->dns_servers, struct dns_server, node);
-	vlist_init(&ip->route, route_cmp, interface_update_proto_route,
-		   struct device_route, node, mask);
-	vlist_init(&ip->addr, addr_cmp, interface_update_proto_addr,
-		   struct device_addr, node, mask);
+	vlist_init(&ip->route, route_cmp, interface_update_proto_route);
+	vlist_init(&ip->addr, addr_cmp, interface_update_proto_addr);
 }