X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=device.c;h=5b27ce0f5c3693616b7bf23c4123c01f427cec40;hp=b40f661bf84bd500a5470e38b15a2d74e2e79203;hb=b2ebc3bb0bf9859c67c75abf264ed8e4fa54ec61;hpb=ba4b80512c3c8e777db6b536f281e0bc74c054ad

diff --git a/device.c b/device.c
index b40f661..5b27ce0 100644
--- a/device.c
+++ b/device.c
@@ -141,8 +141,11 @@ int device_claim(struct device_user *dep)
 	ret = dev->set_state(dev, true);
 	if (ret == 0)
 		device_broadcast_event(dev, DEV_EVENT_UP);
-	else
+	else {
+		D(DEVICE, "claim device %s failed: %d\n", dev->ifname, ret);
 		dev->active = 0;
+		dep->claimed = false;
+	}
 
 	return ret;
 }
@@ -208,7 +211,20 @@ int device_init(struct device *dev, const struct device_type *type, const char *
 	return 0;
 }
 
-struct device *device_get(const char *name, bool create)
+static struct device *
+device_create_default(const char *name)
+{
+	struct device *dev;
+
+	D(DEVICE, "Create simple device '%s'\n", name);
+	dev = calloc(1, sizeof(*dev));
+	device_init(dev, &simple_device_type, name);
+	dev->default_config = true;
+	return dev;
+}
+
+struct device *
+device_get(const char *name, bool create)
 {
 	struct device *dev;
 
@@ -222,10 +238,18 @@ struct device *device_get(const char *name, bool create)
 	if (!create)
 		return NULL;
 
-	dev = calloc(1, sizeof(*dev));
-	device_init(dev, &simple_device_type, name);
+	return device_create_default(name);
+}
 
-	return dev;
+static void
+device_delete(struct device *dev)
+{
+	if (!dev->avl.key)
+		return;
+
+	D(DEVICE, "Delete device '%s' from list\n", dev->ifname);
+	avl_delete(&devices, &dev->avl);
+	dev->avl.key = NULL;
 }
 
 void device_cleanup(struct device *dev)
@@ -238,10 +262,10 @@ void device_cleanup(struct device *dev)
 			continue;
 
 		dep->cb(dep, DEV_EVENT_REMOVE);
+		device_release(dep);
 	}
 
-	if (dev->avl.key)
-		avl_delete(&devices, &dev->avl);
+	device_delete(dev);
 }
 
 void device_set_present(struct device *dev, bool state)
@@ -268,7 +292,7 @@ void device_add_user(struct device_user *dep, struct device *dev)
 static void
 __device_free_unused(struct device *dev)
 {
-	if (!list_empty(&dev->users))
+	if (!list_empty(&dev->users) || dev->current_config || config_init)
 		return;
 
 	device_free(dev);
@@ -315,26 +339,32 @@ device_init_pending(void)
 enum dev_change_type
 device_reload_config(struct device *dev, struct blob_attr *attr)
 {
-	struct blob_attr *tb[__DEV_ATTR_MAX], *tb1[__DEV_ATTR_MAX];
-
-	blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb,
-		blob_data(attr), blob_len(attr));
-	if (dev->config)
-		blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb1,
-			blob_data(dev->config), blob_len(dev->config));
-	else
-		memset(tb1, 0, sizeof(tb1));
+	struct blob_attr *tb[__DEV_ATTR_MAX];
+	const struct config_param_list *cfg = dev->type->config_params;
 
-	if (!config_diff(tb, tb1, &device_attr_list, NULL))
+	if (config_check_equal(dev->config, attr, cfg))
 		return DEV_CONFIG_NO_CHANGE;
 
-	device_init_settings(dev, tb);
-	return DEV_CONFIG_APPLIED;
+	if (cfg == &device_attr_list) {
+		memset(tb, 0, sizeof(tb));
+
+		if (dev->config)
+			blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb,
+				blob_data(attr), blob_len(attr));
+
+		device_init_settings(dev, tb);
+		return DEV_CONFIG_APPLIED;
+	} else
+		return DEV_CONFIG_RECREATE;
 }
 
 static enum dev_change_type
-device_check_config(struct device *dev, struct blob_attr *attr)
+device_check_config(struct device *dev, const struct device_type *type,
+		    struct blob_attr *attr)
 {
+	if (type != dev->type)
+		return DEV_CONFIG_RECREATE;
+
 	if (dev->type->reload)
 		return dev->type->reload(dev, attr);
 
@@ -351,8 +381,9 @@ device_replace(struct device *dev, struct device *odev)
 		device_set_present(odev, false);
 
 	list_for_each_entry_safe(dep, tmp, &odev->users, list) {
-		device_remove_user(dep);
-		device_add_user(dep, dev);
+		device_release(dep);
+		list_move_tail(&dep->list, &dev->users);
+		dep->dev = dev;
 	}
 	device_free(odev);
 
@@ -360,6 +391,32 @@ device_replace(struct device *dev, struct device *odev)
 		device_set_present(dev, true);
 }
 
+void
+device_reset_config(void)
+{
+	struct device *dev;
+
+	avl_for_each_element(&devices, dev, avl)
+		dev->current_config = false;
+}
+
+void
+device_reset_old(void)
+{
+	struct device *dev, *tmp, *ndev;
+
+	avl_for_each_element_safe(&devices, dev, avl, tmp) {
+		if (dev->current_config || dev->default_config)
+			continue;
+
+		if (dev->type != &simple_device_type)
+			continue;
+
+		ndev = device_create_default(dev->ifname);
+		device_replace(ndev, dev);
+	}
+}
+
 struct device *
 device_create(const char *name, const struct device_type *type,
 	      struct blob_attr *config)
@@ -367,14 +424,14 @@ device_create(const char *name, const struct device_type *type,
 	struct device *odev = NULL, *dev;
 	enum dev_change_type change;
 
-	D(DEVICE, "Create new device '%s' (%s)\n", name, type->name);
 	config = config_memdup(config);
 	if (!config)
 		return NULL;
 
 	odev = device_get(name, false);
 	if (odev) {
-		change = device_check_config(odev, config);
+		odev->current_config = true;
+		change = device_check_config(odev, type, config);
 		switch (change) {
 		case DEV_CONFIG_APPLIED:
 			D(DEVICE, "Device '%s': config applied\n", odev->ifname);
@@ -384,7 +441,6 @@ device_create(const char *name, const struct device_type *type,
 				device_set_present(odev, false);
 				device_set_present(odev, true);
 			}
-			free(config);
 			return odev;
 		case DEV_CONFIG_NO_CHANGE:
 			D(DEVICE, "Device '%s': no configuration change\n", odev->ifname);
@@ -392,14 +448,17 @@ device_create(const char *name, const struct device_type *type,
 			return odev;
 		case DEV_CONFIG_RECREATE:
 			D(DEVICE, "Device '%s': recreate device\n", odev->ifname);
+			device_delete(odev);
 			break;
 		}
-	}
+	} else
+		D(DEVICE, "Create new device '%s' (%s)\n", name, type->name);
 
 	dev = type->create(config);
 	if (!dev)
 		return NULL;
 
+	dev->current_config = true;
 	dev->config = config;
 	if (odev)
 		device_replace(dev, odev);