X-Git-Url: https://git.archive.openwrt.org/?p=project%2Fnetifd.git;a=blobdiff_plain;f=device.c;h=56fc3f787713ce5eb0d9e3bf6833b460d1d264cd;hp=2df4539fb1e2ec6e6d9c036fa6fee70ceb2e94ad;hb=134775b1f41fa19a816768268b9d0f8dad86bd90;hpb=cd8b6676df948be45586b606cb32538b81e43f40

diff --git a/device.c b/device.c
index 2df4539..56fc3f7 100644
--- a/device.c
+++ b/device.c
@@ -1,3 +1,16 @@
+/*
+ * netifd - network interface daemon
+ * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
@@ -7,156 +20,232 @@
 #include <sys/socket.h>
 #include <net/ethernet.h>
 
+#ifdef linux
+#include <netinet/ether.h>
+#endif
+
 #include "netifd.h"
 #include "system.h"
 #include "config.h"
 
 static struct avl_tree devices;
 
-enum {
-	DEV_ATTR_NAME,
-	DEV_ATTR_TYPE,
-	DEV_ATTR_MTU,
-	DEV_ATTR_MACADDR,
-	DEV_ATTR_TXQUEUELEN,
-	__DEV_ATTR_MAX,
-};
-
 static const struct blobmsg_policy dev_attrs[__DEV_ATTR_MAX] = {
-	[DEV_ATTR_NAME] = { "name", BLOBMSG_TYPE_STRING },
-	[DEV_ATTR_TYPE] = { "type", BLOBMSG_TYPE_STRING },
-	[DEV_ATTR_MTU] = { "mtu", BLOBMSG_TYPE_INT32 },
-	[DEV_ATTR_MACADDR] = { "macaddr", BLOBMSG_TYPE_STRING },
-	[DEV_ATTR_TXQUEUELEN] = { "txqueuelen", BLOBMSG_TYPE_INT32 },
+	[DEV_ATTR_TYPE] = { .name = "type", .type = BLOBMSG_TYPE_STRING },
+	[DEV_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_ARRAY },
+	[DEV_ATTR_MTU] = { .name = "mtu", .type = BLOBMSG_TYPE_INT32 },
+	[DEV_ATTR_MACADDR] = { .name = "macaddr", .type = BLOBMSG_TYPE_STRING },
+	[DEV_ATTR_TXQUEUELEN] = { .name = "txqueuelen", .type = BLOBMSG_TYPE_INT32 },
+	[DEV_ATTR_ENABLED] = { .name = "enabled", .type = BLOBMSG_TYPE_BOOL },
 };
 
-const struct config_param_list device_attr_list = {
+const struct uci_blob_param_list device_attr_list = {
 	.n_params = __DEV_ATTR_MAX,
 	.params = dev_attrs,
 };
 
-static void
-device_init_settings(struct device *dev, struct blob_attr **tb)
+static int __devlock = 0;
+
+void device_lock(void)
 {
-	struct blob_attr *cur;
-	struct ether_addr *ea;
+	__devlock++;
+}
 
-	dev->flags = 0;
+void device_unlock(void)
+{
+	__devlock--;
+	if (!__devlock)
+		device_free_unused(NULL);
+}
 
-	if ((cur = tb[DEV_ATTR_MTU])) {
-		dev->mtu = blobmsg_get_u32(cur);
-		dev->flags |= DEV_OPT_MTU;
-	}
+static int set_device_state(struct device *dev, bool state)
+{
+	if (state)
+		system_if_up(dev);
+	else
+		system_if_down(dev);
 
-	if ((cur = tb[DEV_ATTR_TXQUEUELEN])) {
-		dev->txqueuelen = blobmsg_get_u32(cur);
-		dev->flags |= DEV_OPT_TXQUEUELEN;
+	return 0;
+}
+
+static int
+simple_device_set_state(struct device *dev, bool state)
+{
+	struct device *pdev;
+	int ret = 0;
+
+	pdev = dev->parent.dev;
+	if (state && !pdev) {
+		pdev = system_if_get_parent(dev);
+		if (pdev)
+			device_add_user(&dev->parent, pdev);
 	}
 
-	if ((cur = tb[DEV_ATTR_MACADDR])) {
-		ea = ether_aton(blob_data(cur));
-		if (ea) {
-			memcpy(dev->macaddr, ea, sizeof(dev->macaddr));
-			dev->flags |= DEV_OPT_MACADDR;
-		}
+	if (pdev) {
+		if (state)
+			ret = device_claim(&dev->parent);
+		else
+			device_release(&dev->parent);
+
+		if (ret < 0)
+			return ret;
 	}
+	return set_device_state(dev, state);
 }
 
-struct device *
-device_create(struct blob_attr *attr, struct uci_section *s)
+static struct device *
+simple_device_create(const char *name, struct blob_attr *attr)
 {
 	struct blob_attr *tb[__DEV_ATTR_MAX];
-	struct blob_attr *cur;
 	struct device *dev = NULL;
-	const char *name;
 
 	blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb, blob_data(attr), blob_len(attr));
-	if (!tb[DEV_ATTR_NAME])
-		return NULL;
-
-	name = blobmsg_data(tb[DEV_ATTR_NAME]);
-	if ((cur = tb[DEV_ATTR_TYPE])) {
-		if (!strcmp(blobmsg_data(cur), "bridge"))
-			dev = bridge_create(name, s);
-	} else {
-		dev = device_get(name, true);
-	}
-
+	dev = device_get(name, true);
 	if (!dev)
 		return NULL;
 
+	dev->set_state = simple_device_set_state;
 	device_init_settings(dev, tb);
 
 	return dev;
 }
 
-
-static void __init dev_init(void)
+static void simple_device_free(struct device *dev)
 {
-	avl_init(&devices, avl_strcmp, false, NULL);
+	if (dev->parent.dev)
+		device_remove_user(&dev->parent);
+	free(dev);
 }
 
-static void free_simple_device(struct device *dev)
+const struct device_type simple_device_type = {
+	.name = "Network device",
+	.config_params = &device_attr_list,
+
+	.create = simple_device_create,
+	.check_state = system_if_check,
+	.free = simple_device_free,
+};
+
+static void
+device_merge_settings(struct device *dev, struct device_settings *n)
 {
-	device_cleanup(dev);
-	free(dev);
+	struct device_settings *os = &dev->orig_settings;
+	struct device_settings *s = &dev->settings;
+
+	memset(n, 0, sizeof(*n));
+	n->mtu = s->flags & DEV_OPT_MTU ? s->mtu : os->mtu;
+	n->txqueuelen = s->flags & DEV_OPT_TXQUEUELEN ?
+		s->txqueuelen : os->txqueuelen;
+	memcpy(n->macaddr,
+		(s->flags & DEV_OPT_MACADDR ? s->macaddr : os->macaddr),
+		sizeof(n->macaddr));
+	n->flags = s->flags | os->flags;
 }
 
-static void broadcast_device_event(struct device *dev, enum device_event ev)
+void
+device_init_settings(struct device *dev, struct blob_attr **tb)
 {
-	struct device_user *dep, *tmp;
+	struct device_settings *s = &dev->settings;
+	struct blob_attr *cur;
+	struct ether_addr *ea;
+	bool disabled = false;
 
-	list_for_each_entry_safe(dep, tmp, &dev->users, list) {
-		if (!dep->cb)
-			continue;
+	s->flags = 0;
+	if ((cur = tb[DEV_ATTR_ENABLED]))
+		disabled = !blobmsg_get_bool(cur);
 
-		dep->cb(dep, ev);
+	if ((cur = tb[DEV_ATTR_MTU])) {
+		s->mtu = blobmsg_get_u32(cur);
+		s->flags |= DEV_OPT_MTU;
+	}
+
+	if ((cur = tb[DEV_ATTR_TXQUEUELEN])) {
+		s->txqueuelen = blobmsg_get_u32(cur);
+		s->flags |= DEV_OPT_TXQUEUELEN;
 	}
+
+	if ((cur = tb[DEV_ATTR_MACADDR])) {
+		ea = ether_aton(blobmsg_data(cur));
+		if (ea) {
+			memcpy(s->macaddr, ea, 6);
+			s->flags |= DEV_OPT_MACADDR;
+		}
+	}
+
+	device_set_disabled(dev, disabled);
 }
 
-static int set_device_state(struct device *dev, bool state)
+static void __init dev_init(void)
 {
-	if (state)
-		system_if_up(dev);
-	else
-		system_if_down(dev);
+	avl_init(&devices, avl_strcmp, true, NULL);
+}
+
+static int device_broadcast_cb(void *ctx, struct safe_list *list)
+{
+	struct device_user *dep = container_of(list, struct device_user, list);
+	int *ev = ctx;
 
+	if (dep->cb)
+		dep->cb(dep, *ev);
 	return 0;
 }
 
-int claim_device(struct device *dev)
+void device_broadcast_event(struct device *dev, enum device_event ev)
 {
+	int dev_ev = ev;
+
+	safe_list_for_each(&dev->aliases, device_broadcast_cb, &dev_ev);
+	safe_list_for_each(&dev->users, device_broadcast_cb, &dev_ev);
+}
+
+int device_claim(struct device_user *dep)
+{
+	struct device *dev = dep->dev;
 	int ret;
 
-	DPRINTF("claim device %s, new refcount: %d\n", dev->ifname, dev->active + 1);
+	if (dep->claimed)
+		return 0;
+
+	dep->claimed = true;
+	D(DEVICE, "Claim %s %s, new refcount: %d\n", dev->type->name, dev->ifname, dev->active + 1);
 	if (++dev->active != 1)
 		return 0;
 
-	broadcast_device_event(dev, DEV_EVENT_SETUP);
+	device_broadcast_event(dev, DEV_EVENT_SETUP);
 	ret = dev->set_state(dev, true);
 	if (ret == 0)
-		broadcast_device_event(dev, DEV_EVENT_UP);
-	else
+		device_broadcast_event(dev, DEV_EVENT_UP);
+	else {
+		D(DEVICE, "claim %s %s failed: %d\n", dev->type->name, dev->ifname, ret);
 		dev->active = 0;
+		dep->claimed = false;
+	}
 
 	return ret;
 }
 
-void release_device(struct device *dev)
+void device_release(struct device_user *dep)
 {
+	struct device *dev = dep->dev;
+
+	if (!dep->claimed)
+		return;
+
+	dep->claimed = false;
 	dev->active--;
-	DPRINTF("release device %s, new refcount: %d\n", dev->ifname, dev->active);
+	D(DEVICE, "Release %s %s, new refcount: %d\n", dev->type->name, dev->ifname, dev->active);
 	assert(dev->active >= 0);
 
 	if (dev->active)
 		return;
 
-	broadcast_device_event(dev, DEV_EVENT_TEARDOWN);
-	dev->set_state(dev, false);
-	broadcast_device_event(dev, DEV_EVENT_DOWN);
+	device_broadcast_event(dev, DEV_EVENT_TEARDOWN);
+	if (!dep->hotplug)
+		dev->set_state(dev, false);
+	device_broadcast_event(dev, DEV_EVENT_DOWN);
 }
 
-int check_device_state(struct device *dev)
+int device_check_state(struct device *dev)
 {
 	if (!dev->type->check_state)
 		return 0;
@@ -164,7 +253,7 @@ int check_device_state(struct device *dev)
 	return dev->type->check_state(dev);
 }
 
-void init_virtual_device(struct device *dev, const struct device_type *type, const char *name)
+void device_init_virtual(struct device *dev, const struct device_type *type, const char *name)
 {
 	assert(dev);
 	assert(type);
@@ -172,19 +261,20 @@ void init_virtual_device(struct device *dev, const struct device_type *type, con
 	if (name)
 		strncpy(dev->ifname, name, IFNAMSIZ);
 
-	fprintf(stderr, "Initialize device '%s'\n", dev->ifname);
-	INIT_LIST_HEAD(&dev->users);
+	D(DEVICE, "Initialize device '%s'\n", dev->ifname);
+	INIT_SAFE_LIST(&dev->users);
+	INIT_SAFE_LIST(&dev->aliases);
 	dev->type = type;
+
+	if (!dev->set_state)
+		dev->set_state = set_device_state;
 }
 
 int device_init(struct device *dev, const struct device_type *type, const char *ifname)
 {
 	int ret;
 
-	init_virtual_device(dev, type, ifname);
-
-	if (!dev->set_state)
-		dev->set_state = set_device_state;
+	device_init_virtual(dev, type, ifname);
 
 	dev->avl.key = dev->ifname;
 
@@ -192,67 +282,151 @@ int device_init(struct device *dev, const struct device_type *type, const char *
 	if (ret < 0)
 		return ret;
 
-	check_device_state(dev);
+	system_if_clear_state(dev);
+	device_check_state(dev);
 
 	return 0;
 }
 
-struct device *device_get(const char *name, bool create)
+static struct device *
+device_create_default(const char *name, bool external)
 {
-	static const struct device_type simple_type = {
-		.name = "Device",
-		.check_state = system_if_check,
-		.free = free_simple_device,
-	};
 	struct device *dev;
 
+	if (!external && system_if_force_external(name))
+		return NULL;
+
+	D(DEVICE, "Create simple device '%s'\n", name);
+	dev = calloc(1, sizeof(*dev));
+	dev->external = external;
+	dev->set_state = simple_device_set_state;
+	device_init(dev, &simple_device_type, name);
+	dev->default_config = true;
+	return dev;
+}
+
+struct device *
+device_get(const char *name, int create)
+{
+	struct device *dev;
 
 	if (strchr(name, '.'))
 		return get_vlan_device_chain(name, create);
 
+	if (name[0] == '@')
+		return device_alias_get(name + 1);
+
 	dev = avl_find_element(&devices, name, dev, avl);
-	if (dev)
+	if (dev) {
+		if (create > 1 && !dev->external) {
+			dev->external = true;
+			device_set_present(dev, true);
+		}
 		return dev;
+	}
 
 	if (!create)
 		return NULL;
 
-	dev = calloc(1, sizeof(*dev));
-	device_init(dev, &simple_type, name);
-
-	return dev;
+	return device_create_default(name, create > 1);
 }
 
-void device_cleanup(struct device *dev)
+static void
+device_delete(struct device *dev)
 {
-	struct device_user *dep, *tmp;
+	if (!dev->avl.key)
+		return;
 
-	fprintf(stderr, "Clean up device '%s'\n", dev->ifname);
-	list_for_each_entry_safe(dep, tmp, &dev->users, list) {
-		if (!dep->cb)
-			continue;
+	D(DEVICE, "Delete device '%s' from list\n", dev->ifname);
+	avl_delete(&devices, &dev->avl);
+	dev->avl.key = NULL;
+}
 
+static int device_cleanup_cb(void *ctx, struct safe_list *list)
+{
+	struct device_user *dep = container_of(list, struct device_user, list);
+	if (dep->cb)
 		dep->cb(dep, DEV_EVENT_REMOVE);
-	}
 
-	if (dev->avl.key)
-		avl_delete(&devices, &dev->avl);
+	device_release(dep);
+	return 0;
+}
+
+void device_cleanup(struct device *dev)
+{
+	D(DEVICE, "Clean up device '%s'\n", dev->ifname);
+	safe_list_for_each(&dev->users, device_cleanup_cb, NULL);
+	safe_list_for_each(&dev->aliases, device_cleanup_cb, NULL);
+	device_delete(dev);
 }
 
-void device_set_present(struct device *dev, bool state)
+static void __device_set_present(struct device *dev, bool state)
 {
 	if (dev->present == state)
 		return;
 
-	DPRINTF("Device '%s' %s present\n", dev->ifname, state ? "is now" : "is no longer" );
 	dev->present = state;
-	broadcast_device_event(dev, state ? DEV_EVENT_ADD : DEV_EVENT_REMOVE);
+	device_broadcast_event(dev, state ? DEV_EVENT_ADD : DEV_EVENT_REMOVE);
+}
+
+void
+device_refresh_present(struct device *dev)
+{
+	bool state = dev->sys_present;
+
+	if (dev->disabled || dev->deferred)
+		state = false;
+
+	__device_set_present(dev, state);
+}
+
+void device_set_present(struct device *dev, bool state)
+{
+	if (dev->sys_present == state)
+		return;
+
+	D(DEVICE, "%s '%s' %s present\n", dev->type->name, dev->ifname, state ? "is now" : "is no longer" );
+	dev->sys_present = state;
+	device_refresh_present(dev);
+}
+
+static int device_refcount(struct device *dev)
+{
+	struct list_head *list;
+	int count = 0;
+
+	list_for_each(list, &dev->users.list)
+		count++;
+
+	list_for_each(list, &dev->aliases.list)
+		count++;
+
+	return count;
 }
 
 void device_add_user(struct device_user *dep, struct device *dev)
 {
+	struct safe_list *head;
+
+	if (dep->dev == dev)
+		return;
+
+	if (dep->dev)
+		device_remove_user(dep);
+
+	if (!dev)
+		return;
+
 	dep->dev = dev;
-	list_add(&dep->list, &dev->users);
+
+	if (dep->alias)
+		head = &dev->aliases;
+	else
+		head = &dev->users;
+
+	safe_list_add(&dep->list, head);
+	D(DEVICE, "Add user for device '%s', refcount=%d\n", dev->ifname, device_refcount(dev));
+
 	if (dep->cb && dev->present) {
 		dep->cb(dep, DEV_EVENT_ADD);
 		if (dev->active)
@@ -260,29 +434,254 @@ void device_add_user(struct device_user *dep, struct device *dev)
 	}
 }
 
+void
+device_free(struct device *dev)
+{
+	__devlock++;
+	free(dev->config);
+	device_cleanup(dev);
+	dev->type->free(dev);
+	__devlock--;
+}
+
+static void
+__device_free_unused(struct device *dev)
+{
+	if (!safe_list_empty(&dev->users) ||
+		!safe_list_empty(&dev->aliases) ||
+	    dev->current_config || __devlock)
+		return;
+
+	device_free(dev);
+}
+
 void device_remove_user(struct device_user *dep)
 {
 	struct device *dev = dep->dev;
 
-	list_del(&dep->list);
+	if (!dep->dev)
+		return;
 
-	if (list_empty(&dev->users)) {
-		/* all references have gone away, remove this device */
-		device_free(dev);
-	}
+	dep->hotplug = false;
+	if (dep->claimed)
+		device_release(dep);
 
+	safe_list_del(&dep->list);
 	dep->dev = NULL;
+	D(DEVICE, "Remove user for device '%s', refcount=%d\n", dev->ifname, device_refcount(dev));
+	__device_free_unused(dev);
 }
 
 void
-device_free_all(void)
+device_free_unused(struct device *dev)
+{
+	struct device *tmp;
+
+	if (dev)
+		return __device_free_unused(dev);
+
+	avl_for_each_element_safe(&devices, dev, avl, tmp)
+		__device_free_unused(dev);
+}
+
+void
+device_init_pending(void)
 {
 	struct device *dev, *tmp;
 
 	avl_for_each_element_safe(&devices, dev, avl, tmp) {
-		if (!list_empty(&dev->users))
+		if (!dev->config_pending)
+			continue;
+
+		dev->type->config_init(dev);
+		dev->config_pending = false;
+	}
+}
+
+static enum dev_change_type
+device_reload_config(struct device *dev, struct blob_attr *attr)
+{
+	struct blob_attr *tb[__DEV_ATTR_MAX];
+	const struct uci_blob_param_list *cfg = dev->type->config_params;
+
+	if (uci_blob_check_equal(dev->config, attr, cfg))
+		return DEV_CONFIG_NO_CHANGE;
+
+	if (cfg == &device_attr_list) {
+		memset(tb, 0, sizeof(tb));
+
+		if (attr)
+			blobmsg_parse(dev_attrs, __DEV_ATTR_MAX, tb,
+				blob_data(attr), blob_len(attr));
+
+		device_init_settings(dev, tb);
+		return DEV_CONFIG_RESTART;
+	} else
+		return DEV_CONFIG_RECREATE;
+}
+
+enum dev_change_type
+device_set_config(struct device *dev, const struct device_type *type,
+		  struct blob_attr *attr)
+{
+	if (type != dev->type)
+		return DEV_CONFIG_RECREATE;
+
+	if (dev->type->reload)
+		return dev->type->reload(dev, attr);
+
+	return device_reload_config(dev, attr);
+}
+
+static void
+device_replace(struct device *dev, struct device *odev)
+{
+	struct device_user *dep, *tmp;
+	bool present = odev->present;
+
+	if (present)
+		device_set_present(odev, false);
+
+	list_for_each_entry_safe(dep, tmp, &odev->users.list, list.list) {
+		device_release(dep);
+		safe_list_del(&dep->list);
+		safe_list_add(&dep->list, &dev->users);
+		dep->dev = dev;
+	}
+	device_free(odev);
+
+	if (present)
+		device_set_present(dev, true);
+}
+
+void
+device_reset_config(void)
+{
+	struct device *dev;
+
+	avl_for_each_element(&devices, dev, avl)
+		dev->current_config = false;
+}
+
+void
+device_reset_old(void)
+{
+	struct device *dev, *tmp, *ndev;
+
+	avl_for_each_element_safe(&devices, dev, avl, tmp) {
+		if (dev->current_config || dev->default_config)
+			continue;
+
+		if (dev->type != &simple_device_type)
 			continue;
 
-		device_free(dev);
+		ndev = device_create_default(dev->ifname, dev->external);
+		device_replace(ndev, dev);
 	}
 }
+
+struct device *
+device_create(const char *name, const struct device_type *type,
+	      struct blob_attr *config)
+{
+	struct device *odev = NULL, *dev;
+	enum dev_change_type change;
+
+	config = blob_memdup(config);
+	if (!config)
+		return NULL;
+
+	odev = device_get(name, false);
+	if (odev) {
+		odev->current_config = true;
+		change = device_set_config(odev, type, config);
+		if (odev->external) {
+			system_if_apply_settings(odev, &odev->settings);
+			change = DEV_CONFIG_APPLIED;
+		}
+		switch (change) {
+		case DEV_CONFIG_RESTART:
+		case DEV_CONFIG_APPLIED:
+			D(DEVICE, "Device '%s': config applied\n", odev->ifname);
+			free(odev->config);
+			odev->config = config;
+			if (change == DEV_CONFIG_RESTART && odev->present) {
+				device_set_present(odev, false);
+				device_set_present(odev, true);
+			}
+			return odev;
+		case DEV_CONFIG_NO_CHANGE:
+			D(DEVICE, "Device '%s': no configuration change\n", odev->ifname);
+			free(config);
+			return odev;
+		case DEV_CONFIG_RECREATE:
+			D(DEVICE, "Device '%s': recreate device\n", odev->ifname);
+			device_delete(odev);
+			break;
+		}
+	} else
+		D(DEVICE, "Create new device '%s' (%s)\n", name, type->name);
+
+	dev = type->create(name, config);
+	if (!dev)
+		return NULL;
+
+	dev->current_config = true;
+	dev->config = config;
+	if (odev)
+		device_replace(dev, odev);
+
+	if (!config_init && dev->config_pending)
+		type->config_init(dev);
+
+	return dev;
+}
+
+void
+device_dump_status(struct blob_buf *b, struct device *dev)
+{
+	struct device_settings st;
+	void *c, *s;
+
+	if (!dev) {
+		avl_for_each_element(&devices, dev, avl) {
+			if (!dev->present)
+				continue;
+			c = blobmsg_open_table(b, dev->ifname);
+			device_dump_status(b, dev);
+			blobmsg_close_table(b, c);
+		}
+
+		return;
+	}
+
+	blobmsg_add_u8(b, "external", dev->external);
+	blobmsg_add_u8(b, "present", dev->present);
+	blobmsg_add_string(b, "type", dev->type->name);
+
+	if (!dev->present)
+		return;
+
+	blobmsg_add_u8(b, "up", !!dev->active);
+	if (dev->type->dump_info)
+		dev->type->dump_info(dev, b);
+	else
+		system_if_dump_info(dev, b);
+
+	if (dev->active) {
+		device_merge_settings(dev, &st);
+		if (st.flags & DEV_OPT_MTU)
+			blobmsg_add_u32(b, "mtu", st.mtu);
+		if (st.flags & DEV_OPT_MACADDR)
+			blobmsg_add_string(b, "macaddr", format_macaddr(st.macaddr));
+		if (st.flags & DEV_OPT_TXQUEUELEN)
+			blobmsg_add_u32(b, "txqueuelen", st.txqueuelen);
+	}
+
+	s = blobmsg_open_table(b, "statistics");
+	if (dev->type->dump_stats)
+		dev->type->dump_stats(dev, b);
+	else
+		system_if_dump_stats(dev, b);
+	blobmsg_close_table(b, s);
+}