ubus: check the l3_dev pointer before dereferencing it

[project/netifd.git] / ubus.c

diff --git a/ubus.c b/ubus.c
index 6a87c28..aeb864f 100644 (file)
--- a/ubus.c
+++ b/ubus.c
@@ -636,13 +636,13 @@ interface_ip_dump_dns_search_list(struct interface_ip_settings *ip,
 }
 
 static void
-netifd_dump_status(struct interface *iface, bool up)
+netifd_dump_status(struct interface *iface)
 {
        struct interface_data *data;
        struct device *dev;
        void *a, *inactive;
 
-       blobmsg_add_u8(&b, "up", up && iface->state == IFS_UP);
+       blobmsg_add_u8(&b, "up", iface->state == IFS_UP);
        blobmsg_add_u8(&b, "pending", iface->state == IFS_SETUP);
        blobmsg_add_u8(&b, "available", iface->available);
        blobmsg_add_u8(&b, "autostart", iface->autostart);
@@ -650,7 +650,8 @@ netifd_dump_status(struct interface *iface, bool up)
        if (iface->state == IFS_UP) {
                time_t cur = system_get_rtime();
                blobmsg_add_u32(&b, "uptime", cur - iface->start_time);
-               blobmsg_add_string(&b, "l3_device", iface->l3_dev.dev->ifname);
+               if (iface->l3_dev.dev)
+                       blobmsg_add_string(&b, "l3_device", iface->l3_dev.dev->ifname);
        }
 
        if (iface->proto_handler)
@@ -737,11 +738,11 @@ netifd_dump_status(struct interface *iface, bool up)
 
        a = blobmsg_open_table(&b, "data");
        avl_for_each_element(&iface->data, data, node)
-               blob_put(&b, blob_id(data->data), blob_data(data->data), blob_len(data->data));
+               blobmsg_add_blob(&b, data->data);
 
        blobmsg_close_table(&b, a);
 
-       if (!list_is_empty(&iface->errors))
+       if (!list_empty(&iface->errors))
                netifd_add_interface_errors(&b, iface);
 }
 
@@ -753,7 +754,7 @@ netifd_handle_status(struct ubus_context *ctx, struct ubus_object *obj,
        struct interface *iface = container_of(obj, struct interface, ubus);
 
        blob_buf_init(&b, 0);
-       netifd_dump_status(iface, true);
+       netifd_dump_status(iface);
        ubus_send_reply(ctx, req, b.head);
 
        return 0;
@@ -772,7 +773,7 @@ netifd_handle_dump(struct ubus_context *ctx, struct ubus_object *obj,
        vlist_for_each_element(&interfaces, iface, node) {
                void *i = blobmsg_open_table(&b, NULL);
                blobmsg_add_string(&b, "interface", iface->name);
-               netifd_dump_status(iface, true);
+               netifd_dump_status(iface);
                blobmsg_close_table(&b, i);
        }
 
@@ -1163,7 +1164,7 @@ netifd_ubus_interface_notify(struct interface *iface, bool up)
        const char *event = (up) ? "update" : "down";
        blob_buf_init(&b, 0);
        blobmsg_add_string(&b, "interface", iface->name);
-       netifd_dump_status(iface, up);
+       netifd_dump_status(iface);
        ubus_notify(ubus_ctx, &iface_object, event, b.head, -1);
        ubus_notify(ubus_ctx, &iface->ubus, event, b.head, -1);
 }