use list_add_tail instead of list_add

[project/netifd.git] / interface.c

diff --git a/interface.c b/interface.c
index 1f73130..20956be 100644 (file)
--- a/interface.c
+++ b/interface.c
@@ -12,7 +12,6 @@
 static LIST_HEAD(interfaces);
 
 enum {
-       IFACE_ATTR_TYPE,
        IFACE_ATTR_IFNAME,
        IFACE_ATTR_PROTO,
        IFACE_ATTR_AUTO,
@@ -24,9 +23,8 @@ static const union config_param_info iface_attr_info[IFACE_ATTR_MAX] = {
 };
 
 static const struct blobmsg_policy iface_attrs[IFACE_ATTR_MAX] = {
-       [IFACE_ATTR_TYPE] = { .name = "type", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_PROTO] = { .name = "proto", .type = BLOBMSG_TYPE_STRING },
-       [IFACE_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_ARRAY },
+       [IFACE_ATTR_IFNAME] = { .name = "ifname", .type = BLOBMSG_TYPE_STRING },
        [IFACE_ATTR_AUTO] = { .name = "auto", .type = BLOBMSG_TYPE_BOOL },
 };
 
@@ -91,12 +89,12 @@ static void
 mark_interface_down(struct interface *iface)
 {
        interface_del_ctx_addr(iface, NULL);
-       release_device(iface->main_dev.dev);
+       device_release(iface->main_dev.dev);
        iface->state = IFS_DOWN;
 }
 
 static int
-__set_interface_up(struct interface *iface)
+__interface_set_up(struct interface *iface)
 {
        int ret;
 
@@ -119,7 +117,7 @@ __set_interface_up(struct interface *iface)
 }
 
 static void
-__set_interface_down(struct interface *iface, bool force)
+__interface_set_down(struct interface *iface, bool force)
 {
        clear_interface_errors(iface);
 
@@ -159,9 +157,9 @@ interface_cb(struct device_user *dep, enum device_event ev)
 
        if (new_state) {
                if (iface->autostart && !config_init)
-                       set_interface_up(iface);
+                       interface_set_up(iface);
        } else
-               __set_interface_down(iface, true);
+               __interface_set_down(iface, true);
 }
 
 static void
@@ -203,14 +201,14 @@ void interface_set_proto_state(struct interface *iface, struct interface_proto_s
 }
 
 struct interface *
-alloc_interface(const char *name, struct uci_section *s, struct blob_attr *attr)
+interface_alloc(const char *name, struct uci_section *s, struct blob_attr *attr)
 {
        struct interface *iface;
        struct blob_attr *tb[IFACE_ATTR_MAX];
        struct blob_attr *cur;
        struct device *dev;
 
-       iface = get_interface(name);
+       iface = interface_get(name);
        if (iface)
                return iface;
 
@@ -218,7 +216,7 @@ alloc_interface(const char *name, struct uci_section *s, struct blob_attr *attr)
        iface->main_dev.cb = interface_cb;
        iface->l3_iface = &iface->main_dev;
        strncpy(iface->name, name, sizeof(iface->name) - 1);
-       list_add(&iface->list, &interfaces);
+       list_add_tail(&iface->list, &interfaces);
        INIT_LIST_HEAD(&iface->errors);
        INIT_LIST_HEAD(&iface->address);
        INIT_LIST_HEAD(&iface->routes);
@@ -230,11 +228,6 @@ alloc_interface(const char *name, struct uci_section *s, struct blob_attr *attr)
        blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb,
                      blob_data(attr), blob_len(attr));
 
-       if ((cur = tb[IFACE_ATTR_TYPE])) {
-               if (!strcmp(blobmsg_data(cur), "bridge"))
-                       interface_attach_bridge(iface, s);
-       }
-
        if ((cur = tb[IFACE_ATTR_IFNAME])) {
                dev = device_get(blobmsg_data(cur), true);
                if (dev)
@@ -245,7 +238,7 @@ alloc_interface(const char *name, struct uci_section *s, struct blob_attr *attr)
 }
 
 void
-free_interface(struct interface *iface)
+interface_free(struct interface *iface)
 {
        netifd_ubus_remove_interface(iface);
        list_del(&iface->list);
@@ -255,7 +248,7 @@ free_interface(struct interface *iface)
 }
 
 struct interface *
-get_interface(const char *name)
+interface_get(const char *name)
 {
        struct interface *iface;
 
@@ -296,7 +289,7 @@ interface_add_link(struct interface *iface, struct device *dev)
 }
 
 int
-set_interface_up(struct interface *iface)
+interface_set_up(struct interface *iface)
 {
        iface->autostart = true;
 
@@ -308,25 +301,25 @@ set_interface_up(struct interface *iface)
        if (iface->state != IFS_DOWN)
                return 0;
 
-       return __set_interface_up(iface);
+       return __interface_set_up(iface);
 }
 
 int
-set_interface_down(struct interface *iface)
+interface_set_down(struct interface *iface)
 {
        iface->autostart = false;
-       __set_interface_down(iface, false);
+       __interface_set_down(iface, false);
 
        return 0;
 }
 
 void
-start_pending_interfaces(void)
+interface_start_pending(void)
 {
        struct interface *iface;
 
        list_for_each_entry(iface, &interfaces, list) {
                if (iface->active && iface->autostart)
-                       set_interface_up(iface);
+                       interface_set_up(iface);
        }
 }