From f8f4fe752307e1d0c042496b642aa691589c2a5f Mon Sep 17 00:00:00 2001 From: Steven Barth Date: Tue, 29 Jul 2008 15:33:28 +0000 Subject: [PATCH 1/1] modules: Redesigned configuration save, apply, save & apply menu options --- i18n/english/luasrc/i18n/cbi.en.lua | 1 - i18n/english/luasrc/i18n/default.en.lua | 1 + i18n/german/luasrc/i18n/cbi.de.lua | 3 +-- i18n/german/luasrc/i18n/default.de.lua | 1 + libs/cbi/luasrc/view/cbi/footer.htm | 2 +- modules/admin-full/luasrc/controller/admin/uci.lua | 16 ++++++++++------ modules/admin-full/luasrc/view/admin_uci/changes.htm | 3 +++ modules/admin-mini/luasrc/controller/mini/uci.lua | 6 +++--- .../fledermaus/luasrc/view/themes/fledermaus/header.htm | 10 ++++------ .../luasrc/view/themes/openwrt.org/header.htm | 5 +---- 10 files changed, 25 insertions(+), 23 deletions(-) diff --git a/i18n/english/luasrc/i18n/cbi.en.lua b/i18n/english/luasrc/i18n/cbi.en.lua index 4cebd2488..14153989f 100644 --- a/i18n/english/luasrc/i18n/cbi.en.lua +++ b/i18n/english/luasrc/i18n/cbi.en.lua @@ -4,4 +4,3 @@ cbi_invalid = "Error: Invalid input value" cbi_addopt = "-- Additional Field --" cbi_optional = " (optional)" cbi_sectempty = "This section contains no values yet" -cbi_saveapply = "Save & Apply" diff --git a/i18n/english/luasrc/i18n/default.en.lua b/i18n/english/luasrc/i18n/default.en.lua index f48bbda46..a64d757ee 100644 --- a/i18n/english/luasrc/i18n/default.en.lua +++ b/i18n/english/luasrc/i18n/default.en.lua @@ -77,6 +77,7 @@ reset = "Reset" revert = "Revert" save = "Save" +saveapply = "Save & Apply" service = "Service" services = "Services" settings = "Settings" diff --git a/i18n/german/luasrc/i18n/cbi.de.lua b/i18n/german/luasrc/i18n/cbi.de.lua index f0eb7b6ae..1ca36305f 100644 --- a/i18n/german/luasrc/i18n/cbi.de.lua +++ b/i18n/german/luasrc/i18n/cbi.de.lua @@ -2,5 +2,4 @@ cbi_add = "Eintrag hinzufügen" cbi_del = "Eintrag entfernen" cbi_invalid = "Error: Ungültige Eingabe" cbi_addopt = "-- Zusätzliches Feld --" -cbi_sectempty = "Diese Sektion enthält noch keine Einträge" -cbi_saveapply = "Speichern & Anwenden" \ No newline at end of file +cbi_sectempty = "Diese Sektion enthält noch keine Einträge" \ No newline at end of file diff --git a/i18n/german/luasrc/i18n/default.de.lua b/i18n/german/luasrc/i18n/default.de.lua index 2c24df24a..16ab66c6a 100644 --- a/i18n/german/luasrc/i18n/default.de.lua +++ b/i18n/german/luasrc/i18n/default.de.lua @@ -78,6 +78,7 @@ reset = "Zurücksetzen" revert = "Verwerfen" save = "Speichern" +saveapply = "Speichern & Anwenden" service = "Dienst" services = "Dienste" settings = "Einstellungen" diff --git a/libs/cbi/luasrc/view/cbi/footer.htm b/libs/cbi/luasrc/view/cbi/footer.htm index 9ff8de7fd..732389c00 100644 --- a/libs/cbi/luasrc/view/cbi/footer.htm +++ b/libs/cbi/luasrc/view/cbi/footer.htm @@ -14,7 +14,7 @@ $Id$ -%>
- + diff --git a/modules/admin-full/luasrc/controller/admin/uci.lua b/modules/admin-full/luasrc/controller/admin/uci.lua index 215a13a34..d2acdeca1 100644 --- a/modules/admin-full/luasrc/controller/admin/uci.lua +++ b/modules/admin-full/luasrc/controller/admin/uci.lua @@ -17,9 +17,10 @@ function index() local i18n = luci.i18n.translate entry({"admin", "uci"}, nil, i18n("config")) - entry({"admin", "uci", "changes"}, call("action_changes"), i18n("changes")) - entry({"admin", "uci", "revert"}, call("action_revert"), i18n("revert")) - entry({"admin", "uci", "apply"}, call("action_apply"), i18n("apply")) + entry({"admin", "uci", "changes"}, call("action_changes"), i18n("changes"), 40) + entry({"admin", "uci", "revert"}, call("action_revert"), i18n("revert"), 30) + entry({"admin", "uci", "apply"}, call("action_apply"), i18n("apply"), 20) + entry({"admin", "uci", "saveapply"}, call("action_apply"), i18n("saveapply"), 10) end function convert_changes(changes) @@ -52,6 +53,7 @@ function action_changes() end function action_apply() + local path = luci.dispatcher.context.path local changes = luci.model.uci.changes() local output = "" @@ -62,9 +64,11 @@ function action_apply() -- Collect files to be applied and commit changes for r, tbl in pairs(changes) do if r then - luci.model.uci.load(r) - luci.model.uci.commit(r) - luci.model.uci.unload(r) + if path[#path] ~= "apply" then + luci.model.uci.load(r) + luci.model.uci.commit(r) + luci.model.uci.unload(r) + end if luci.config.uci_oncommit and luci.config.uci_oncommit[r] then run[luci.config.uci_oncommit[r]] = true end diff --git a/modules/admin-full/luasrc/view/admin_uci/changes.htm b/modules/admin-full/luasrc/view/admin_uci/changes.htm index 09d8d3e7e..ab66b78ef 100644 --- a/modules/admin-full/luasrc/view/admin_uci/changes.htm +++ b/modules/admin-full/luasrc/view/admin_uci/changes.htm @@ -20,6 +20,9 @@ $Id$
+
+ +
diff --git a/modules/admin-mini/luasrc/controller/mini/uci.lua b/modules/admin-mini/luasrc/controller/mini/uci.lua index eabc89540..b56a70287 100644 --- a/modules/admin-mini/luasrc/controller/mini/uci.lua +++ b/modules/admin-mini/luasrc/controller/mini/uci.lua @@ -18,9 +18,9 @@ function index() local i18n = luci.i18n.translate entry({"mini", "uci"}, nil, i18n("config")) - entry({"mini", "uci", "changes"}, call("action_changes"), i18n("changes")) - entry({"mini", "uci", "revert"}, call("action_revert"), i18n("revert")) - entry({"mini", "uci", "apply"}, call("action_apply"), i18n("apply")) + entry({"mini", "uci", "changes"}, call("action_changes"), i18n("changes"), 30) + entry({"mini", "uci", "revert"}, call("action_revert"), i18n("revert"), 20) + entry({"mini", "uci", "apply"}, call("action_apply"), i18n("saveapply"), 10) end function convert_changes(changes) diff --git a/themes/fledermaus/luasrc/view/themes/fledermaus/header.htm b/themes/fledermaus/luasrc/view/themes/fledermaus/header.htm index 5abe5d4ee..30aa57d86 100644 --- a/themes/fledermaus/luasrc/view/themes/fledermaus/header.htm +++ b/themes/fledermaus/luasrc/view/themes/fledermaus/header.htm @@ -146,15 +146,13 @@ end end %>
<%:config%> -
<% end %>
diff --git a/themes/openwrt.org/luasrc/view/themes/openwrt.org/header.htm b/themes/openwrt.org/luasrc/view/themes/openwrt.org/header.htm index 500a73bad..23b28a14c 100644 --- a/themes/openwrt.org/luasrc/view/themes/openwrt.org/header.htm +++ b/themes/openwrt.org/luasrc/view/themes/openwrt.org/header.htm @@ -174,10 +174,7 @@ end
<% if ucic > 0 then %> <%:unsavedchanges%>: <%=ucic%> - + <% submenu(category .. "/uci/", tree.nodes[category].nodes["uci"]) -%> <% else %> <%:changes%>: 0 <% end %> -- 2.11.0