libs/lmo: fix off-by-one in bounds check, null-terminate dest buffer in lmo_lookup()
authorJo-Philipp Wich <jow@openwrt.org>
Wed, 19 Aug 2009 22:10:24 +0000 (22:10 +0000)
committerJo-Philipp Wich <jow@openwrt.org>
Wed, 19 Aug 2009 22:10:24 +0000 (22:10 +0000)
libs/lmo/src/lmo_core.c

index ab2410f..55696af 100644 (file)
@@ -218,8 +218,9 @@ int lmo_lookup(lmo_archive_t *ar, const char *key, char *dest, int len)
        {
                if( entry->key_id == look_key )
                {
-                       copy_len = (len > entry->length) ? entry->length : len;
+                       copy_len = ((len - 1) > entry->length) ? entry->length : (len - 1);
                        memcpy(dest, &ar->mmap[entry->offset], copy_len);
+                       data[copy_len] = '\0';
 
                        break;
                }