modules/admin-full: utilize luci.model.network, add uptime in iface_status action

[project/luci.git] / modules / admin-full / luasrc / controller / admin / network.lua

diff --git a/modules/admin-full/luasrc/controller/admin/network.lua b/modules/admin-full/luasrc/controller/admin/network.lua
index f8b8ed4..ebe8af8 100644 (file)
--- a/modules/admin-full/luasrc/controller/admin/network.lua
+++ b/modules/admin-full/luasrc/controller/admin/network.lua
@@ -92,25 +92,38 @@ function index()
        )
 
        if nixio.fs.access("/etc/config/dhcp") then
-               page  = node("admin", "network", "dhcpleases")
+               page = node("admin", "network", "dhcpleases")
                page.target = cbi("admin_network/dhcpleases")
                page.title  = i18n("DHCP Leases")
                page.order  = 30
 
                page = entry({"admin", "network", "dhcplease_status"}, call("lease_status"), nil)
                page.leaf = true
-       end
 
-       page  = node("admin", "network", "hosts")
-       page.target = cbi("admin_network/hosts")
-       page.title  = i18n("Hostnames")
-       page.order  = 40
+               page = node("admin", "network", "hosts")
+               page.target = cbi("admin_network/hosts")
+               page.title  = i18n("Hostnames")
+               page.order  = 40
+       end
 
        page  = node("admin", "network", "routes")
        page.target = cbi("admin_network/routes")
        page.title  = i18n("Static Routes")
        page.order  = 50
 
+       page = node("admin", "network", "diagnostics")
+       page.target = template("admin_network/diagnostics")
+       page.title  = i18n("Diagnostics")
+       page.order  = 60
+
+       page = entry({"admin", "network", "diag_ping"}, call("diag_ping"), nil)
+       page.leaf = true
+
+       page = entry({"admin", "network", "diag_nslookup"}, call("diag_nslookup"), nil)
+       page.leaf = true
+
+       page = entry({"admin", "network", "diag_traceroute"}, call("diag_traceroute"), nil)
+       page.leaf = true
 end
 
 function wifi_join()
@@ -176,55 +189,47 @@ end
 
 function iface_status()
        local path = luci.dispatcher.context.requestpath
-       local x    = luci.model.uci.cursor_state()
+       local netm = require "luci.model.network".init()
        local rv   = { }
 
        local iface
        for iface in path[#path]:gmatch("[%w%.%-]+") do
-               local dev
-               if x:get("network", iface, "type") == "bridge" then
-                       dev = "br-" .. iface
-               else
-                       dev = x:get("network", iface, "device") or ""
-               end
-
-               if #dev == 0 or dev:match("^%d") or dev:match("%W") then
-                       dev = x:get("network", iface, "ifname") or ""
-                       dev = dev:match("%S+")
-               end
-
-               local info
-               local data = { id = iface }
-               for _, info in ipairs(nixio.getifaddrs()) do
-                       local name = info.name:match("[^:]+")
-                       if name == dev then
-                               if info.family == "packet" then
-                                       data.flags   = info.flags
-                                       data.stats   = info.data
-                                       data.macaddr = info.addr
-                                       data.ifname  = name
-                               elseif info.family == "inet" then
-                                       data.ipaddrs = data.ipaddrs or { }
-                                       data.ipaddrs[#data.ipaddrs+1] = {
-                                               addr      = info.addr,
-                                               broadaddr = info.broadaddr,
-                                               dstaddr   = info.dstaddr,
-                                               netmask   = info.netmask,
-                                               prefix    = info.prefix
-                                       }
-                               elseif info.family == "inet6" then
-                                       data.ip6addrs = data.ip6addrs or { }
-                                       data.ip6addrs[#data.ip6addrs+1] = {
-                                               addr    = info.addr,
-                                               netmask = info.netmask,
-                                               prefix  = info.prefix
-                                       }
+               local net = netm:get_network(iface)
+               if net then
+                       local info
+                       local dev  = net:ifname()
+                       local data = { id = iface, uptime = net:uptime() }
+                       for _, info in ipairs(nixio.getifaddrs()) do
+                               local name = info.name:match("[^:]+")
+                               if name == dev then
+                                       if info.family == "packet" then
+                                               data.flags   = info.flags
+                                               data.stats   = info.data
+                                               data.macaddr = info.addr
+                                               data.ifname  = name
+                                       elseif info.family == "inet" then
+                                               data.ipaddrs = data.ipaddrs or { }
+                                               data.ipaddrs[#data.ipaddrs+1] = {
+                                                       addr      = info.addr,
+                                                       broadaddr = info.broadaddr,
+                                                       dstaddr   = info.dstaddr,
+                                                       netmask   = info.netmask,
+                                                       prefix    = info.prefix
+                                               }
+                                       elseif info.family == "inet6" then
+                                               data.ip6addrs = data.ip6addrs or { }
+                                               data.ip6addrs[#data.ip6addrs+1] = {
+                                                       addr    = info.addr,
+                                                       netmask = info.netmask,
+                                                       prefix  = info.prefix
+                                               }
+                                       end
                                end
                        end
-               end
 
-               if next(data) then
-                       rv[#rv+1] = data
+                       if next(data) then
+                               rv[#rv+1] = data
+                       end
                end
        end
 
@@ -371,3 +376,40 @@ function lease_status()
        luci.http.prepare_content("application/json")
        luci.http.write_json(rv)
 end
+
+function diag_command(cmd)
+       local path = luci.dispatcher.context.requestpath
+       local addr = path[#path]
+
+       if addr and addr:match("^[a-zA-Z0-9%-%.:_]+$") then
+               luci.http.prepare_content("text/plain")
+
+               local util = io.popen(cmd % addr)
+               if util then
+                       while true do
+                               local ln = util:read("*l")
+                               if not ln then break end
+                               luci.http.write(ln)
+                               luci.http.write("\n")
+                       end
+
+                       util:close()
+               end
+
+               return
+       end
+
+       luci.http.status(500, "Bad address")
+end
+
+function diag_ping()
+       diag_command("ping -c 5 -W 1 %q 2>&1")
+end
+
+function diag_traceroute()
+       diag_command("traceroute -q 1 -w 1 -n %q 2>&1")
+end
+
+function diag_nslookup()
+       diag_command("nslookup %q 2>&1")
+end