applications/luci-firewall: minor tweaks on config pages

[project/luci.git] / applications / luci-firewall / luasrc / model / cbi / luci_fw / rrule.lua

diff --git a/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua b/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua
index 5769c1d..74617e0 100644 (file)
--- a/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua
+++ b/applications/luci-firewall/luasrc/model/cbi/luci_fw/rrule.lua
@@ -53,10 +53,6 @@ s.addremove = false
 s:tab("general", translate("General Settings"))
 s:tab("advanced", translate("Advanced Settings"))
 
-back = s:taboption("general", DummyValue, "_overview", translate("Overview"))
-back.value = ""
-back.titleref = luci.dispatcher.build_url("admin", "network", "firewall", "redirect")
-
 name = s:taboption("general", Value, "_name", translate("Name"))
 name.rmempty = true
 name.size = 10
@@ -66,7 +62,7 @@ src.nocreate = true
 src.default = "wan"
 src.template = "cbi/firewall_zonelist"
 
-proto = s:taboption("general", ListValue, "proto", translate("Protocol"))
+proto = s:taboption("general", Value, "proto", translate("Protocol"))
 proto.optional = true
 proto:value("tcpudp", "TCP+UDP")
 proto:value("tcp", "TCP")
@@ -93,6 +89,10 @@ toport = s:taboption("general", Value, "dest_port", translate("Internal port (op
                "the internal host"))
 toport.optional = true
 toport.placeholder = "0-65535"
+toport.datatype = "portrange"
+toport:depends("proto", "tcp")
+toport:depends("proto", "udp")
+toport:depends("proto", "tcpudp")
 
 target = s:taboption("advanced", ListValue, "target", translate("Redirection type"))
 target:value("DNAT")