From aa717ec3d830814781d2c9d89dbf80765ab32b44 Mon Sep 17 00:00:00 2001 From: blogic Date: Mon, 9 Mar 2015 14:06:50 +0000 Subject: [PATCH] ncm: Remove unnecessary proto_set_available commands Interface should not be set unavailable in all error cases, returning 1 is enough. Signed-off-by: Matti Laakso git-svn-id: svn://svn.openwrt.org/openwrt/trunk@44630 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- package/network/utils/comgt/files/ncm.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/package/network/utils/comgt/files/ncm.sh b/package/network/utils/comgt/files/ncm.sh index 2c2835fe39..4c3f161f98 100644 --- a/package/network/utils/comgt/files/ncm.sh +++ b/package/network/utils/comgt/files/ncm.sh @@ -41,7 +41,6 @@ proto_ncm_setup() { [ -n "$apn" ] || { echo "No APN specified" proto_notify_error "$interface" NO_APN - proto_set_available "$interface" 0 return 1 } @@ -69,7 +68,6 @@ proto_ncm_setup() { [ $? -ne 0 ] && { echo "Failed to get modem information" proto_notify_error "$interface" GETINFO_FAILED - proto_set_available "$interface" 0 return 1 } @@ -86,7 +84,6 @@ proto_ncm_setup() { eval COMMAND="$i" gcom -d "$device" -s /etc/gcom/runcommand.gcom || { echo "Failed to initialize modem" proto_notify_error "$interface" INITIALIZE_FAILED - proto_set_available "$interface" 0 return 1 } done @@ -105,7 +102,6 @@ proto_ncm_setup() { COMMAND="$setmode" gcom -d "$device" -s /etc/gcom/runcommand.gcom || { echo "Failed to set operating mode" proto_notify_error "$interface" SETMODE_FAILED - proto_set_available "$interface" 0 return 1 } json_select .. @@ -115,7 +111,6 @@ proto_ncm_setup() { eval COMMAND="$connect" gcom -d "$device" -s /etc/gcom/runcommand.gcom || { echo "Failed to connect" proto_notify_error "$interface" CONNECT_FAILED - proto_set_available "$interface" 0 return 1 } -- 2.11.0