From 1d05db0a1a5c71d99ec4baeebdc34340b0dc54a9 Mon Sep 17 00:00:00 2001 From: blogic Date: Thu, 10 Mar 2016 19:10:54 +0000 Subject: [PATCH] brcm63xx/lzma-loader: fix O32 ABI conformance MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit According to the calling convention of the o32 ABI the caller function must reserve stack space for $a0-$a3 registers in case the callee needs to save its arguments. The assembly code of the loader does not reserve stack space for these registers thus when the 'loader_main' function needs to save its arguments, those will be stored in the 'workspace' area instead of the stack. Because the workspace area is also used by other part of the code, the saved register values gets overwritten and this often leads to failed kernel boots. Fix the code to reserve stack space for the registers to avoid this error. Signed-off-by: Gabor Juhos [noltari: apply the fix for brcm63xx too] Signed-off-by: Álvaro Fernández Rojas git-svn-id: svn://svn.openwrt.org/openwrt/trunk@48979 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- target/linux/brcm63xx/image/lzma-loader/src/head.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/linux/brcm63xx/image/lzma-loader/src/head.S b/target/linux/brcm63xx/image/lzma-loader/src/head.S index 543996a0da..47a7c9bd63 100644 --- a/target/linux/brcm63xx/image/lzma-loader/src/head.S +++ b/target/linux/brcm63xx/image/lzma-loader/src/head.S @@ -109,6 +109,9 @@ __bss_check: /* Setup new "C" stack */ la sp, _stack + /* reserve stack space for a0-a3 registers */ + subu sp, 16 + /* jump to the decompressor routine */ la t0, loader_main jr t0 -- 2.11.0