From: rmilecki <rmilecki@3c298f89-4303-0410-b956-a3cf2f4a3e73>
Date: Wed, 22 Apr 2015 19:07:19 +0000 (+0000)
Subject: nvram: refuse to open NVRAM for writing if it's too big to be handled
X-Git-Url: https://git.archive.openwrt.org/?p=openwrt.git;a=commitdiff_plain;h=51eeb48331ef63969a0ae2f5e3b6f733563f46da;ds=sidebyside

nvram: refuse to open NVRAM for writing if it's too big to be handled

Otherwise writing anything will result in loosing data.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@45565 3c298f89-4303-0410-b956-a3cf2f4a3e73
---

diff --git a/package/utils/nvram/src/nvram.c b/package/utils/nvram/src/nvram.c
index f2c79ff7ba..0e1c726837 100644
--- a/package/utils/nvram/src/nvram.c
+++ b/package/utils/nvram/src/nvram.c
@@ -389,8 +389,8 @@ nvram_handle_t * nvram_open(const char *file, int rdonly)
 
 				header = nvram_header(h);
 
-				if( header->magic == NVRAM_MAGIC )
-				{
+				if (header->magic == NVRAM_MAGIC &&
+				    (rdonly || header->len < NVRAM_SPACE)) {
 					_nvram_rehash(h);
 					free(mtd);
 					return h;