package/mac80211/files/lib/wifi/mac80211.sh

   1 #!/bin/sh
   2 append DRIVERS "mac80211"
   3
   4 mac80211_hostapd_setup_base() {
   5         local phy="$1"
   6         local ifname="$2"
   7
   8         cfgfile="/var/run/hostapd-$phy.conf"
   9         macfile="/var/run/hostapd-$phy.maclist"
  10         [ -e "$macfile" ] && rm -f "$macfile"
  11
  12         config_get device "$vif" device
  13         config_get country "$device" country
  14         config_get hwmode "$device" hwmode
  15         config_get channel "$device" channel
  16         config_get beacon_int "$device" beacon_int
  17         config_get basic_rate_list "$device" basic_rate
  18         config_get_bool noscan "$device" noscan
  19
  20         hostapd_set_log_options base_cfg "$device"
  21
  22         [ -n "$channel" -a -z "$hwmode" ] && wifi_fixup_hwmode "$device"
  23
  24         [ "$channel" = auto ] && {
  25                 channel=$(iw phy "$phy" info | \
  26                         sed -ne '/MHz/ { /disabled\|passive\|radar/d; s/.*\[//; s/\].*//; p; q }')
  27                 config_set "$device" channel "$channel"
  28         }
  29
  30         [ -n "$hwmode" ] && {
  31                 config_get hwmode_11n "$device" hwmode_11n
  32                 [ -n "$hwmode_11n" ] && {
  33                         hwmode="$hwmode_11n"
  34                         append base_cfg "ieee80211n=1" "$N"
  35                         config_get htmode "$device" htmode
  36                         config_get ht_capab_list "$device" ht_capab
  37                         case "$htmode" in
  38                                 HT20|HT40+|HT40-) ht_capab="[$htmode]";;
  39                                 *)ht_capab=;;
  40                         esac
  41                         for cap in $ht_capab_list; do
  42                                 ht_capab="$ht_capab[$cap]"
  43                         done
  44                         [ -n "$ht_capab" ] && append base_cfg "ht_capab=$ht_capab" "$N"
  45                 }
  46         }
  47
  48         local country_ie=0
  49         [ -n "$country" ] && country_ie=1
  50         config_get_bool country_ie "$device" country_ie "$country_ie"
  51         [ "$country_ie" -gt 0 ] && append base_cfg "ieee80211d=1" "$N"
  52
  53         config_get macfilter "$vif" macfilter
  54         case "$macfilter" in
  55                 allow)
  56                         append base_cfg "macaddr_acl=1" "$N"
  57                         append base_cfg "accept_mac_file=$macfile" "$N"
  58                         ;;
  59                 deny)
  60                         append base_cfg "macaddr_acl=0" "$N"
  61                         append base_cfg "deny_mac_file=$macfile" "$N"
  62                         ;;
  63         esac
  64         config_get maclist "$vif" maclist
  65         [ -n "$maclist" ] && {
  66                 for mac in $maclist; do
  67                         echo "$mac" >> $macfile
  68                 done
  69         }
  70
  71         local br brval brstr
  72         [ -n "$basic_rate_list" ] && {
  73                 for br in $basic_rate_list; do
  74                         brval="$(($br / 100))"
  75                         [ -n "$brstr" ] && brstr="$brstr "
  76                         brstr="$brstr$brval"
  77                 done
  78         }
  79
  80         cat >> "$cfgfile" <<EOF
  81 ctrl_interface=/var/run/hostapd-$phy
  82 driver=nl80211
  83 wmm_ac_bk_cwmin=4
  84 wmm_ac_bk_cwmax=10
  85 wmm_ac_bk_aifs=7
  86 wmm_ac_bk_txop_limit=0
  87 wmm_ac_bk_acm=0
  88 wmm_ac_be_aifs=3
  89 wmm_ac_be_cwmin=4
  90 wmm_ac_be_cwmax=10
  91 wmm_ac_be_txop_limit=0
  92 wmm_ac_be_acm=0
  93 wmm_ac_vi_aifs=2
  94 wmm_ac_vi_cwmin=3
  95 wmm_ac_vi_cwmax=4
  96 wmm_ac_vi_txop_limit=94
  97 wmm_ac_vi_acm=0
  98 wmm_ac_vo_aifs=2
  99 wmm_ac_vo_cwmin=2
 100 wmm_ac_vo_cwmax=3
 101 wmm_ac_vo_txop_limit=47
 102 wmm_ac_vo_acm=0
 103 tx_queue_data3_aifs=7
 104 tx_queue_data3_cwmin=15
 105 tx_queue_data3_cwmax=1023
 106 tx_queue_data3_burst=0
 107 tx_queue_data2_aifs=3
 108 tx_queue_data2_cwmin=15
 109 tx_queue_data2_cwmax=63
 110 tx_queue_data2_burst=0
 111 tx_queue_data1_aifs=1
 112 tx_queue_data1_cwmin=7
 113 tx_queue_data1_cwmax=15
 114 tx_queue_data1_burst=3.0
 115 tx_queue_data0_aifs=1
 116 tx_queue_data0_cwmin=3
 117 tx_queue_data0_cwmax=7
 118 tx_queue_data0_burst=1.5
 119 ${hwmode:+hw_mode=$hwmode}
 120 ${channel:+channel=$channel}
 121 ${beacon_int:+beacon_int=$beacon_int}
 122 ${country:+country_code=$country}
 123 ${noscan:+noscan=$noscan}
 124 ${brstr:+basic_rates=$brstr}
 125 $base_cfg
 126
 127 EOF
 128 }
 129
 130 mac80211_hostapd_setup_bss() {
 131         local phy="$1"
 132         local vif="$2"
 133
 134         hostapd_cfg=
 135         cfgfile="/var/run/hostapd-$phy.conf"
 136         config_get ifname "$vif" ifname
 137
 138         if [ -f "$cfgfile" ]; then
 139                 append hostapd_cfg "bss=$ifname" "$N"
 140         else
 141                 mac80211_hostapd_setup_base "$phy" "$ifname"
 142                 append hostapd_cfg "interface=$ifname" "$N"
 143         fi
 144
 145         local net_cfg bridge
 146         net_cfg="$(find_net_config "$vif")"
 147         [ -z "$net_cfg" ] || bridge="$(bridge_interface "$net_cfg")"
 148         config_set "$vif" bridge "$bridge"
 149
 150         hostapd_set_bss_options hostapd_cfg "$vif"
 151
 152         config_get_bool wds "$vif" wds 0
 153         [ "$wds" -gt 0 ] && append hostapd_cfg "wds_sta=1" "$N"
 154
 155         local macaddr hidden maxassoc wmm
 156         config_get macaddr "$vif" macaddr
 157         config_get maxassoc "$vif" maxassoc
 158         config_get dtim_period "$vif" dtim_period
 159         config_get max_listen_int "$vif" max_listen_int
 160         config_get_bool hidden "$vif" hidden 0
 161         config_get_bool wmm "$vif" wmm 1
 162         cat >> /var/run/hostapd-$phy.conf <<EOF
 163 $hostapd_cfg
 164 wmm_enabled=$wmm
 165 bssid=$macaddr
 166 ignore_broadcast_ssid=$hidden
 167 ${dtim_period:+dtim_period=$dtim_period}
 168 ${max_listen_int:+max_listen_interval=$max_listen_int}
 169 ${maxassoc:+max_num_sta=$maxassoc}
 170 EOF
 171 }
 172
 173 mac80211_start_vif() {
 174         local vif="$1"
 175         local ifname="$2"
 176
 177         local net_cfg
 178         net_cfg="$(find_net_config "$vif")"
 179         [ -z "$net_cfg" ] || start_net "$ifname" "$net_cfg"
 180
 181         set_wifi_up "$vif" "$ifname"
 182 }
 183
 184 find_mac80211_phy() {
 185         local device="$1"
 186
 187         local macaddr="$(config_get "$device" macaddr | tr 'A-Z' 'a-z')"
 188         config_get phy "$device" phy
 189         [ -z "$phy" -a -n "$macaddr" ] && {
 190                 for phy in $(ls /sys/class/ieee80211 2>/dev/null); do
 191                         [ "$macaddr" = "$(cat /sys/class/ieee80211/${phy}/macaddress)" ] || continue
 192                         config_set "$device" phy "$phy"
 193                         break
 194                 done
 195                 config_get phy "$device" phy
 196         }
 197         [ -n "$phy" -a -d "/sys/class/ieee80211/$phy" ] || {
 198                 echo "PHY for wifi device $1 not found"
 199                 return 1
 200         }
 201         [ -z "$macaddr" ] && {
 202                 config_set "$device" macaddr "$(cat /sys/class/ieee80211/${phy}/macaddress)"
 203         }
 204         return 0
 205 }
 206
 207 scan_mac80211() {
 208         local device="$1"
 209         local adhoc sta ap monitor mesh disabled
 210
 211         config_get vifs "$device" vifs
 212         for vif in $vifs; do
 213                 config_get_bool disabled "$vif" disabled 0
 214                 [ $disabled = 0 ] || continue
 215
 216                 config_get mode "$vif" mode
 217                 case "$mode" in
 218                         adhoc|sta|ap|monitor|mesh)
 219                                 append $mode "$vif"
 220                         ;;
 221                         *) echo "$device($vif): Invalid mode, ignored."; continue;;
 222                 esac
 223         done
 224
 225         config_set "$device" vifs "${ap:+$ap }${adhoc:+$adhoc }${sta:+$sta }${monitor:+$monitor }${mesh:+$mesh}"
 226 }
 227
 228 list_phy_interfaces() {
 229         local phy="$1"
 230         if [ -d "/sys/class/ieee80211/${phy}/device/net" ]; then
 231                 ls "/sys/class/ieee80211/${phy}/device/net" 2>/dev/null;
 232         else
 233                 ls "/sys/class/ieee80211/${phy}/device" 2>/dev/null | grep net: | sed -e 's,net:,,g'
 234         fi
 235 }
 236
 237 disable_mac80211() (
 238         local device="$1"
 239
 240         find_mac80211_phy "$device" || return 0
 241         config_get phy "$device" phy
 242
 243         set_wifi_down "$device"
 244         # kill all running hostapd and wpa_supplicant processes that
 245         # are running on atheros/mac80211 vifs
 246         for pid in `pidof hostapd`; do
 247                 grep -E "$phy" /proc/$pid/cmdline >/dev/null && \
 248                         kill $pid
 249         done
 250
 251         include /lib/network
 252         for wdev in $(list_phy_interfaces "$phy"); do
 253                 [ -f "/var/run/$wdev.pid" ] && kill $(cat /var/run/$wdev.pid) >&/dev/null 2>&1
 254                 for pid in `pidof wpa_supplicant`; do
 255                         grep "$wdev" /proc/$pid/cmdline >/dev/null && \
 256                                 kill $pid
 257                 done
 258                 ifconfig "$wdev" down 2>/dev/null
 259                 unbridge "$dev"
 260                 iw dev "$wdev" del
 261         done
 262
 263         return 0
 264 )
 265
 266 get_freq() {
 267         local phy="$1"
 268         local chan="$2"
 269         iw "$phy" info | grep -E -m1 "(\* ${chan:-....} MHz${chan:+|\\[$chan\\]})" | grep MHz | awk '{print $2}'
 270 }
 271
 272 mac80211_generate_mac() {
 273         local off="$1"
 274         local mac="$2"
 275         local oIFS="$IFS"; IFS=":"; set -- $mac; IFS="$oIFS"
 276
 277         local b2mask=0x00
 278         [ $off -gt 0 ] && b2mask=0x02
 279
 280         printf "%02x:%s:%s:%s:%02x:%02x" \
 281                 $(( 0x$1 | $b2mask )) $2 $3 $4 \
 282                 $(( (0x$5 + ($off / 0x100)) % 0x100 )) \
 283                 $(( (0x$6 + $off) % 0x100 ))
 284 }
 285
 286 enable_mac80211() {
 287         local device="$1"
 288         config_get channel "$device" channel
 289         config_get vifs "$device" vifs
 290         config_get txpower "$device" txpower
 291         config_get country "$device" country
 292         config_get distance "$device" distance
 293         config_get txantenna "$device" txantenna all
 294         config_get rxantenna "$device" rxantenna all
 295         config_get frag "$device" frag
 296         config_get rts "$device" rts
 297         find_mac80211_phy "$device" || return 0
 298         config_get phy "$device" phy
 299         local i=0
 300         local macidx=0
 301         local apidx=0
 302         fixed=""
 303         local hostapd_ctrl=""
 304
 305         [ -n "$country" ] && {
 306                 iw reg get | grep -q "^country $country:" || {
 307                         iw reg set "$country"
 308                         sleep 1
 309                 }
 310         }
 311
 312         config_get ath9k_chanbw "$device" ath9k_chanbw
 313         [ -n "$ath9k_chanbw" -a -d /sys/kernel/debug/ieee80211/$phy/ath9k ] && echo "$ath9k_chanbw" > /sys/kernel/debug/ieee80211/$phy/ath9k/chanbw
 314
 315         [ -n "$country" ] && iw reg set "$country"
 316         [ "$channel" = "auto" -o "$channel" = "0" ] || {
 317                 fixed=1
 318         }
 319
 320         iw phy "$phy" set antenna $txantenna $rxantenna >/dev/null 2>&1
 321
 322         [ -n "$distance" ] && iw phy "$phy" set distance "$distance"
 323         [ -n "$frag" ] && iw phy "$phy" set frag "${frag%%.*}"
 324         [ -n "$rts" ] && iw phy "$phy" set rts "${rts%%.*}"
 325
 326         export channel fixed
 327         # convert channel to frequency
 328         local freq="$(get_freq "$phy" "${fixed:+$channel}")"
 329
 330         wifi_fixup_hwmode "$device" "g"
 331         for vif in $vifs; do
 332                 config_get ifname "$vif" ifname
 333                 [ -n "$ifname" ] || {
 334                         [ $i -gt 0 ] && ifname="wlan${phy#phy}-$i" || ifname="wlan${phy#phy}"
 335                 }
 336                 config_set "$vif" ifname "$ifname"
 337
 338                 config_get mode "$vif" mode
 339                 config_get ssid "$vif" ssid
 340
 341                 # It is far easier to delete and create the desired interface
 342                 case "$mode" in
 343                         adhoc)
 344                                 iw phy "$phy" interface add "$ifname" type adhoc
 345                         ;;
 346                         ap)
 347                                 # Hostapd will handle recreating the interface and
 348                                 # it's accompanying monitor
 349                                 apidx="$(($apidx + 1))"
 350                                 [ "$apidx" -gt 1 ] || iw phy "$phy" interface add "$ifname" type managed
 351                         ;;
 352                         mesh)
 353                                 config_get mesh_id "$vif" mesh_id
 354                                 iw phy "$phy" interface add "$ifname" type mp mesh_id "$mesh_id"
 355                         ;;
 356                         monitor)
 357                                 iw phy "$phy" interface add "$ifname" type monitor
 358                         ;;
 359                         sta)
 360                                 local wdsflag
 361                                 config_get_bool wds "$vif" wds 0
 362                                 [ "$wds" -gt 0 ] && wdsflag="4addr on"
 363                                 iw phy "$phy" interface add "$ifname" type managed $wdsflag
 364                                 config_get_bool powersave "$vif" powersave 0
 365                                 [ "$powersave" -gt 0 ] && powersave="on" || powersave="off"
 366                                 iw "$ifname" set power_save "$powersave"
 367                         ;;
 368                 esac
 369
 370                 # All interfaces must have unique mac addresses
 371                 # which can either be explicitly set in the device
 372                 # section, or automatically generated
 373                 config_get macaddr "$device" macaddr
 374                 config_get vif_mac "$vif" macaddr
 375                 [ -n "$vif_mac" ] || {
 376                         vif_mac="$(mac80211_generate_mac $macidx $macaddr)"
 377                         macidx="$(($macidx + 1))"
 378                 }
 379                 [ "$mode" = "ap" ] || ifconfig "$ifname" hw ether "$vif_mac"
 380                 config_set "$vif" macaddr "$vif_mac"
 381
 382                 # !! ap !!
 383                 #
 384                 # ALL ap functionality will be passed to hostapd
 385                 #
 386                 # !! station !!
 387                 #
 388                 # ALL station functionality will be passed to wpa_supplicant
 389                 #
 390                 if [ ! "$mode" = "ap" ]; then
 391                         # We attempt to set the channel for all interfaces, although
 392                         # mac80211 may not support it or the driver might not yet
 393                         # for ap mode this is handled by hostapd
 394                         [ -n "$fixed" -a -n "$channel" ] && iw dev "$ifname" set channel "$channel"
 395                 fi
 396
 397                 i=$(($i + 1))
 398         done
 399
 400         local start_hostapd=
 401         rm -f /var/run/hostapd-$phy.conf
 402         for vif in $vifs; do
 403                 config_get mode "$vif" mode
 404                 [ "$mode" = "ap" ] || continue
 405                 mac80211_hostapd_setup_bss "$phy" "$vif"
 406                 start_hostapd=1
 407         done
 408
 409         [ -n "$start_hostapd" ] && {
 410                 hostapd -P /var/run/wifi-$phy.pid -B /var/run/hostapd-$phy.conf || {
 411                         echo "Failed to start hostapd for $phy"
 412                         return
 413                 }
 414                 sleep 2
 415
 416                 for vif in $vifs; do
 417                         config_get mode "$vif" mode
 418                         config_get ifname "$vif" ifname
 419                         [ "$mode" = "ap" ] || continue
 420                         hostapd_ctrl="${hostapd_ctrl:-/var/run/hostapd-$phy/$ifname}"
 421                         mac80211_start_vif "$vif" "$ifname"
 422                 done
 423         }
 424
 425         for vif in $vifs; do
 426                 config_get mode "$vif" mode
 427                 config_get ifname "$vif" ifname
 428                 [ ! "$mode" = "ap" ] || continue
 429                 ifconfig "$ifname" up
 430
 431                 config_get vif_txpower "$vif" txpower
 432                 # use vif_txpower (from wifi-iface) to override txpower (from
 433                 # wifi-device) if the latter doesn't exist
 434                 txpower="${txpower:-$vif_txpower}"
 435                 [ -z "$txpower" ] || iw dev "$ifname" set txpower fixed "${txpower%%.*}00"
 436
 437                 if [ ! "$mode" = "ap" ]; then
 438                         ifconfig "$ifname" up
 439                         case "$mode" in
 440                                 adhoc)
 441                                         config_get bssid "$vif" bssid
 442                                         config_get ssid "$vif" ssid
 443                                         config_get beacon_int "$device" beacon_int
 444                                         config_get basic_rate_list "$device" basic_rate
 445                                         config_get encryption "$vif" encryption
 446                                         config_get key "$vif" key 1
 447                                         config_get mcast_rate "$vif" mcast_rate
 448
 449                                         local keyspec=""
 450                                         [ "$encryption" == "wep" ] && {
 451                                                 case "$key" in
 452                                                         [1234])
 453                                                                 local idx
 454                                                                 for idx in 1 2 3 4; do
 455                                                                         local ikey
 456                                                                         config_get ikey "$vif" "key$idx"
 457
 458                                                                         [ -n "$ikey" ] && {
 459                                                                                 ikey="$(($idx - 1)):$(prepare_key_wep "$ikey")"
 460                                                                                 [ $idx -eq $key ] && ikey="d:$ikey"
 461                                                                                 append keyspec "$ikey"
 462                                                                         }
 463                                                                 done
 464                                                         ;;
 465                                                         *) append keyspec "d:0:$(prepare_key_wep "$key")" ;;
 466                                                 esac
 467                                         }
 468
 469                                         local br brval brsub brstr
 470                                         [ -n "$basic_rate_list" ] && {
 471                                                 for br in $basic_rate_list; do
 472                                                         brval="$(($br / 1000))"
 473                                                         brsub="$((($br / 100) % 10))"
 474                                                         [ "$brsub" -gt 0 ] && brval="$brval.$brsub"
 475                                                         [ -n "$brstr" ] && brstr="$brstr,"
 476                                                         brstr="$brstr$brval"
 477                                                 done
 478                                         }
 479
 480                                         local mcval=""
 481                                         [ -n "$mcast_rate" ] && {
 482                                                 mcval="$(($mcast_rate / 1000))"
 483                                                 mcsub="$(( ($mcast_rate / 100) % 10 ))"
 484                                                 [ "$mcsub" -gt 0 ] && mcval="$mcval.$mcsub"
 485                                         }
 486
 487                                         config_get htmode "$device" htmode
 488                                         case "$htmode" in
 489                                                 HT20|HT40+|HT40-) ;;
 490                                                 *) htmode= ;;
 491                                         esac
 492
 493                                         iw dev "$ifname" ibss join "$ssid" $freq $htmode \
 494                                                 ${fixed:+fixed-freq} $bssid \
 495                                                 ${beacon_int:+beacon-interval $beacon_int} \
 496                                                 ${brstr:+basic-rates $brstr} \
 497                                                 ${mcval:+mcast-rate $mcval} \
 498                                                 ${keyspec:+keys $keyspec}
 499                                 ;;
 500                                 sta)
 501                                         if eval "type wpa_supplicant_setup_vif" 2>/dev/null >/dev/null; then
 502                                                 wpa_supplicant_setup_vif "$vif" nl80211 "${hostapd_ctrl:+-H $hostapd_ctrl}" || {
 503                                                         echo "enable_mac80211($device): Failed to set up wpa_supplicant for interface $ifname" >&2
 504                                                         # make sure this wifi interface won't accidentally stay open without encryption
 505                                                         ifconfig "$ifname" down
 506                                                         continue
 507                                                 }
 508                                         fi
 509                                 ;;
 510                         esac
 511                         mac80211_start_vif "$vif" "$ifname"
 512                 fi
 513         done
 514
 515 }
 516
 517
 518 check_mac80211_device() {
 519         config_get phy "$1" phy
 520         [ -z "$phy" ] && {
 521                 find_mac80211_phy "$1" >/dev/null || return 0
 522                 config_get phy "$1" phy
 523         }
 524         [ "$phy" = "$dev" ] && found=1
 525 }
 526
 527 detect_mac80211() {
 528         devidx=0
 529         config_load wireless
 530         while :; do
 531                 config_get type "radio$devidx" type
 532                 [ -n "$type" ] || break
 533                 devidx=$(($devidx + 1))
 534         done
 535         for dev in $(ls /sys/class/ieee80211); do
 536                 found=0
 537                 config_foreach check_mac80211_device wifi-device
 538                 [ "$found" -gt 0 ] && continue
 539
 540                 mode_11n=""
 541                 mode_band="g"
 542                 channel="11"
 543                 ht_cap=0
 544                 for cap in $(iw phy "$dev" info | grep 'Capabilities:' | cut -d: -f2); do
 545                         ht_cap="$(($ht_cap | $cap))"
 546                 done
 547                 ht_capab="";
 548                 [ "$ht_cap" -gt 0 ] && {
 549                         mode_11n="n"
 550                         append ht_capab "       option htmode   HT20" "$N"
 551
 552                         list="  list ht_capab"
 553                         [ "$(($ht_cap & 1))" -eq 1 ] && append ht_capab "$list  LDPC" "$N"
 554                         [ "$(($ht_cap & 16))" -eq 16 ] && append ht_capab "$list        GF" "$N"
 555                         [ "$(($ht_cap & 32))" -eq 32 ] && append ht_capab "$list        SHORT-GI-20" "$N"
 556                         [ "$(($ht_cap & 64))" -eq 64 ] && append ht_capab "$list        SHORT-GI-40" "$N"
 557                         [ "$(($ht_cap & 128))" -eq 128 ] && append ht_capab "$list      TX-STBC" "$N"
 558                         [ "$(($ht_cap & 768))" -eq 256 ] && append ht_capab "$list      RX-STBC1" "$N"
 559                         [ "$(($ht_cap & 768))" -eq 512 ] && append ht_capab "$list      RX-STBC12" "$N"
 560                         [ "$(($ht_cap & 768))" -eq 768 ] && append ht_capab "$list      RX-STBC123" "$N"
 561                         [ "$(($ht_cap & 4096))" -eq 4096 ] && append ht_capab "$list    DSSS_CCK-40" "$N"
 562                 }
 563                 iw phy "$dev" info | grep -q '2412 MHz' || { mode_band="a"; channel="36"; }
 564
 565                 cat <<EOF
 566 config wifi-device  radio$devidx
 567         option type     mac80211
 568         option channel  ${channel}
 569         option macaddr  $(cat /sys/class/ieee80211/${dev}/macaddress)
 570         option hwmode   11${mode_11n}${mode_band}
 571 $ht_capab
 572         # REMOVE THIS LINE TO ENABLE WIFI:
 573         option disabled 1
 574
 575 config wifi-iface
 576         option device   radio$devidx
 577         option network  lan
 578         option mode     ap
 579         option ssid     OpenWrt
 580         option encryption none
 581
 582 EOF
 583         devidx=$(($devidx + 1))
 584         done
 585 }
 586