X-Git-Url: https://git.archive.openwrt.org/?a=blobdiff_plain;f=libs%2Fweb%2Fluasrc%2Fsauth.lua;h=8182679ce78d2a7356990e4cb2ad7ed362879c5d;hb=f83bb9996b7bd36e8f032e389ad4eb4a3bfe590d;hp=724e22d201a40dddceb6401482f5bcb5c5c0578b;hpb=289b8fc1b6b41829c6077893f9dd1d7181551332;p=project%2Fluci.git

diff --git a/libs/web/luasrc/sauth.lua b/libs/web/luasrc/sauth.lua
index 724e22d20..8182679ce 100644
--- a/libs/web/luasrc/sauth.lua
+++ b/libs/web/luasrc/sauth.lua
@@ -12,16 +12,19 @@ You may obtain a copy of the License at
 $Id$
 
 ]]--
+
+--- LuCI session library.
 module("luci.sauth", package.seeall)
 require("luci.fs")
+require("luci.util")
 require("luci.config")
 
 
 luci.config.sauth = luci.config.sauth or {}
 sessionpath = luci.config.sauth.sessionpath
-sessiontime = luci.config.sauth.sessiontime
-
+sessiontime = tonumber(luci.config.sauth.sessiontime)
 
+--- Manually clean up expired sessions.
 function clean()
 	local now   = os.time()
 	local files = luci.fs.dir(sessionpath)
@@ -30,7 +33,7 @@ function clean()
 		return nil
 	end
 	
-	for i, file in files do
+	for i, file in pairs(files) do
 		local fname = sessionpath .. "/" .. file
 		local stat = luci.fs.stat(fname)
 		if stat and stat.type == "regular" and stat.atime + sessiontime < now then
@@ -39,18 +42,38 @@ function clean()
 	end
 end
 
+--- Prepare session storage by creating the session directory.
 function prepare()
 	luci.fs.mkdir(sessionpath)
-	luci.fs.chmod(sessionpath, "a-rwx,u+rw")
+	if not luci.fs.chmod(sessionpath, "a-rwx,u+rwx") then
+		error("Security Exception: Session path is not sane!")
+	end
 end
 
+--- Read a session and return its content.
+-- @param id	Session identifier
+-- @return		Session data
 function read(id)
-	cleansessions()
+	if not id or not sane() then
+		return
+	end
+	clean()
 	return luci.fs.readfile(sessionpath .. "/" .. id)
 end
 
+
+--- Check whether Session environment is sane.
+-- @return Boolean status
+function sane()
+	return luci.fs.stat(sessionpath, "mode") == "rwx------"
+end
+
+
+--- Write session data to a session file.
+-- @param id	Session identifier
+-- @param data	Session data
 function write(id, data)
-	if not luci.fs.stat(sessionpath) then
+	if not sane() then
 		prepare()
 	end
 	luci.fs.writefile(sessionpath .. "/" .. id, data)