From: Jo-Philipp Wich <jow@openwrt.org>
Date: Tue, 12 Oct 2010 23:08:54 +0000 (+0000)
Subject: libs/web: rework cbi field validation, let validators return custom error messages... 
X-Git-Tag: 0.10.0~619
X-Git-Url: http://git.archive.openwrt.org/?a=commitdiff_plain;h=17575b4d75cd9fede5ef0f3bfc7f9244fdb2ac06;p=project%2Fluci.git

libs/web: rework cbi field validation, let validators return custom error messages, properly handle errors in multiple sections
---

diff --git a/libs/web/luasrc/cbi.lua b/libs/web/luasrc/cbi.lua
index 8dd16b181..993b422f6 100644
--- a/libs/web/luasrc/cbi.lua
+++ b/libs/web/luasrc/cbi.lua
@@ -1253,18 +1253,20 @@ function AbstractValue.parse(self, section, novld)
 	end
 
 	if fvalue and #fvalue > 0 then -- If we have a form value, write it to UCI
-		fvalue = self:transform(self:validate(fvalue, section))
+		local val_err
+		fvalue, val_err = self:validate(fvalue, section)
+		fvalue = self:transform(fvalue)
+
 		if not fvalue and not novld then
-			if self.error then
-				self.error[section] = "invalid"
-			else
-				self.error = { [section] = "invalid" }
-			end
-			if self.section.error then
-				table.insert(self.section.error[section], "invalid")
-			else
-				self.section.error = {[section] = {"invalid"}}
-			end
+			val_err = val_err or "invalid"
+
+			self.error = self.error or { }
+			self.error[section] = val_err
+
+			self.section.error = self.section.error or { }
+			self.section.error[section] = self.section.error[section] or { }
+			table.insert(self.section.error[section], val_err)
+
 			self.map.save = false
 		end
 		if fvalue and not (fvalue == cvalue) then