We currently only call setgid() with user's primary group id for service
instance processes. In the case of a user belong to multiple groups,
it's natural to also explicitly initialize their supplementary group ids
Fixes FS#988
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/stat.h>
#include <net/if.h>
#include <unistd.h>
#include <stdint.h>
#include <net/if.h>
#include <unistd.h>
#include <stdint.h>
+ if (in->user && in->gid && initgroups(in->user, in->gid)) {
+ ERROR("failed to initgroups() for user %s: %m\n", in->user);
+ exit(127);
+ }
if (in->gid && setgid(in->gid)) {
ERROR("failed to set group id %d: %m\n", in->gid);
exit(127);
if (in->gid && setgid(in->gid)) {
ERROR("failed to set group id %d: %m\n", in->gid);
exit(127);
if (in->nice != in_new->nice)
return true;
if (in->nice != in_new->nice)
return true;
+ if (string_changed(in->user, in_new->user))
+ return true;
+
if (in->uid != in_new->uid)
return true;
if (in->uid != in_new->uid)
return true;
}
if (tb[INSTANCE_ATTR_USER]) {
}
if (tb[INSTANCE_ATTR_USER]) {
- struct passwd *p = getpwnam(blobmsg_get_string(tb[INSTANCE_ATTR_USER]));
+ const char *user = blobmsg_get_string(tb[INSTANCE_ATTR_USER]);
+ struct passwd *p = getpwnam(user);
+ in->user = strdup(user);
in->uid = p->pw_uid;
in->gid = p->pw_gid;
}
in->uid = p->pw_uid;
in->gid = p->pw_gid;
}
watch_del(in);
instance_config_cleanup(in);
free(in->config);
watch_del(in);
instance_config_cleanup(in);
free(in->config);