static struct blob_attr *attrbuf[UBUS_ATTR_MAX];
-typedef int (*ubus_cmd_cb)(struct ubus_client *cl, struct ubus_msg_buf *ub);
+typedef int (*ubus_cmd_cb)(struct ubus_client *cl, struct ubus_msg_buf *ub, struct blob_attr **attr);
static const struct blob_attr_info ubus_policy[UBUS_ATTR_MAX] = {
[UBUS_ATTR_SIGNATURE] = { .type = BLOB_ATTR_NESTED },
[UBUS_ATTR_OBJTYPE] = { .type = BLOB_ATTR_INT32 },
[UBUS_ATTR_OBJPATH] = { .type = BLOB_ATTR_STRING },
+ [UBUS_ATTR_OBJID] = { .type = BLOB_ATTR_INT32 },
+ [UBUS_ATTR_STATUS] = { .type = BLOB_ATTR_INT32 },
};
struct blob_attr **ubus_parse_msg(struct blob_attr *msg)
return false;
ubus_msg_init(ub, UBUS_MSG_HELLO, 0, cl->id.id);
- ubus_msg_send(cl, ub);
+ ubus_msg_send(cl, ub, true);
return true;
}
-static int ubusd_send_pong(struct ubus_client *cl, struct ubus_msg_buf *ub)
+static int ubusd_send_pong(struct ubus_client *cl, struct ubus_msg_buf *ub, struct blob_attr **attr)
{
ub->hdr.type = UBUS_MSG_DATA;
- ubus_msg_send(cl, ubus_msg_ref(ub));
+ ubus_msg_send(cl, ub, false);
return 0;
}
-static int ubusd_handle_publish(struct ubus_client *cl, struct ubus_msg_buf *ub)
+static int ubusd_handle_publish(struct ubus_client *cl, struct ubus_msg_buf *ub, struct blob_attr **attr)
{
struct ubus_object *obj;
- struct blob_attr **attr;
- attr = ubus_parse_msg(ub->data);
obj = ubusd_create_object(cl, attr);
if (!obj)
return UBUS_STATUS_INVALID_ARGUMENT;
if (!ub)
return UBUS_STATUS_NO_DATA;
- ubus_msg_send(cl, ub);
+ ubus_msg_send(cl, ub, true);
return 0;
}
if (obj->path.key)
blob_put_string(&b, UBUS_ATTR_OBJPATH, obj->path.key);
blob_put_int32(&b, UBUS_ATTR_OBJID, obj->id.id);
+ blob_put_int32(&b, UBUS_ATTR_OBJTYPE, obj->type->id.id);
s = blob_nest_start(&b, UBUS_ATTR_SIGNATURE);
list_for_each_entry(m, &obj->type->methods, list)
if (!ub)
return;
- ubus_msg_send(cl, ub);
+ ubus_msg_send(cl, ub, true);
}
-static int ubusd_handle_lookup(struct ubus_client *cl, struct ubus_msg_buf *ub)
+static int ubusd_handle_lookup(struct ubus_client *cl, struct ubus_msg_buf *ub, struct blob_attr **attr)
{
struct ubus_object *obj;
- struct blob_attr **attr;
char *objpath;
bool wildcard = false;
bool found = false;
int len;
- attr = ubus_parse_msg(ub->data);
if (!attr[UBUS_ATTR_OBJPATH]) {
avl_for_each_element(&path, obj, path)
ubusd_send_obj(cl, ub, obj);
return 0;
}
+static int ubusd_handle_invoke(struct ubus_client *cl, struct ubus_msg_buf *ub, struct blob_attr **attr)
+{
+ struct ubus_object *obj = NULL;
+ struct ubus_id *id;
+ const char *method;
+
+ if (!attr[UBUS_ATTR_METHOD] || !attr[UBUS_ATTR_OBJID])
+ return UBUS_STATUS_INVALID_ARGUMENT;
+
+ id = ubus_find_id(&objects, blob_get_int32(attr[UBUS_ATTR_OBJID]));
+ if (!id)
+ return UBUS_STATUS_NOT_FOUND;
+
+ obj = container_of(id, struct ubus_object, id);
+
+ method = blob_data(attr[UBUS_ATTR_METHOD]);
+
+ if (!obj->client)
+ return obj->recv_msg(cl, method, attr[UBUS_ATTR_DATA]);
+
+ blob_buf_init(&b, 0);
+ blob_put_int32(&b, UBUS_ATTR_OBJID, obj->id.id);
+ blob_put_string(&b, UBUS_ATTR_METHOD, method);
+ if (attr[UBUS_ATTR_DATA])
+ blob_put(&b, UBUS_ATTR_DATA, blob_data(attr[UBUS_ATTR_DATA]),
+ blob_len(attr[UBUS_ATTR_DATA]));
+
+ ubus_msg_free(ub);
+
+ ub = ubus_reply_from_blob(ub, true);
+ if (!ub)
+ return UBUS_STATUS_NO_DATA;
+
+ ub->hdr.type = UBUS_MSG_INVOKE;
+ ub->hdr.peer = cl->id.id;
+ ubus_msg_send(obj->client, ub, true);
+
+ return -1;
+}
+
+static int ubusd_handle_response(struct ubus_client *cl, struct ubus_msg_buf *ub, struct blob_attr **attr)
+{
+ struct ubus_object *obj;
+
+ if (!attr[UBUS_ATTR_OBJID] ||
+ (ub->hdr.type == UBUS_MSG_STATUS && !attr[UBUS_ATTR_STATUS]) ||
+ (ub->hdr.type == UBUS_MSG_DATA && !attr[UBUS_ATTR_DATA]))
+ goto error;
+
+ obj = ubusd_find_object(blob_get_int32(attr[UBUS_ATTR_OBJID]));
+ if (!obj)
+ goto error;
+
+ if (cl != obj->client)
+ goto error;
+
+ cl = ubusd_get_client_by_id(ub->hdr.peer);
+ if (!cl)
+ goto error;
+
+ ub->hdr.peer = blob_get_int32(attr[UBUS_ATTR_OBJID]);
+ ubus_msg_send(cl, ub, true);
+ return -1;
+
+error:
+ ubus_msg_free(ub);
+ return -1;
+}
+
static const ubus_cmd_cb handlers[__UBUS_MSG_LAST] = {
[UBUS_MSG_PING] = ubusd_send_pong,
[UBUS_MSG_PUBLISH] = ubusd_handle_publish,
[UBUS_MSG_LOOKUP] = ubusd_handle_lookup,
+ [UBUS_MSG_INVOKE] = ubusd_handle_invoke,
+ [UBUS_MSG_STATUS] = ubusd_handle_response,
+ [UBUS_MSG_DATA] = ubusd_handle_response,
};
void ubusd_receive_message(struct ubus_client *cl, struct ubus_msg_buf *ub)
cb = handlers[ub->hdr.type];
if (cb)
- ret = cb(cl, ub);
+ ret = cb(cl, ub, ubus_parse_msg(ub->data));
else
ret = UBUS_STATUS_INVALID_COMMAND;
+ if (ret == -1)
+ return;
+
ubus_msg_free(ub);
*retmsg_data = htonl(ret);
- ubus_msg_send(cl, ubus_msg_ref(retmsg));
+ ubus_msg_send(cl, retmsg, false);
}
static void __init ubusd_proto_init(void)