static bool
family_running(struct fw3_state *state, enum fw3_family family)
{
- return hasbit(state->running_defaults.flags, family);
+ return has(state->defaults.flags, family, family);
}
static bool
return (use_family == FW3_FAMILY_ANY) || (use_family == family);
}
-static bool
-family_loaded(struct fw3_state *state, enum fw3_family family)
-{
- return hasbit(state->defaults.flags, family);
-}
-
static void
family_set(struct fw3_state *state, enum fw3_family family, bool set)
{
if (set)
- setbit(state->defaults.flags, family);
+ set(state->defaults.flags, family, family);
else
- delbit(state->defaults.flags, family);
+ del(state->defaults.flags, family, family);
}
static int
int rv = 1;
enum fw3_family family;
enum fw3_table table;
- enum fw3_target policy = reload ? FW3_TARGET_DROP : FW3_TARGET_ACCEPT;
if (!complete && !state->statefile)
{
return rv;
}
+ if (!print_rules)
+ fw3_hotplug_zones(state, false);
+
for (family = FW3_FAMILY_V4; family <= FW3_FAMILY_V6; family++)
{
if (!complete && !family_running(state, family))
if (!family_used(family) || !restore_pipe(family, true))
continue;
- info("Removing %s rules ...", fw3_flag_names[family]);
-
for (table = FW3_TABLE_FILTER; table <= FW3_TABLE_RAW; table++)
{
if (!fw3_has_table(family == FW3_FAMILY_V6, fw3_flag_names[table]))
continue;
- info(" * %sing %s table",
- complete ? "Flush" : "Clear", fw3_flag_names[table]);
+ info(" * %sing %s %s table", complete ? "Flush" : "Clear",
+ fw3_flag_names[family], fw3_flag_names[table]);
fw3_pr("*%s\n", fw3_flag_names[table]);
else
{
/* pass 1 */
- fw3_flush_rules(table, family, false, state, policy);
- fw3_flush_zones(table, family, false, state);
+ fw3_flush_rules(state, family, table, reload, false);
+ fw3_flush_zones(state, family, table, reload, false);
/* pass 2 */
- fw3_flush_rules(table, family, true, state, policy);
- fw3_flush_zones(table, family, true, state);
+ fw3_flush_rules(state, family, table, reload, true);
+ fw3_flush_zones(state, family, table, reload, true);
}
fw3_pr("COMMIT\n");
fw3_command_close();
if (!reload)
+ {
+ if (fw3_command_pipe(false, "ipset", "-exist", "-"))
+ {
+ fw3_destroy_ipsets(state, family);
+ fw3_command_close();
+ }
+
family_set(state, family, false);
+ }
rv = 0;
}
- if (!reload && fw3_command_pipe(false, "ipset", "-exist", "-"))
- {
- fw3_destroy_ipsets(state);
- fw3_command_close();
- }
-
if (complete && (ct = fopen("/proc/net/nf_conntrack", "w")) != NULL)
{
- info("Flushing conntrack table ...");
+ info(" * Flushing conntrack table ...");
fwrite("f\n", 2, 1, ct);
fclose(ct);
if (!print_rules && !reload)
{
- fw3_set_defaults(state);
-
if (fw3_command_pipe(false, "ipset", "-exist", "-"))
{
fw3_create_ipsets(state);
continue;
}
- if (!family_loaded(state, family) || !restore_pipe(family, false))
+ if (!restore_pipe(family, false))
continue;
- info("Constructing %s rules ...", fw3_flag_names[family]);
-
for (table = FW3_TABLE_FILTER; table <= FW3_TABLE_RAW; table++)
{
if (!fw3_has_table(family == FW3_FAMILY_V6, fw3_flag_names[table]))
continue;
- info(" * Populating %s table", fw3_flag_names[table]);
+ info(" * Populating %s %s table",
+ fw3_flag_names[family], fw3_flag_names[table]);
fw3_pr("*%s\n", fw3_flag_names[table]);
- fw3_print_default_chains(table, family, state);
- fw3_print_zone_chains(table, family, state);
- fw3_print_default_head_rules(table, family, state);
- fw3_print_rules(table, family, state);
- fw3_print_redirects(table, family, state);
- fw3_print_forwards(table, family, state);
- fw3_print_zone_rules(table, family, state);
- fw3_print_default_tail_rules(table, family, state);
+ fw3_print_default_chains(state, family, table, reload);
+ fw3_print_zone_chains(state, family, table, reload);
+ fw3_print_default_head_rules(state, family, table, reload);
+ fw3_print_rules(state, family, table);
+ fw3_print_redirects(state, family, table);
+ fw3_print_forwards(state, family, table);
+ fw3_print_zone_rules(state, family, table, reload);
+ fw3_print_default_tail_rules(state, family, table, reload);
fw3_pr("COMMIT\n");
}
- if (!reload)
- fw3_print_includes(family, state);
+ fw3_print_includes(state, family, reload);
fw3_command_close();
family_set(state, family, true);
rv = 0;
}
- if (!reload && !print_rules)
- fw3_run_includes(state);
+ if (!rv)
+ {
+ fw3_set_defaults(state);
- if (!rv && !print_rules)
- fw3_write_statefile(state);
+ if (!print_rules)
+ {
+ fw3_run_includes(state, reload);
+ fw3_hotplug_zones(state, true);
+ fw3_write_statefile(state);
+ }
+ }
return rv;
}
state = build_state();
defs = &state->defaults;
- if (!fw3_lock())
- goto out;
-
if (optind >= argc)
{
rv = usage();
}
else if (!strcmp(argv[optind], "start"))
{
- rv = start(state, false);
+ if (fw3_lock())
+ {
+ rv = start(state, false);
+ fw3_unlock();
+ }
}
else if (!strcmp(argv[optind], "stop"))
{
- rv = stop(state, false, false);
+ if (fw3_lock())
+ {
+ rv = stop(state, false, false);
+ fw3_unlock();
+ }
}
else if (!strcmp(argv[optind], "flush"))
{
- rv = stop(state, true, false);
+ if (fw3_lock())
+ {
+ rv = stop(state, true, false);
+ fw3_unlock();
+ }
}
else if (!strcmp(argv[optind], "restart"))
{
- stop(state, true, false);
- free_state(state);
+ if (fw3_lock())
+ {
+ stop(state, true, false);
+ free_state(state);
- state = build_state();
- rv = start(state, false);
+ state = build_state();
+ rv = start(state, false);
+
+ fw3_unlock();
+ }
}
else if (!strcmp(argv[optind], "reload"))
{
- rv = stop(state, false, true);
- rv = start(state, !rv);
+ if (fw3_lock())
+ {
+ rv = stop(state, false, true);
+ rv = start(state, !rv);
+
+ fw3_unlock();
+ }
}
else if (!strcmp(argv[optind], "network") && (optind + 1) < argc)
{
if (state)
free_state(state);
- fw3_unlock();
-
return rv;
}