static void
interface_event(struct interface *iface, enum interface_event ev)
{
- /* TODO */
+ interface_queue_event(iface, ev);
}
static void
static void
interface_cleanup(struct interface *iface)
{
+ interface_clear_errors(iface);
if (iface->main_dev.dev)
device_remove_user(&iface->main_dev);
interface_set_proto_state(iface, NULL);
interface_cleanup(iface);
free(iface->config);
netifd_ubus_remove_interface(iface);
+ avl_delete(&interfaces.avl, &iface->node.avl);
free(iface);
}
interface_claim_device(iface);
proto_init_interface(iface, iface->config);
- if (iface->autostart)
+ if (iface->autostart && !config_init)
interface_set_up(iface);
}
strncpy(iface->name, name, sizeof(iface->name) - 1);
INIT_LIST_HEAD(&iface->errors);
+ INIT_LIST_HEAD(&iface->hotplug_list);
iface->main_dev.cb = interface_cb;
iface->l3_dev = &iface->main_dev;
interface_change_config(struct interface *if_old, struct interface *if_new)
{
struct blob_attr *old_config = if_old->config;
+ const char *old_ifname = if_old->ifname;
+ const struct proto_handler *proto = if_old->proto_handler;
+ interface_clear_errors(if_old);
if_old->config = if_new->config;
if (!if_old->config_autostart && if_new->config_autostart)
if_old->autostart = true;
if_old->config_autostart = if_new->config_autostart;
if_old->ifname = if_new->ifname;
+ if_old->proto_handler = if_new->proto_handler;
+
+ if (strcmp(old_ifname, if_new->ifname) != 0 ||
+ proto != if_new->proto_handler) {
+ D(INTERFACE, "Reload interface '%s' because of ifname/proto change\n",
+ if_old->name);
+ goto reload;
+ }
+
+ if (!proto->config_params)
+ D(INTERFACE, "No config parameters for interface '%s'\n",
+ if_old->name);
+ else if (!config_check_equal(old_config, if_new->config,
+ proto->config_params)) {
+ D(INTERFACE, "Reload interface '%s because of config changes\n",
+ if_old->name);
+ goto reload;
+ }
+
+ goto out;
+reload:
set_config_state(if_old, IFC_RELOAD);
+out:
free(old_config);
free(if_new);
}