#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <unistd.h>
#include <libubox/uloop.h>
static struct uloop_process task = {
.cb = task_complete,
};
+static const char * const eventnames[] = {"ifdown", "ifup", "ifupdate"};
static void
-run_cmd(const char *ifname, const char *device, bool up)
+run_cmd(const char *ifname, const char *device, enum interface_event event,
+ enum interface_update_flags updated)
{
char *argv[3];
int pid;
return;
}
- setenv("ACTION", up ? "ifup" : "ifdown", 1);
+ setenv("ACTION", eventnames[event], 1);
setenv("INTERFACE", ifname, 1);
if (device)
setenv("DEVICE", device, 1);
+
+ if (event == IFEV_UPDATE) {
+ if (updated & IUF_ADDRESS)
+ setenv("IFUPDATE_ADDRESSES", "1", 1);
+ if (updated & IUF_ROUTE)
+ setenv("IFUPDATE_ROUTES", "1", 1);
+ if (updated & IUF_PREFIX)
+ setenv("IFUPDATE_PREFIXES", "1", 1);
+ if (updated & IUF_DATA)
+ setenv("IFUPDATE_DATA", "1", 1);
+ }
+
argv[0] = hotplug_cmd_path;
argv[1] = "iface";
argv[2] = NULL;
if (current_ev == IFEV_UP && current->l3_dev.dev)
device = current->l3_dev.dev->ifname;
- D(SYSTEM, "Call hotplug handler for interface '%s' (%s)\n", current->name, device ? device : "none");
- run_cmd(current->name, device, current_ev == IFEV_UP);
+ D(SYSTEM, "Call hotplug handler for interface '%s', event '%s' (%s)\n",
+ current->name, eventnames[current_ev], device ? device : "none");
+ run_cmd(current->name, device, current_ev, current->updated);
}
static void
static void
interface_queue_event(struct interface *iface, enum interface_event ev)
{
- enum interface_event last_ev;
-
- D(SYSTEM, "Queue hotplug handler for interface '%s'\n", iface->name);
- netifd_ubus_interface_event(iface, ev == IFEV_UP);
- if (current == iface)
- last_ev = current_ev;
- else
- last_ev = iface->hotplug_ev;
-
- iface->hotplug_ev = ev;
- if (last_ev == ev && !list_empty(&iface->hotplug_list))
- list_del(&iface->hotplug_list);
- else if (last_ev != ev && list_empty(&iface->hotplug_list))
- list_add(&iface->hotplug_list, &pending);
+ D(SYSTEM, "Queue hotplug handler for interface '%s', event '%s'\n",
+ iface->name, eventnames[ev]);
+ if (ev == IFEV_UP || ev == IFEV_DOWN)
+ netifd_ubus_interface_event(iface, ev == IFEV_UP);
+
+ netifd_ubus_interface_notify(iface, ev != IFEV_DOWN);
+
+ if (current == iface) {
+ /* an event for iface is being processed */
+ if (!list_empty(&iface->hotplug_list)) {
+ /* an additional event for iface is pending */
+ if ((ev != current_ev || ev == IFEV_UPDATE) &&
+ !(iface->hotplug_ev == IFEV_UP && ev == IFEV_UPDATE)) {
+ /* if incoming event is different from the one
+ * being handled or if it is an update,
+ * overwrite pending event, but never
+ * overwrite an ifup with an ifupdate */
+ iface->hotplug_ev = ev;
+ }
+ else if (ev == current_ev && ev != IFEV_UPDATE) {
+ /* if incoming event is not an ifupdate
+ * and is the same as the one that is
+ * being handled, remove it from the
+ * pending list */
+ list_del_init(&iface->hotplug_list);
+ }
+ }
+ else {
+ /* no additional event for iface is pending */
+ if (ev != current_ev || ev == IFEV_UPDATE) {
+ /* only add the interface to the pending list if
+ * the event is different from the one being
+ * handled or if it is an update */
+ iface->hotplug_ev = ev;
+ /* Handle hotplug calls FIFO */
+ list_add_tail(&iface->hotplug_list, &pending);
+ }
+ }
+ }
+ else {
+ /* currently not handling an event or handling an event
+ * for another interface */
+ if (!list_empty(&iface->hotplug_list)) {
+ /* an event for iface is pending */
+ if (!(iface->hotplug_ev == IFEV_UP &&
+ ev == IFEV_UPDATE)) {
+ /* overwrite pending event, unless the incoming
+ * event is an ifupdate while the pending one
+ * is an ifup */
+ iface->hotplug_ev = ev;
+ }
+ }
+ else {
+ /* an event for the interface is not yet pending,
+ * queue it */
+ iface->hotplug_ev = ev;
+ /* Handle hotplug calls FIFO */
+ list_add_tail(&iface->hotplug_list, &pending);
+ }
+ }
if (!task.pending && !current)
call_hotplug();
{
switch (ev) {
case IFEV_UP:
+ case IFEV_UPDATE:
case IFEV_DOWN:
interface_queue_event(iface, ev);
break;