BRIDGE_ATTR_HELLO_TIME,
BRIDGE_ATTR_MAX_AGE,
BRIDGE_ATTR_BRIDGE_EMPTY,
+ BRIDGE_ATTR_MULTICAST_QUERIER,
__BRIDGE_ATTR_MAX
};
[BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
[BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
[BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
+ [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
};
static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
}
static int
+bridge_enable_interface(struct bridge_state *bst)
+{
+ int ret;
+
+ if (bst->active)
+ return 0;
+
+ ret = system_bridge_addbr(&bst->dev, &bst->config);
+ if (ret < 0)
+ return ret;
+
+ bst->active = true;
+ return 0;
+}
+
+static void
+bridge_disable_interface(struct bridge_state *bst)
+{
+ if (!bst->active)
+ return;
+
+ system_bridge_delbr(&bst->dev);
+ bst->active = false;
+}
+
+static int
bridge_enable_member(struct bridge_member *bm)
{
struct bridge_state *bst = bm->bst;
if (!bm->present)
return 0;
+ ret = bridge_enable_interface(bst);
+ if (ret)
+ goto error;
+
/* Disable IPv6 for bridge members */
if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
bm->dev.dev->settings.ipv6 = 0;
goto error;
}
+ device_set_present(&bst->dev, true);
device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
return 0;
bst->n_failed++;
bm->present = false;
bst->n_present--;
+ device_release(&bm->dev);
+
return ret;
}
vlist_for_each_element(&bst->members, bm, node)
bridge_disable_member(bm);
- system_bridge_delbr(&bst->dev);
+ bridge_disable_interface(bst);
return 0;
}
struct bridge_member *bm;
int ret;
- if (!bst->force_active && !bst->n_present)
- return -ENOENT;
+ if (!bst->n_present) {
+ if (!bst->force_active)
+ return -ENOENT;
- ret = system_bridge_addbr(&bst->dev, &bst->config);
- if (ret < 0)
- goto out;
+ ret = bridge_enable_interface(bst);
+ if (ret)
+ return ret;
+ }
bst->n_failed = 0;
vlist_for_each_element(&bst->members, bm, node)
if (!bst->force_active && !bst->n_present) {
/* initialization of all member interfaces failed */
- system_bridge_delbr(&bst->dev);
+ bridge_disable_interface(bst);
device_set_present(&bst->dev, false);
return -ENOENT;
}
if (ret < 0)
bridge_set_down(bst);
-out:
return ret;
}
bst = container_of(dev, struct bridge_state, dev);
vlist_flush_all(&bst->members);
+ free(bst->config_data);
free(bst);
}
cfg->stp = false;
cfg->forward_delay = 2;
cfg->igmp_snoop = true;
+ cfg->multicast_querier = true;
cfg->bridge_empty = false;
cfg->priority = 0x7FFF;
cfg->priority = blobmsg_get_u32(cur);
if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
- cfg->igmp_snoop = blobmsg_get_bool(cur);
+ cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
+
+ if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
+ cfg->multicast_querier = blobmsg_get_bool(cur);
if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
cfg->ageing_time = blobmsg_get_u32(cur);
BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / 8);
bst = container_of(dev, struct bridge_state, dev);
+ attr = blob_memdup(attr);
blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
blob_data(attr), blob_len(attr));
diff = 0;
uci_blob_diff(tb_dev, otb_dev, &device_attr_list, &diff);
- if (diff & ~(1 << DEV_ATTR_IFNAME))
+ if (diff)
ret = DEV_CONFIG_RESTART;
blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
bridge_config_init(dev);
}
+ free(bst->config_data);
bst->config_data = attr;
return ret;
}
continue;
bm->present = true;
+ bst->n_present++;
bridge_enable_member(bm);
}
}