2 * firewall3 - 3rd OpenWrt UCI firewall implementation
4 * Copyright (C) 2013 Jo-Philipp Wich <jo@mein.io>
6 * Permission to use, copy, modify, and/or distribute this software for any
7 * purpose with or without fee is hereby granted, provided that the above
8 * copyright notice and this permission notice appear in all copies.
10 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
11 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
12 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
13 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
14 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
15 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
16 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
23 #define C(f, tbl, tgt, fmt) \
24 { FW3_FAMILY_##f, FW3_TABLE_##tbl, FW3_FLAG_##tgt, fmt }
26 static const struct fw3_chain_spec zone_chains[] = {
27 C(ANY, FILTER, UNSPEC, "zone_%s_input"),
28 C(ANY, FILTER, UNSPEC, "zone_%s_output"),
29 C(ANY, FILTER, UNSPEC, "zone_%s_forward"),
31 C(ANY, FILTER, SRC_ACCEPT, "zone_%s_src_ACCEPT"),
32 C(ANY, FILTER, SRC_REJECT, "zone_%s_src_REJECT"),
33 C(ANY, FILTER, SRC_DROP, "zone_%s_src_DROP"),
35 C(ANY, FILTER, ACCEPT, "zone_%s_dest_ACCEPT"),
36 C(ANY, FILTER, REJECT, "zone_%s_dest_REJECT"),
37 C(ANY, FILTER, DROP, "zone_%s_dest_DROP"),
39 C(V4, NAT, SNAT, "zone_%s_postrouting"),
40 C(V4, NAT, DNAT, "zone_%s_prerouting"),
42 C(ANY, RAW, NOTRACK, "zone_%s_notrack"),
44 C(ANY, FILTER, CUSTOM_CHAINS, "input_%s_rule"),
45 C(ANY, FILTER, CUSTOM_CHAINS, "output_%s_rule"),
46 C(ANY, FILTER, CUSTOM_CHAINS, "forwarding_%s_rule"),
48 C(V4, NAT, CUSTOM_CHAINS, "prerouting_%s_rule"),
49 C(V4, NAT, CUSTOM_CHAINS, "postrouting_%s_rule"),
54 const struct fw3_option fw3_zone_opts[] = {
55 FW3_OPT("enabled", bool, zone, enabled),
57 FW3_OPT("name", string, zone, name),
58 FW3_OPT("family", family, zone, family),
60 FW3_LIST("network", device, zone, networks),
61 FW3_LIST("device", device, zone, devices),
62 FW3_LIST("subnet", network, zone, subnets),
64 FW3_OPT("input", target, zone, policy_input),
65 FW3_OPT("forward", target, zone, policy_forward),
66 FW3_OPT("output", target, zone, policy_output),
68 FW3_OPT("masq", bool, zone, masq),
69 FW3_OPT("masq_allow_invalid", bool, zone, masq_allow_invalid),
70 FW3_LIST("masq_src", network, zone, masq_src),
71 FW3_LIST("masq_dest", network, zone, masq_dest),
73 FW3_OPT("extra", string, zone, extra_src),
74 FW3_OPT("extra_src", string, zone, extra_src),
75 FW3_OPT("extra_dest", string, zone, extra_dest),
77 FW3_OPT("mtu_fix", bool, zone, mtu_fix),
78 FW3_OPT("custom_chains", bool, zone, custom_chains),
80 FW3_OPT("log", bool, zone, log),
81 FW3_OPT("log_limit", limit, zone, log_limit),
83 FW3_OPT("__flags_v4", int, zone, flags[0]),
84 FW3_OPT("__flags_v6", int, zone, flags[1]),
86 FW3_LIST("__addrs", address, zone, old_addrs),
93 check_policy(struct uci_element *e, enum fw3_flag *pol, enum fw3_flag def,
96 if (*pol == FW3_FLAG_UNSPEC)
98 warn_elem(e, "has no %s policy specified, using default", name);
101 else if (*pol > FW3_FLAG_DROP)
103 warn_elem(e, "has invalid %s policy, using default", name);
109 check_masq_addrs(struct list_head *head)
111 struct fw3_address *addr;
112 int n_addr = 0, n_failed = 0;
114 list_for_each_entry(addr, head, list)
121 if (!addr->set && addr->resolved)
125 return (n_addr == 0 || n_failed < n_addr);
129 resolve_networks(struct uci_element *e, struct fw3_zone *zone)
131 struct fw3_device *net, *tmp;
133 list_for_each_entry(net, &zone->networks, list)
135 tmp = fw3_ubus_device(net->name);
139 warn_elem(e, "cannot resolve device of network '%s'", net->name);
143 snprintf(tmp->network, sizeof(tmp->network), "%s", net->name);
144 list_add_tail(&tmp->list, &zone->devices);
151 struct fw3_zone *zone;
153 zone = calloc(1, sizeof(*zone));
157 INIT_LIST_HEAD(&zone->networks);
158 INIT_LIST_HEAD(&zone->devices);
159 INIT_LIST_HEAD(&zone->subnets);
160 INIT_LIST_HEAD(&zone->masq_src);
161 INIT_LIST_HEAD(&zone->masq_dest);
163 INIT_LIST_HEAD(&zone->old_addrs);
165 zone->enabled = true;
166 zone->custom_chains = true;
167 zone->log_limit.rate = 10;
173 fw3_load_zones(struct fw3_state *state, struct uci_package *p)
175 struct uci_section *s;
176 struct uci_element *e;
177 struct fw3_zone *zone;
178 struct fw3_defaults *defs = &state->defaults;
180 INIT_LIST_HEAD(&state->zones);
182 uci_foreach_element(&p->sections, e)
184 s = uci_to_section(e);
186 if (strcmp(s->type, "zone"))
189 zone = fw3_alloc_zone();
194 if (!fw3_parse_options(zone, fw3_zone_opts, s))
195 warn_elem(e, "has invalid options");
203 if (!zone->extra_dest)
204 zone->extra_dest = zone->extra_src;
206 if (!defs->custom_chains && zone->custom_chains)
207 zone->custom_chains = false;
209 if (!zone->name || !*zone->name)
211 warn_elem(e, "has no name - ignoring");
216 if (strlen(zone->name) > FW3_ZONE_MAXNAMELEN)
218 warn_elem(e, "must not have a name longer than %u characters",
219 FW3_ZONE_MAXNAMELEN);
224 fw3_ubus_zone_devices(zone);
226 if (list_empty(&zone->networks) && list_empty(&zone->devices) &&
227 list_empty(&zone->subnets) && !zone->extra_src)
229 warn_elem(e, "has no device, network, subnet or extra options");
232 if (!check_masq_addrs(&zone->masq_src))
234 warn_elem(e, "has unresolved masq_src, disabling masq");
238 if (!check_masq_addrs(&zone->masq_dest))
240 warn_elem(e, "has unresolved masq_dest, disabling masq");
244 check_policy(e, &zone->policy_input, defs->policy_input, "input");
245 check_policy(e, &zone->policy_output, defs->policy_output, "output");
246 check_policy(e, &zone->policy_forward, defs->policy_forward, "forward");
248 resolve_networks(e, zone);
252 fw3_setbit(zone->flags[0], FW3_FLAG_SNAT);
255 if (zone->custom_chains)
257 fw3_setbit(zone->flags[0], FW3_FLAG_SNAT);
258 fw3_setbit(zone->flags[0], FW3_FLAG_DNAT);
261 fw3_setbit(zone->flags[0], fw3_to_src_target(zone->policy_input));
262 fw3_setbit(zone->flags[0], zone->policy_forward);
263 fw3_setbit(zone->flags[0], zone->policy_output);
265 fw3_setbit(zone->flags[1], fw3_to_src_target(zone->policy_input));
266 fw3_setbit(zone->flags[1], zone->policy_forward);
267 fw3_setbit(zone->flags[1], zone->policy_output);
269 list_add_tail(&zone->list, &state->zones);
275 print_zone_chain(struct fw3_ipt_handle *handle, struct fw3_state *state,
276 bool reload, struct fw3_zone *zone)
279 struct fw3_ipt_rule *r;
280 const struct fw3_chain_spec *c;
282 const char *flt_chains[] = {
285 "forward", "forwarding",
288 const char *nat_chains[] = {
289 "prerouting", "prerouting",
290 "postrouting", "postrouting",
293 if (!fw3_is_family(zone, handle->family))
296 info(" * Zone '%s'", zone->name);
298 set(zone->flags, handle->family, handle->table);
300 if (zone->custom_chains)
301 set(zone->flags, handle->family, FW3_FLAG_CUSTOM_CHAINS);
303 for (c = zone_chains; c->format; c++)
305 /* don't touch user chains on selective stop */
306 if (reload && c->flag == FW3_FLAG_CUSTOM_CHAINS)
309 if (!fw3_is_family(c, handle->family))
312 if (c->table != handle->table)
316 !fw3_hasbit(zone->flags[handle->family == FW3_FAMILY_V6], c->flag))
319 fw3_ipt_create_chain(handle, c->format, zone->name);
322 if (zone->custom_chains)
324 if (handle->table == FW3_TABLE_FILTER)
326 for (i = 0; i < sizeof(flt_chains)/sizeof(flt_chains[0]); i += 2)
328 r = fw3_ipt_rule_new(handle);
329 fw3_ipt_rule_comment(r, "user chain for %s", flt_chains[i+1]);
330 fw3_ipt_rule_target(r, "%s_%s_rule", flt_chains[i+1], zone->name);
331 fw3_ipt_rule_append(r, "zone_%s_%s", zone->name, flt_chains[i]);
334 else if (handle->table == FW3_TABLE_NAT)
336 for (i = 0; i < sizeof(nat_chains)/sizeof(nat_chains[0]); i += 2)
338 r = fw3_ipt_rule_new(handle);
339 fw3_ipt_rule_comment(r, "user chain for %s", nat_chains[i+1]);
340 fw3_ipt_rule_target(r, "%s_%s_rule", nat_chains[i+1], zone->name);
341 fw3_ipt_rule_append(r, "zone_%s_%s", zone->name, nat_chains[i]);
346 set(zone->flags, handle->family, handle->table);
350 print_interface_rule(struct fw3_ipt_handle *handle, struct fw3_state *state,
351 bool reload, struct fw3_zone *zone,
352 struct fw3_device *dev, struct fw3_address *sub)
354 struct fw3_protocol tcp = { .protocol = 6 };
355 struct fw3_ipt_rule *r;
362 const char *chains[] = {
365 "forward", "FORWARD",
368 #define jump_target(t) \
369 ((t == FW3_FLAG_REJECT) ? "reject" : fw3_flag_names[t])
371 if (handle->table == FW3_TABLE_FILTER)
373 for (t = FW3_FLAG_ACCEPT; t <= FW3_FLAG_DROP; t++)
375 if (has(zone->flags, handle->family, fw3_to_src_target(t)))
377 r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL);
378 fw3_ipt_rule_target(r, jump_target(t));
379 fw3_ipt_rule_extra(r, zone->extra_src);
381 if (t == FW3_FLAG_ACCEPT && !state->defaults.drop_invalid)
382 fw3_ipt_rule_extra(r,
383 "-m conntrack --ctstate NEW,UNTRACKED");
385 fw3_ipt_rule_replace(r, "zone_%s_src_%s", zone->name,
389 if (has(zone->flags, handle->family, t))
391 if (t == FW3_FLAG_ACCEPT &&
392 zone->masq && !zone->masq_allow_invalid)
394 r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub);
395 fw3_ipt_rule_extra(r, "-m conntrack --ctstate INVALID");
396 fw3_ipt_rule_comment(r, "Prevent NAT leakage");
397 fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_DROP]);
398 fw3_ipt_rule_replace(r, "zone_%s_dest_%s", zone->name,
402 r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub);
403 fw3_ipt_rule_target(r, jump_target(t));
404 fw3_ipt_rule_extra(r, zone->extra_dest);
405 fw3_ipt_rule_replace(r, "zone_%s_dest_%s", zone->name,
410 for (i = 0; i < sizeof(chains)/sizeof(chains[0]); i += 2)
412 if (*chains[i] == 'o')
413 r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub);
415 r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL);
417 fw3_ipt_rule_target(r, "zone_%s_%s", zone->name, chains[i]);
419 if (*chains[i] == 'o')
420 fw3_ipt_rule_extra(r, zone->extra_dest);
422 fw3_ipt_rule_extra(r, zone->extra_src);
424 fw3_ipt_rule_replace(r, chains[i + 1]);
427 else if (handle->table == FW3_TABLE_NAT)
429 if (has(zone->flags, handle->family, FW3_FLAG_DNAT))
431 r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL);
432 fw3_ipt_rule_target(r, "zone_%s_prerouting", zone->name);
433 fw3_ipt_rule_extra(r, zone->extra_src);
434 fw3_ipt_rule_replace(r, "PREROUTING");
437 if (has(zone->flags, handle->family, FW3_FLAG_SNAT))
439 r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub);
440 fw3_ipt_rule_target(r, "zone_%s_postrouting", zone->name);
441 fw3_ipt_rule_extra(r, zone->extra_dest);
442 fw3_ipt_rule_replace(r, "POSTROUTING");
445 else if (handle->table == FW3_TABLE_MANGLE)
451 snprintf(buf, sizeof(buf) - 1, "MSSFIX(%s): ", zone->name);
453 r = fw3_ipt_rule_create(handle, &tcp, NULL, dev, NULL, sub);
454 fw3_ipt_rule_addarg(r, false, "--tcp-flags", "SYN,RST");
455 fw3_ipt_rule_addarg(r, false, "SYN", NULL);
456 fw3_ipt_rule_limit(r, &zone->log_limit);
457 fw3_ipt_rule_comment(r, "%s (mtu_fix logging)", zone->name);
458 fw3_ipt_rule_target(r, "LOG");
459 fw3_ipt_rule_addarg(r, false, "--log-prefix", buf);
460 fw3_ipt_rule_replace(r, "FORWARD");
463 r = fw3_ipt_rule_create(handle, &tcp, NULL, dev, NULL, sub);
464 fw3_ipt_rule_addarg(r, false, "--tcp-flags", "SYN,RST");
465 fw3_ipt_rule_addarg(r, false, "SYN", NULL);
466 fw3_ipt_rule_comment(r, "%s (mtu_fix)", zone->name);
467 fw3_ipt_rule_target(r, "TCPMSS");
468 fw3_ipt_rule_addarg(r, false, "--clamp-mss-to-pmtu", NULL);
469 fw3_ipt_rule_replace(r, "FORWARD");
472 else if (handle->table == FW3_TABLE_RAW)
474 if (has(zone->flags, handle->family, FW3_FLAG_NOTRACK))
476 r = fw3_ipt_rule_create(handle, NULL, dev, NULL, sub, NULL);
477 fw3_ipt_rule_target(r, "zone_%s_notrack", zone->name);
478 fw3_ipt_rule_extra(r, zone->extra_src);
479 fw3_ipt_rule_replace(r, "PREROUTING");
485 print_interface_rules(struct fw3_ipt_handle *handle, struct fw3_state *state,
486 bool reload, struct fw3_zone *zone)
488 struct fw3_device *dev;
489 struct fw3_address *sub;
491 fw3_foreach(dev, &zone->devices)
492 fw3_foreach(sub, &zone->subnets)
494 if (!fw3_is_family(sub, handle->family))
500 print_interface_rule(handle, state, reload, zone, dev, sub);
504 static struct fw3_address *
505 next_addr(struct fw3_address *addr, struct list_head *list,
506 enum fw3_family family, bool invert)
509 struct fw3_address *rv;
511 for (p = addr ? addr->list.next : list->next; p != list; p = p->next)
513 rv = list_entry(p, struct fw3_address, list);
515 if (fw3_is_family(rv, family) && rv->set && rv->invert == invert)
523 print_zone_rule(struct fw3_ipt_handle *handle, struct fw3_state *state,
524 bool reload, struct fw3_zone *zone)
526 bool first_src, first_dest;
527 struct fw3_address *msrc;
528 struct fw3_address *mdest;
529 struct fw3_ipt_rule *r;
534 if (!fw3_is_family(zone, handle->family))
537 switch (handle->table)
539 case FW3_TABLE_FILTER:
540 if (has(zone->flags, handle->family, FW3_FLAG_DNAT))
542 r = fw3_ipt_rule_new(handle);
543 fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT");
544 fw3_ipt_rule_comment(r, "Accept port redirections");
545 fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_ACCEPT]);
546 fw3_ipt_rule_append(r, "zone_%s_input", zone->name);
548 r = fw3_ipt_rule_new(handle);
549 fw3_ipt_rule_extra(r, "-m conntrack --ctstate DNAT");
550 fw3_ipt_rule_comment(r, "Accept port forwards");
551 fw3_ipt_rule_target(r, fw3_flag_names[FW3_FLAG_ACCEPT]);
552 fw3_ipt_rule_append(r, "zone_%s_forward", zone->name);
555 r = fw3_ipt_rule_new(handle);
556 fw3_ipt_rule_target(r, "zone_%s_src_%s", zone->name,
557 fw3_flag_names[zone->policy_input]);
558 fw3_ipt_rule_append(r, "zone_%s_input", zone->name);
560 r = fw3_ipt_rule_new(handle);
561 fw3_ipt_rule_target(r, "zone_%s_dest_%s", zone->name,
562 fw3_flag_names[zone->policy_forward]);
563 fw3_ipt_rule_append(r, "zone_%s_forward", zone->name);
565 r = fw3_ipt_rule_new(handle);
566 fw3_ipt_rule_target(r, "zone_%s_dest_%s", zone->name,
567 fw3_flag_names[zone->policy_output]);
568 fw3_ipt_rule_append(r, "zone_%s_output", zone->name);
572 for (t = FW3_FLAG_REJECT; t <= FW3_FLAG_DROP; t++)
574 if (has(zone->flags, handle->family, fw3_to_src_target(t)))
576 r = fw3_ipt_rule_new(handle);
578 snprintf(buf, sizeof(buf) - 1, "%s(src %s)",
579 fw3_flag_names[t], zone->name);
581 fw3_ipt_rule_limit(r, &zone->log_limit);
582 fw3_ipt_rule_target(r, "LOG");
583 fw3_ipt_rule_addarg(r, false, "--log-prefix", buf);
584 fw3_ipt_rule_append(r, "zone_%s_src_%s",
585 zone->name, fw3_flag_names[t]);
588 if (has(zone->flags, handle->family, t))
590 r = fw3_ipt_rule_new(handle);
592 snprintf(buf, sizeof(buf) - 1, "%s(dest %s)",
593 fw3_flag_names[t], zone->name);
595 fw3_ipt_rule_limit(r, &zone->log_limit);
596 fw3_ipt_rule_target(r, "LOG");
597 fw3_ipt_rule_addarg(r, false, "--log-prefix", buf);
598 fw3_ipt_rule_append(r, "zone_%s_dest_%s",
599 zone->name, fw3_flag_names[t]);
606 if (zone->masq && handle->family == FW3_FAMILY_V4)
608 /* for any negated masq_src ip, emit -s addr -j RETURN rules */
610 (msrc = next_addr(msrc, &zone->masq_src,
611 handle->family, true)) != NULL; )
613 msrc->invert = false;
614 r = fw3_ipt_rule_new(handle);
615 fw3_ipt_rule_src_dest(r, msrc, NULL);
616 fw3_ipt_rule_target(r, "RETURN");
617 fw3_ipt_rule_append(r, "zone_%s_postrouting", zone->name);
621 /* for any negated masq_dest ip, emit -d addr -j RETURN rules */
623 (mdest = next_addr(mdest, &zone->masq_dest,
624 handle->family, true)) != NULL; )
626 mdest->invert = false;
627 r = fw3_ipt_rule_new(handle);
628 fw3_ipt_rule_src_dest(r, NULL, mdest);
629 fw3_ipt_rule_target(r, "RETURN");
630 fw3_ipt_rule_append(r, "zone_%s_postrouting", zone->name);
631 mdest->invert = true;
634 /* emit masquerading entries for non-negated addresses
635 and ensure that both src and dest loops run at least once,
636 even if there are no relevant addresses */
637 for (first_src = true, msrc = NULL;
638 (msrc = next_addr(msrc, &zone->masq_src,
639 handle->family, false)) || first_src;
642 for (first_dest = true, mdest = NULL;
643 (mdest = next_addr(mdest, &zone->masq_dest,
644 handle->family, false)) || first_dest;
647 r = fw3_ipt_rule_new(handle);
648 fw3_ipt_rule_src_dest(r, msrc, mdest);
649 fw3_ipt_rule_target(r, "MASQUERADE");
650 fw3_ipt_rule_append(r, "zone_%s_postrouting", zone->name);
657 case FW3_TABLE_MANGLE:
661 print_interface_rules(handle, state, reload, zone);
665 fw3_print_zone_chains(struct fw3_ipt_handle *handle, struct fw3_state *state,
668 struct fw3_zone *zone;
670 list_for_each_entry(zone, &state->zones, list)
671 print_zone_chain(handle, state, reload, zone);
675 fw3_print_zone_rules(struct fw3_ipt_handle *handle, struct fw3_state *state,
678 struct fw3_zone *zone;
680 list_for_each_entry(zone, &state->zones, list)
681 print_zone_rule(handle, state, reload, zone);
685 fw3_flush_zones(struct fw3_ipt_handle *handle, struct fw3_state *state,
688 struct fw3_zone *z, *tmp;
689 const struct fw3_chain_spec *c;
692 list_for_each_entry_safe(z, tmp, &state->zones, list)
694 if (!has(z->flags, handle->family, handle->table))
697 for (c = zone_chains; c->format; c++)
699 /* don't touch user chains on selective stop */
700 if (reload && c->flag == FW3_FLAG_CUSTOM_CHAINS)
703 if (!fw3_is_family(c, handle->family))
706 if (c->table != handle->table)
709 if (c->flag && !has(z->flags, handle->family, c->flag))
712 snprintf(chain, sizeof(chain), c->format, z->name);
713 fw3_ipt_flush_chain(handle, chain);
715 /* keep certain basic chains that do not depend on any settings to
716 avoid purging unrelated user rules pointing to them */
717 if (reload && !c->flag)
720 fw3_ipt_delete_chain(handle, chain);
723 del(z->flags, handle->family, handle->table);
728 fw3_hotplug_zones(struct fw3_state *state, bool add)
731 struct fw3_device *d;
733 list_for_each_entry(z, &state->zones, list)
735 if (add != fw3_hasbit(z->flags[0], FW3_FLAG_HOTPLUG))
737 list_for_each_entry(d, &z->devices, list)
738 fw3_hotplug(add, z, d);
741 fw3_setbit(z->flags[0], FW3_FLAG_HOTPLUG);
743 fw3_delbit(z->flags[0], FW3_FLAG_HOTPLUG);
749 fw3_lookup_zone(struct fw3_state *state, const char *name)
753 if (list_empty(&state->zones))
756 list_for_each_entry(z, &state->zones, list)
758 if (strcmp(z->name, name))
768 fw3_resolve_zone_addresses(struct fw3_zone *zone, struct fw3_address *addr)
770 struct fw3_device *net;
771 struct fw3_address *cur, *tmp;
772 struct list_head *all;
774 all = calloc(1, sizeof(*all));
780 if (addr && addr->set)
782 tmp = malloc(sizeof(*tmp));
787 list_add_tail(&tmp->list, all);
792 list_for_each_entry(net, &zone->networks, list)
793 fw3_ubus_address(all, net->name);
795 list_for_each_entry(cur, &zone->subnets, list)
797 tmp = malloc(sizeof(*tmp));
803 list_add_tail(&tmp->list, all);