do not send an error on a full buffer for post data

[project/uhttpd.git] / client.c

diff --git a/client.c b/client.c
index c5b82d2..28c8f76 100644 (file)
--- a/client.c
+++ b/client.c
@@ -134,6 +134,7 @@ static int client_parse_request(struct client *cl, char *data)
 {
        struct http_request *req = &cl->request;
        char *type, *path, *version;
+       int h_method, h_version;
 
        type = strtok(data, " ");
        path = strtok(NULL, " ");
@@ -143,13 +144,16 @@ static int client_parse_request(struct client *cl, char *data)
 
        memset(&cl->request, 0, sizeof(cl->request));
        req->url = path;
-       req->method = find_idx(http_methods, ARRAY_SIZE(http_methods), type);
-       if (req->method < 0)
-               return CLIENT_STATE_DONE;
 
-       req->version = find_idx(http_versions, ARRAY_SIZE(http_versions), version);
-       if (cl->request.version < 0)
+       h_method = find_idx(http_methods, ARRAY_SIZE(http_methods), type);
+       h_version = find_idx(http_versions, ARRAY_SIZE(http_versions), version);
+       if (h_method < 0 || h_version < 0) {
+               req->version = UH_HTTP_VER_1_0;
                return CLIENT_STATE_DONE;
+       }
+
+       req->method = h_method;
+       req->version = h_version;
 
        return CLIENT_STATE_HEADER;
 }
@@ -200,6 +204,8 @@ static void client_header_complete(struct client *cl)
 
 static void client_parse_header(struct client *cl, char *data)
 {
+       struct http_request *r = &cl->request;
+       char *err;
        char *name;
        char *val;
 
@@ -220,9 +226,24 @@ static void client_parse_header(struct client *cl, char *data)
                if (isupper(*name))
                        *name = tolower(*name);
 
-       if (!strcasecmp(data, "Expect") &&
-           !strcasecmp(val, "100-continue"))
-               cl->request.expect_cont = true;
+       if (!strcmp(data, "expect")) {
+               if (!strcasecmp(val, "100-continue"))
+                       r->expect_cont = true;
+               else {
+                       uh_header_error(cl, 412, "Precondition Failed");
+                       return;
+               }
+       } else if (!strcmp(data, "content-length")) {
+               r->content_length = strtoul(val, &err, 0);
+               if (err && *err) {
+                       uh_header_error(cl, 400, "Bad Request");
+                       return;
+               }
+       } else if (!strcmp(data, "transfer-encoding")) {
+               if (!strcmp(val, "chunked"))
+                       r->transfer_chunked = true;
+       }
+
 
        blobmsg_add_string(&cl->hdr, data, val);
 
@@ -231,6 +252,70 @@ static void client_parse_header(struct client *cl, char *data)
 
 static bool client_data_cb(struct client *cl, char *buf, int len)
 {
+       struct dispatch *d = &cl->dispatch;
+       struct http_request *r = &cl->request;
+       int consumed = 0;
+       int cur_len = 0;
+
+       if (!d->data_send)
+               return false;
+
+       while (len) {
+               int offset = 0;
+               char *sep;
+
+               consumed += cur_len;
+               buf += cur_len;
+               len -= cur_len;
+               cur_len = min(r->content_length, len);
+
+               if (cur_len) {
+                       r->content_length -= cur_len;
+                       if (d->data_send)
+                               d->data_send(cl, buf, cur_len);
+                       continue;
+               }
+
+               if (!r->transfer_chunked)
+                       break;
+
+               if (r->transfer_chunked > 1)
+                       offset = 2;
+
+               sep = strstr(buf + offset, "\r\n");
+               if (!sep)
+                       break;
+
+               *sep = 0;
+               cur_len = sep + 2 - buf;
+
+               r->content_length = strtoul(buf + offset, &sep, 16);
+               r->transfer_chunked++;
+
+               /* invalid chunk length */
+               if (sep && *sep)
+                       goto abort;
+
+               /* empty chunk == eof */
+               if (!r->content_length)
+                       r->transfer_chunked = false;
+
+               continue;
+
+abort:
+               consumed = len;
+               r->content_length = 0;
+               r->transfer_chunked = 0;
+               break;
+       }
+
+       ustream_consume(cl->us, consumed);
+       if (!r->content_length && !r->transfer_chunked) {
+               if (cl->dispatch.data_done)
+                       cl->dispatch.data_done(cl);
+
+               cl->state = CLIENT_STATE_DONE;
+       }
        return false;
 }
 
@@ -248,7 +333,7 @@ static bool client_header_cb(struct client *cl, char *buf, int len)
        line_len = newline + 2 - buf;
        ustream_consume(cl->us, line_len);
        if (cl->state == CLIENT_STATE_DATA)
-               client_data_cb(cl, newline + 2, len - line_len);
+               return client_data_cb(cl, newline + 2, len - line_len);
 
        return true;
 }
@@ -268,14 +353,15 @@ static void client_read_cb(struct client *cl)
 
        do {
                str = ustream_get_read_buf(us, &len);
-               if (!str)
+               if (!str || !len)
                        break;
 
                if (cl->state >= array_size(read_cbs) || !read_cbs[cl->state])
                        break;
 
                if (!read_cbs[cl->state](cl, str, len)) {
-                       if (len == us->r.buffer_len)
+                       if (len == us->r.buffer_len &&
+                           cl->state != CLIENT_STATE_DATA)
                                uh_header_error(cl, 413, "Request Entity Too Large");
                        break;
                }
@@ -284,6 +370,7 @@ static void client_read_cb(struct client *cl)
 
 static void client_close(struct client *cl)
 {
+       n_clients--;
        uh_dispatch_done(cl);
        uloop_timeout_cancel(&cl->timeout);
        ustream_free(&cl->sfd.stream);