From c9125084e1e28b8f1907b2ca5c5f9d69a538425f Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Sat, 26 Jan 2008 12:14:22 +0100 Subject: [PATCH 1/1] change __uci_list_add to uci_list_insert and remove an unnecessary parameter --- list.c | 12 ++++++------ uci.h | 5 +++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/list.c b/list.c index 72d2eff..666989a 100644 --- a/list.c +++ b/list.c @@ -22,19 +22,19 @@ static inline void uci_list_init(struct uci_list *ptr) } /* inserts a new list entry between two consecutive entries */ -static inline void __uci_list_add(struct uci_list *prev, struct uci_list *next, struct uci_list *ptr) +static inline void uci_list_insert(struct uci_list *list, struct uci_list *ptr) { - next->prev = ptr; - ptr->prev = prev; - ptr->next = next; - prev->next = ptr; + list->next->prev = ptr; + ptr->prev = list; + ptr->next = list->next; + list->next = ptr; } /* inserts a new list entry at the tail of the list */ static inline void uci_list_add(struct uci_list *head, struct uci_list *ptr) { /* NB: head->prev points at the tail */ - __uci_list_add(head->prev, head, ptr); + uci_list_insert(head->prev, ptr); } static inline void uci_list_del(struct uci_list *ptr) diff --git a/uci.h b/uci.h index ce3e120..a6572c5 100644 --- a/uci.h +++ b/uci.h @@ -46,10 +46,11 @@ enum UCI_ERR_LAST }; +struct uci_list; struct uci_list { - void *next; - void *prev; + struct uci_list *next; + struct uci_list *prev; }; struct uci_element; -- 2.11.0