X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fuci.git;a=blobdiff_plain;f=list.c;h=321861c8eb7d741c17a1cc764e4e648635640b13;hp=863c48c7fd0a4ac188024a83e1d712544240839b;hb=18c13247f9e0bfad1effc0445bcda436d03789c5;hpb=87be3798a9c01d70d707760a2a7d5b8aca9df365 diff --git a/list.c b/list.c index 863c48c..321861c 100644 --- a/list.c +++ b/list.c @@ -33,7 +33,7 @@ static inline void uci_list_fixup(struct uci_list *ptr) ptr->next->prev = ptr; } -/* +/* * uci_alloc_generic allocates a new uci_element with payload * payload is appended to the struct to save memory and reduce fragmentation */ @@ -318,7 +318,7 @@ uci_lookup_ext_section(struct uci_context *ctx, struct uci_ptr *ptr) else if (!uci_validate_type(name)) goto error; - /* if the given index is negative, it specifies the section number from + /* if the given index is negative, it specifies the section number from * the end of the list */ if (idx < 0) { c = 0; @@ -346,7 +346,7 @@ uci_lookup_ext_section(struct uci_context *ctx, struct uci_ptr *ptr) goto done; error: - e = NULL; + free(section); memset(ptr, 0, sizeof(struct uci_ptr)); UCI_THROW(ctx, UCI_ERR_INVAL); done: @@ -431,11 +431,12 @@ uci_lookup_ptr(struct uci_context *ctx, struct uci_ptr *ptr, char *str, bool ext complete: ptr->flags |= UCI_LOOKUP_COMPLETE; abort: - return 0; + return UCI_OK; notfound: UCI_THROW(ctx, UCI_ERR_NOTFOUND); - return 0; + /* not a chance here */ + return UCI_ERR_NOTFOUND; } __private struct uci_element *