ucimap: allow api users to take over allocation of section data structures
[project/uci.git] / ucimap.c
index 3c5fb31..d4dc05f 100644 (file)
--- a/ucimap.c
+++ b/ucimap.c
  * GNU General Public License for more details.
  */
 #include <strings.h>
+#include <stdbool.h>
 #include <string.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include "ucimap.h"
 
+struct uci_alloc {
+       enum ucimap_type type;
+       union {
+               void **ptr;
+       } data;
+};
+
+struct uci_fixup {
+       struct list_head list;
+       struct uci_sectionmap *sm;
+       const char *name;
+       enum ucimap_type type;
+       union ucimap_data *data;
+};
+
+#define ucimap_foreach_option(_sm, _o) \
+       if (!(_sm)->options_size) \
+               (_sm)->options_size = sizeof(struct uci_optmap); \
+       for (_o = &(_sm)->options[0]; \
+                ((char *)(_o)) < ((char *) &(_sm)->options[0] + \
+                       (_sm)->options_size * (_sm)->n_options); \
+                _o = (struct uci_optmap *) ((char *)(_o) + \
+                       (_sm)->options_size))
+
+
+static inline bool
+ucimap_is_alloc(enum ucimap_type type)
+{
+       switch(type & UCIMAP_SUBTYPE) {
+       case UCIMAP_STRING:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static inline bool
+ucimap_is_fixup(enum ucimap_type type)
+{
+       switch(type & UCIMAP_SUBTYPE) {
+       case UCIMAP_SECTION:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static inline bool
+ucimap_is_simple(enum ucimap_type type)
+{
+       return ((type & UCIMAP_TYPE) == UCIMAP_SIMPLE);
+}
+
+static inline bool
+ucimap_is_list(enum ucimap_type type)
+{
+       return ((type & UCIMAP_TYPE) == UCIMAP_LIST);
+}
+
+static inline bool
+ucimap_is_custom(enum ucimap_type type)
+{
+       return ((type & UCIMAP_SUBTYPE) == UCIMAP_CUSTOM);
+}
+
+static inline void *
+ucimap_section_ptr(struct ucimap_section_data *sd)
+{
+       return ((char *) sd - sd->sm->smap_offset);
+}
+
+static inline union ucimap_data *
+ucimap_get_data(struct ucimap_section_data *sd, struct uci_optmap *om)
+{
+       void *data;
+
+       data = (char *) ucimap_section_ptr(sd) + om->offset;
+       return data;
+}
 
 int
 ucimap_init(struct uci_map *map)
 {
        INIT_LIST_HEAD(&map->sdata);
+       INIT_LIST_HEAD(&map->fixup);
        return 0;
 }
 
 static void
-ucimap_free_section(struct uci_map *map, struct uci_sectmap_data *sd)
+ucimap_free_item(struct uci_alloc *a)
+{
+       switch(a->type & UCIMAP_TYPE) {
+       case UCIMAP_SIMPLE:
+       case UCIMAP_LIST:
+               free(a->data.ptr);
+               break;
+       }
+}
+
+static void
+ucimap_add_alloc(struct ucimap_section_data *sd, void *ptr)
 {
-       void *section = sd;
+       struct uci_alloc *a = &sd->allocmap[sd->allocmap_len++];
+       a->type = UCIMAP_SIMPLE;
+       a->data.ptr = ptr;
+}
+
+static void
+ucimap_free_section(struct uci_map *map, struct ucimap_section_data *sd)
+{
+       void *section;
        int i;
 
-       section = (char *) section + sizeof(struct uci_sectmap_data);
+       section = ucimap_section_ptr(sd);
        if (!list_empty(&sd->list))
                list_del(&sd->list);
 
-       if (sd->sm->free_section)
-               sd->sm->free_section(map, section);
+       if (sd->sm->free)
+               sd->sm->free(map, section);
 
        for (i = 0; i < sd->allocmap_len; i++) {
-               free(sd->allocmap[i]);
+               ucimap_free_item(&sd->allocmap[i]);
        }
 
        free(sd->allocmap);
@@ -52,71 +152,120 @@ ucimap_cleanup(struct uci_map *map)
        struct list_head *ptr, *tmp;
 
        list_for_each_safe(ptr, tmp, &map->sdata) {
-               struct uci_sectmap_data *sd = list_entry(ptr, struct uci_sectmap_data, list);
+               struct ucimap_section_data *sd = list_entry(ptr, struct ucimap_section_data, list);
                ucimap_free_section(map, sd);
        }
 }
 
+static void
+ucimap_add_fixup(struct uci_map *map, union ucimap_data *data, struct uci_optmap *om, const char *str)
+{
+       struct uci_fixup *f;
+
+       f = malloc(sizeof(struct uci_fixup));
+       if (!f)
+               return;
+
+       INIT_LIST_HEAD(&f->list);
+       f->sm = om->data.sm;
+       f->name = str;
+       f->type = om->type;
+       f->data = data;
+       list_add(&f->list, &map->fixup);
+}
+
+static void
+ucimap_add_value(union ucimap_data *data, struct uci_optmap *om, struct ucimap_section_data *sd, const char *str)
+{
+       union ucimap_data tdata = *data;
+       char *eptr = NULL;
+       char *s;
+       int val;
+
+       if (ucimap_is_list(om->type) && !ucimap_is_fixup(om->type))
+               data = &data->list->item[data->list->n_items++];
+
+       switch(om->type & UCIMAP_SUBTYPE) {
+       case UCIMAP_STRING:
+               if ((om->data.s.maxlen > 0) &&
+                       (strlen(str) > om->data.s.maxlen))
+                       return;
+
+               s = strdup(str);
+               tdata.s = s;
+               ucimap_add_alloc(sd, s);
+               break;
+       case UCIMAP_BOOL:
+               val = -1;
+               if (strcmp(str, "on"))
+                       val = true;
+               else if (strcmp(str, "1"))
+                       val = true;
+               else if (strcmp(str, "enabled"))
+                       val = true;
+               else if (strcmp(str, "off"))
+                       val = false;
+               else if (strcmp(str, "0"))
+                       val = false;
+               else if (strcmp(str, "disabled"))
+                       val = false;
+               if (val == -1)
+                       return;
+
+               tdata.b = val;
+               break;
+       case UCIMAP_INT:
+               val = strtol(str, &eptr, om->data.i.base);
+               if (!eptr || *eptr == '\0')
+                       tdata.i = val;
+               else
+                       return;
+               break;
+       case UCIMAP_SECTION:
+               ucimap_add_fixup(sd->map, data, om, str);
+               return;
+       case UCIMAP_CUSTOM:
+               tdata.s = (char *) data;
+               break;
+       }
+       if (om->parse) {
+               if (om->parse(ucimap_section_ptr(sd), om, &tdata, str) < 0)
+                       return;
+       }
+       if (ucimap_is_custom(om->type))
+               return;
+       memcpy(data, &tdata, sizeof(union ucimap_data));
+}
+
 
 static int
-ucimap_parse_options(struct uci_map *map, struct uci_sectmap *sm, struct uci_sectmap_data *sd, struct uci_section *s)
+ucimap_parse_options(struct uci_map *map, struct uci_sectionmap *sm, struct ucimap_section_data *sd, struct uci_section *s)
 {
-       struct uci_element *e;
+       struct uci_element *e, *l;
        struct uci_option *o;
-       void *section = sd;
-       int i;
+       union ucimap_data *data;
 
-       section = (unsigned char *) section + sizeof(struct uci_sectmap_data);
        uci_foreach_element(&s->options, e) {
-               struct uci_optmap *om = NULL;
+               struct uci_optmap *om = NULL, *tmp;
 
-               for (i = 0; i < sm->n_options; i++) {
-                       if (strcmp(e->name, sm->options[i].name) == 0) {
-                               om = &sm->options[i];
+               ucimap_foreach_option(sm, tmp) {
+                       if (strcmp(e->name, tmp->name) == 0) {
+                               om = tmp;
                                break;
                        }
                }
                if (!om)
-                       goto next_element;
+                       continue;
 
+               data = ucimap_get_data(sd, om);
                o = uci_to_option(e);
-               if(o->type != UCI_TYPE_STRING)
-                       goto next_element;
-
-               switch(om->type) {
-               case UCIMAP_STRING: {
-                       char **ptr;
-                       if ((om->data.s.maxlen > 0) &&
-                               (strlen(o->v.string) > om->data.s.maxlen))
-                               goto next_element;
-
-                       ptr = (char **) ((char *) section + om->offset);
-                       *ptr = strdup(o->v.string);
-                       sd->allocmap[sd->allocmap_len++] = *ptr;
-                       } break;
-               case UCIMAP_BOOL: {
-                       bool *ptr = (bool *)((char *)section + om->offset);
-                       if (strcmp(o->v.string, "on"))
-                               *ptr = true;
-                       else if (strcmp(o->v.string, "1"))
-                               *ptr = true;
-                       else if (strcmp(o->v.string, "enabled"))
-                               *ptr = true;
-                       else
-                               *ptr = false;
-                       } break;
-               case UCIMAP_INT: {
-                       int *ptr = (int *)((char *)section + om->offset);
-                       char *eptr = NULL;
-                       int val;
-
-                       val = strtol(o->v.string, &eptr, om->data.i.base);
-                       if (!eptr || *eptr == '\0')
-                               *ptr = val;
-                       } break;
+               if ((o->type == UCI_TYPE_STRING) && ucimap_is_simple(om->type)) {
+                       ucimap_add_value(data, om, sd, o->v.string);
+               } else if ((o->type == UCI_TYPE_LIST) && ucimap_is_list(om->type)) {
+                       uci_foreach_element(&o->v.list, l) {
+                               ucimap_add_value(data, om, sd, l->name);
+                       }
                }
-next_element:
-               continue;
        }
 
        return 0;
@@ -124,39 +273,86 @@ next_element:
 
 
 static int
-ucimap_parse_section(struct uci_map *map, struct uci_sectmap *sm, struct uci_section *s)
+ucimap_parse_section(struct uci_map *map, struct uci_sectionmap *sm, struct uci_section *s)
 {
-       struct uci_sectmap_data *sd = NULL;
-       void *section = NULL;
+       struct ucimap_section_data *sd = NULL;
+       struct uci_optmap *om;
+       char *section_name;
+       void *section;
+       int n_alloc = 2;
        int err;
 
-       sd = malloc(sm->alloc_len + sizeof(struct uci_sectmap_data));
+       if (sm->alloc) {
+               sd = sm->alloc(map, sm, s);
+               memset(sd, 0, sizeof(struct ucimap_section_data));
+       } else {
+               sd = malloc(sm->alloc_len);
+               memset(sd, 0, sm->alloc_len);
+       }
+
        if (!sd)
                return UCI_ERR_MEM;
 
-       memset(sd, 0, sm->alloc_len + sizeof(struct uci_sectmap_data));
        INIT_LIST_HEAD(&sd->list);
-
+       sd->map = map;
        sd->sm = sm;
-       sd->allocmap = malloc(sm->n_options * sizeof(void *));
+
+       ucimap_foreach_option(sm, om) {
+               if (ucimap_is_list(om->type)) {
+                       union ucimap_data *data;
+                       struct uci_element *e;
+                       int n_elements = 0;
+                       int size;
+
+                       data = ucimap_get_data(sd, om);
+                       uci_foreach_element(&s->options, e) {
+                               struct uci_option *o = uci_to_option(e);
+                               struct uci_element *tmp;
+
+                               if (strcmp(e->name, om->name) != 0)
+                                       continue;
+
+                               uci_foreach_element(&o->v.list, tmp) {
+                                       n_elements++;
+                               }
+                               break;
+                       }
+                       n_alloc += n_elements + 1;
+                       size = sizeof(struct ucimap_list) +
+                               n_elements * sizeof(union ucimap_data);
+                       data->list = malloc(size);
+                       memset(data->list, 0, size);
+               } else if (ucimap_is_alloc(om->type)) {
+                       n_alloc++;
+               }
+       }
+
+       sd->allocmap = malloc(n_alloc * sizeof(struct uci_alloc));
        if (!sd->allocmap)
                goto error_mem;
 
-       sd->section_name = strdup(s->e.name);
-       if (!sd->section_name)
+       section_name = strdup(s->e.name);
+       if (!section_name)
                goto error_mem;
 
+       sd->section_name = section_name;
+
        sd->cmap = malloc(BITFIELD_SIZE(sm->n_options));
        if (!sd->cmap)
                goto error_mem;
 
        memset(sd->cmap, 0, BITFIELD_SIZE(sm->n_options));
-       sd->allocmap[sd->allocmap_len++] = (void *)sd->section_name;
-       sd->allocmap[sd->allocmap_len++] = (void *)sd->cmap;
+       ucimap_add_alloc(sd, (void *)section_name);
+       ucimap_add_alloc(sd, (void *)sd->cmap);
+       ucimap_foreach_option(sm, om) {
+               if (!ucimap_is_list(om->type))
+                       continue;
 
-       section = (char *)sd + sizeof(struct uci_sectmap_data);
+               ucimap_add_alloc(sd, ucimap_get_data(sd, om)->list);
+       }
 
-       err = sm->init_section(map, section, s);
+       section = ucimap_section_ptr(sd);
+       err = sm->init(map, section, s);
        if (err)
                goto error;
 
@@ -165,10 +361,6 @@ ucimap_parse_section(struct uci_map *map, struct uci_sectmap *sm, struct uci_sec
        if (err)
                goto error;
 
-       err = sm->add_section(map, section);
-       if (err)
-               goto error;
-
        return 0;
 
 error_mem:
@@ -200,32 +392,35 @@ ucimap_fill_ptr(struct uci_ptr *ptr, struct uci_section *s, const char *option)
 }
 
 void
-ucimap_set_changed(void *section, void *field)
+ucimap_set_changed(struct ucimap_section_data *sd, void *field)
 {
-       char *sptr = (char *)section - sizeof(struct uci_sectmap_data);
-       struct uci_sectmap_data *sd = (struct uci_sectmap_data *) sptr;
-       struct uci_sectmap *sm = sd->sm;
+       void *section = ucimap_section_ptr(sd);
+       struct uci_sectionmap *sm = sd->sm;
+       struct uci_optmap *om;
        int ofs = (char *)field - (char *)section;
-       int i;
+       int i = 0;
 
-       for (i = 0; i < sm->n_options; i++) {
-               if (sm->options[i].offset == ofs) {
+       ucimap_foreach_option(sm, om) {
+               if (om->offset == ofs) {
                        SET_BIT(sd->cmap, i);
                        break;
                }
+               i++;
        }
 }
 
 int
 ucimap_store_section(struct uci_map *map, struct uci_package *p, void *section)
 {
-       char *sptr = (char *)section - sizeof(struct uci_sectmap_data);
-       struct uci_sectmap_data *sd = (struct uci_sectmap_data *) sptr;
-       struct uci_sectmap *sm = sd->sm;
+       char *sptr = (char *)section - sizeof(struct ucimap_section_data);
+       struct ucimap_section_data *sd = (struct ucimap_section_data *) sptr;
+       struct uci_sectionmap *sm = sd->sm;
        struct uci_section *s = NULL;
+       struct uci_optmap *om;
        struct uci_element *e;
        struct uci_ptr ptr;
-       int i, ret;
+       int i = 0;
+       int ret;
 
        uci_foreach_element(&p->sections, e) {
                if (!strcmp(e->name, sd->section_name)) {
@@ -236,28 +431,33 @@ ucimap_store_section(struct uci_map *map, struct uci_package *p, void *section)
        if (!s)
                return UCI_ERR_NOTFOUND;
 
-       for (i = 0; i < sm->n_options; i++) {
-               struct uci_optmap *om = &sm->options[i];
+       ucimap_foreach_option(sm, om) {
+               union ucimap_data *data;
                static char buf[32];
                const char *str = NULL;
-               void *p = (char *)section + om->offset;
 
+               if (ucimap_is_list(om->type))
+                       continue;
+
+               data = ucimap_get_data(sd, om);
                if (!TEST_BIT(sd->cmap, i))
                        continue;
 
                ucimap_fill_ptr(&ptr, s, om->name);
-               switch(om->type) {
+               switch(om->type & UCIMAP_SUBTYPE) {
                case UCIMAP_STRING:
-                       str = *((char **) p);
+                       str = data->s;
                        break;
                case UCIMAP_INT:
-                       sprintf(buf, "%d", *((int *) p));
+                       sprintf(buf, "%d", data->i);
                        str = buf;
                        break;
                case UCIMAP_BOOL:
-                       sprintf(buf, "%d", !!*((bool *)p));
+                       sprintf(buf, "%d", !!data->b);
                        str = buf;
                        break;
+               default:
+                       continue;
                }
                ptr.value = str;
 
@@ -266,25 +466,74 @@ ucimap_store_section(struct uci_map *map, struct uci_package *p, void *section)
                        return ret;
 
                CLR_BIT(sd->cmap, i);
+               i++;
        }
 
        return 0;
 }
 
+void *
+ucimap_find_section(struct uci_map *map, struct uci_fixup *f)
+{
+       struct ucimap_section_data *sd;
+       struct list_head *p;
+
+       list_for_each(p, &map->sdata) {
+               sd = list_entry(p, struct ucimap_section_data, list);
+               if (sd->sm != f->sm)
+                       continue;
+               if (strcmp(f->name, sd->section_name) != 0)
+                       continue;
+               return ucimap_section_ptr(sd);
+       }
+       return NULL;
+}
 
 void
 ucimap_parse(struct uci_map *map, struct uci_package *pkg)
 {
        struct uci_element *e;
+       struct list_head *p, *tmp;
        int i;
 
+       INIT_LIST_HEAD(&map->fixup);
        uci_foreach_element(&pkg->sections, e) {
                struct uci_section *s = uci_to_section(e);
 
                for (i = 0; i < map->n_sections; i++) {
-                       if (strcmp(s->type, map->sections[i].type) != 0)
+                       if (strcmp(s->type, map->sections[i]->type) != 0)
                                continue;
-                       ucimap_parse_section(map, &map->sections[i], s);
+                       ucimap_parse_section(map, map->sections[i], s);
                }
        }
+       list_for_each_safe(p, tmp, &map->fixup) {
+               struct uci_fixup *f = list_entry(p, struct uci_fixup, list);
+               void *ptr = ucimap_find_section(map, f);
+               struct ucimap_list *list;
+
+               if (!ptr)
+                       continue;
+
+               switch(f->type & UCIMAP_TYPE) {
+               case UCIMAP_SIMPLE:
+                       f->data->section = ptr;
+                       break;
+               case UCIMAP_LIST:
+                       list = f->data->list;
+                       list->item[list->n_items++].section = ptr;
+                       break;
+               }
+               free(f);
+       }
+       list_for_each_safe(p, tmp, &map->sdata) {
+               struct ucimap_section_data *sd = list_entry(p, struct ucimap_section_data, list);
+               void *section;
+
+               if (sd->done)
+                       continue;
+
+               section = ucimap_section_ptr(sd);
+               if (sd->sm->add(map, section) != 0)
+                       ucimap_free_section(map, sd);
+       }
 }