projects
/
project
/
uci.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix skipping directories in uci_list_config_files
[project/uci.git]
/
file.c
diff --git
a/file.c
b/file.c
index
0fc68a6
..
5a8c6cb
100644
(file)
--- a/
file.c
+++ b/
file.c
@@
-33,7
+33,6
@@
#include "uci_internal.h"
#define LINEBUF 32
#include "uci_internal.h"
#define LINEBUF 32
-#define LINEBUF_MAX 4096
/*
* Fetch a new line from the input stream and resize buffer if necessary
/*
* Fetch a new line from the input stream and resize buffer if necessary
@@
-69,11
+68,10
@@
__private void uci_getln(struct uci_context *ctx, int offset)
return;
}
return;
}
- if (pctx->bufsz > LINEBUF_MAX/2)
- uci_parse_error(ctx, "line too long");
-
pctx->bufsz *= 2;
pctx->buf = uci_realloc(ctx, pctx->buf, pctx->bufsz);
pctx->bufsz *= 2;
pctx->buf = uci_realloc(ctx, pctx->buf, pctx->bufsz);
+ if (!pctx->buf)
+ UCI_THROW(ctx, UCI_ERR_MEM);
} while (1);
}
} while (1);
}
@@
-237,7
+235,7
@@
done:
/*
* extract the next argument from the command line
*/
/*
* extract the next argument from the command line
*/
-static int next_arg(struct uci_context *ctx, bool required, bool name)
+static int next_arg(struct uci_context *ctx, bool required, bool name
, bool package
)
{
struct uci_parse_context *pctx = ctx->pctx;
int val, ptr;
{
struct uci_parse_context *pctx = ctx->pctx;
int val, ptr;
@@
-256,7
+254,7
@@
static int next_arg(struct uci_context *ctx, bool required, bool name)
goto done;
}
goto done;
}
- if (name && !uci_validate_
name(pctx_str(pctx, val)
))
+ if (name && !uci_validate_
str(pctx_str(pctx, val), name, package
))
uci_parse_error(ctx, "invalid character in name field");
done:
uci_parse_error(ctx, "invalid character in name field");
done:
@@
-278,16
+276,12
@@
int uci_parse_argument(struct uci_context *ctx, FILE *stream, char **str, char *
uci_alloc_parse_context(ctx);
ctx->pctx->file = stream;
uci_alloc_parse_context(ctx);
ctx->pctx->file = stream;
-
if (!*str) {
if (!*str) {
+ ctx->pctx->pos = 0;
uci_getln(ctx, 0);
uci_getln(ctx, 0);
- *str = ctx->pctx->buf;
- } else {
- UCI_ASSERT(ctx, ctx->pctx->pos == *str - ctx->pctx->buf);
}
}
- /*FIXME do we need to skip empty lines? */
- ofs_result = next_arg(ctx, false, false);
+ ofs_result = next_arg(ctx, false, false, false);
*result = pctx_str(ctx->pctx, ofs_result);
*str = pctx_cur_str(ctx->pctx);
*result = pctx_str(ctx->pctx, ofs_result);
*str = pctx_cur_str(ctx->pctx);
@@
-341,7
+335,7
@@
static void assert_eol(struct uci_context *ctx)
int ofs_tmp;
skip_whitespace(ctx);
int ofs_tmp;
skip_whitespace(ctx);
- ofs_tmp = next_arg(ctx, false, false);
+ ofs_tmp = next_arg(ctx, false, false
, false
);
tmp = pctx_str(ctx->pctx, ofs_tmp);
if (*tmp && (ctx->flags & UCI_FLAG_STRICT))
uci_parse_error(ctx, "too many arguments");
tmp = pctx_str(ctx->pctx, ofs_tmp);
if (*tmp && (ctx->flags & UCI_FLAG_STRICT))
uci_parse_error(ctx, "too many arguments");
@@
-394,7
+388,7
@@
static void uci_parse_package(struct uci_context *ctx, bool single)
/* command string null-terminated by strtok */
pctx->pos += strlen(pctx_cur_str(pctx)) + 1;
/* command string null-terminated by strtok */
pctx->pos += strlen(pctx_cur_str(pctx)) + 1;
- ofs_name = next_arg(ctx, true, true);
+ ofs_name = next_arg(ctx, true, true
, true
);
name = pctx_str(pctx, ofs_name);
assert_eol(ctx);
if (single)
name = pctx_str(pctx, ofs_name);
assert_eol(ctx);
if (single)
@@
-427,12
+421,12
@@
static void uci_parse_config(struct uci_context *ctx)
/* command string null-terminated by strtok */
pctx->pos += strlen(pctx_cur_str(pctx)) + 1;
/* command string null-terminated by strtok */
pctx->pos += strlen(pctx_cur_str(pctx)) + 1;
- ofs_type = next_arg(ctx, true, false);
+ ofs_type = next_arg(ctx, true, false
, false
);
type = pctx_str(pctx, ofs_type);
if (!uci_validate_type(type))
uci_parse_error(ctx, "invalid character in type field");
type = pctx_str(pctx, ofs_type);
if (!uci_validate_type(type))
uci_parse_error(ctx, "invalid character in type field");
- ofs_name = next_arg(ctx, false, true);
+ ofs_name = next_arg(ctx, false, true
, false
);
type = pctx_str(pctx, ofs_type);
name = pctx_str(pctx, ofs_name);
assert_eol(ctx);
type = pctx_str(pctx, ofs_type);
name = pctx_str(pctx, ofs_name);
assert_eol(ctx);
@@
-443,8
+437,13
@@
static void uci_parse_config(struct uci_context *ctx)
} else {
uci_fill_ptr(ctx, &ptr, &pctx->package->e);
e = uci_lookup_list(&pctx->package->sections, name);
} else {
uci_fill_ptr(ctx, &ptr, &pctx->package->e);
e = uci_lookup_list(&pctx->package->sections, name);
- if (e)
+ if (e)
{
ptr.s = uci_to_section(e);
ptr.s = uci_to_section(e);
+
+ if ((ctx->flags & UCI_FLAG_STRICT) && strcmp(ptr.s->type, type))
+ uci_parse_error(ctx, "section of different type overwrites prior section with same name");
+ }
+
ptr.section = name;
ptr.value = type;
ptr.section = name;
ptr.value = type;
@@
-472,8
+471,8
@@
static void uci_parse_option(struct uci_context *ctx, bool list)
/* command string null-terminated by strtok */
pctx->pos += strlen(pctx_cur_str(pctx)) + 1;
/* command string null-terminated by strtok */
pctx->pos += strlen(pctx_cur_str(pctx)) + 1;
- ofs_name = next_arg(ctx, true, true);
- ofs_value = next_arg(ctx, false, false);
+ ofs_name = next_arg(ctx, true, true
, false
);
+ ofs_value = next_arg(ctx, false, false
, false
);
name = pctx_str(pctx, ofs_name);
value = pctx_str(pctx, ofs_value);
assert_eol(ctx);
name = pctx_str(pctx, ofs_name);
value = pctx_str(pctx, ofs_value);
assert_eol(ctx);
@@
-741,17
+740,6
@@
static void uci_file_commit(struct uci_context *ctx, struct uci_package **packag
if ((asprintf(&filename, "%s/.%s.uci-XXXXXX", ctx->confdir, p->e.name) < 0) || !filename)
UCI_THROW(ctx, UCI_ERR_MEM);
if ((asprintf(&filename, "%s/.%s.uci-XXXXXX", ctx->confdir, p->e.name) < 0) || !filename)
UCI_THROW(ctx, UCI_ERR_MEM);
- if (!mktemp(filename))
- *filename = 0;
-
- if (!*filename) {
- free(filename);
- UCI_THROW(ctx, UCI_ERR_IO);
- }
-
- if ((stat(filename, &statbuf) == 0) && ((statbuf.st_mode & S_IFMT) != S_IFREG))
- UCI_THROW(ctx, UCI_ERR_IO);
-
/* open the config file for writing now, so that it is locked */
f1 = uci_open_stream(ctx, p->path, NULL, SEEK_SET, true, true);
/* open the config file for writing now, so that it is locked */
f1 = uci_open_stream(ctx, p->path, NULL, SEEK_SET, true, true);
@@
-786,6
+774,17
@@
static void uci_file_commit(struct uci_context *ctx, struct uci_package **packag
goto done;
}
goto done;
}
+ if (!mktemp(filename))
+ *filename = 0;
+
+ if (!*filename) {
+ free(filename);
+ UCI_THROW(ctx, UCI_ERR_IO);
+ }
+
+ if ((stat(filename, &statbuf) == 0) && ((statbuf.st_mode & S_IFMT) != S_IFREG))
+ UCI_THROW(ctx, UCI_ERR_IO);
+
f2 = uci_open_stream(ctx, filename, p->path, SEEK_SET, true, true);
uci_export(ctx, f2, p, false);
f2 = uci_open_stream(ctx, filename, p->path, SEEK_SET, true, true);
uci_export(ctx, f2, p, false);
@@
-801,12
+800,15
@@
done:
free(name);
free(path);
uci_close_stream(f1);
free(name);
free(path);
uci_close_stream(f1);
- if (do_rename && rename(filename, p->path)) {
- unlink(filename);
- UCI_THROW(ctx, UCI_ERR_IO);
+ if (do_rename) {
+ path = realpath(p->path, NULL);
+ if (!path || rename(filename, path)) {
+ unlink(filename);
+ UCI_THROW(ctx, UCI_ERR_IO);
+ }
+ free(path);
}
free(filename);
}
free(filename);
- sync();
if (ctx->err)
UCI_THROW(ctx, ctx->err);
}
if (ctx->err)
UCI_THROW(ctx, ctx->err);
}
@@
-833,7
+835,7
@@
static char **uci_list_config_files(struct uci_context *ctx)
{
char **configs;
glob_t globbuf;
{
char **configs;
glob_t globbuf;
- int size, i;
+ int size, i
, j, skipped
;
char *buf;
char *dir;
char *buf;
char *dir;
@@
-845,18
+847,22
@@
static char **uci_list_config_files(struct uci_context *ctx)
}
size = sizeof(char *) * (globbuf.gl_pathc + 1);
}
size = sizeof(char *) * (globbuf.gl_pathc + 1);
+ skipped = 0;
for(i = 0; i < globbuf.gl_pathc; i++) {
char *p;
p = get_filename(globbuf.gl_pathv[i]);
for(i = 0; i < globbuf.gl_pathc; i++) {
char *p;
p = get_filename(globbuf.gl_pathv[i]);
- if (!p)
+ if (!p) {
+ skipped++;
continue;
continue;
+ }
size += strlen(p) + 1;
}
size += strlen(p) + 1;
}
- configs = uci_malloc(ctx, size);
- buf = (char *) &configs[globbuf.gl_pathc + 1];
+ configs = uci_malloc(ctx, size - skipped);
+ buf = (char *) &configs[globbuf.gl_pathc + 1 - skipped];
+ j = 0;
for(i = 0; i < globbuf.gl_pathc; i++) {
char *p;
for(i = 0; i < globbuf.gl_pathc; i++) {
char *p;
@@
-867,7
+873,7
@@
static char **uci_list_config_files(struct uci_context *ctx)
if (!uci_validate_package(p))
continue;
if (!uci_validate_package(p))
continue;
- configs[
i
] = buf;
+ configs[
j++
] = buf;
strcpy(buf, p);
buf += strlen(buf) + 1;
}
strcpy(buf, p);
buf += strlen(buf) + 1;
}