From ad5333a73b222e95458e05d52f349194df9ae7c6 Mon Sep 17 00:00:00 2001 From: Abhimanyu Vishwakarma Date: Tue, 3 Jan 2017 11:37:05 +0530 Subject: [PATCH 1/1] ubus: ubus_free: clear pending timers before freeing context If a synchronous operation is executed on a ubus context after uloop_done() has been called, the context's pending_timer may remain in uloop's list of timeouts. This leads to undefined behaviour during next execution of uloop code, as it may be referring to unavailable memory or memory that has been allocated for different purposes. Signed-off-by: Marcin Nowakowski Signed-off-by: Abhimanyu Vishwakarma --- libubus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libubus.c b/libubus.c index b25d8b0..51a1483 100644 --- a/libubus.c +++ b/libubus.c @@ -362,6 +362,7 @@ void ubus_shutdown(struct ubus_context *ctx) if (!ctx) return; close(ctx->sock.fd); + uloop_timeout_cancel(&ctx->pending_timer); free(ctx->msgbuf.data); } -- 2.11.0