X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fubus.git;a=blobdiff_plain;f=libubus.c;h=e42f14f9cdf026a3dea36beeb45d60557cb717b9;hp=94b0044957e275deab7391545205485dae0071d5;hb=73cbb94b4808ac86e686ef80ff4af9b4b84945bd;hpb=f07b02b56089660f00b5070a96e76c43063a11ec

diff --git a/libubus.c b/libubus.c
index 94b0044..e42f14f 100644
--- a/libubus.c
+++ b/libubus.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2011 Felix Fietkau <nbd@openwrt.org>
+ * Copyright (C) 2011-2014 Felix Fietkau <nbd@openwrt.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License version 2.1
@@ -12,21 +12,16 @@
  */
 
 #include <sys/types.h>
-#include <sys/uio.h>
 #include <sys/socket.h>
-#include <fcntl.h>
 #include <unistd.h>
-#include <poll.h>
 
 #include <libubox/blob.h>
 #include <libubox/blobmsg.h>
-#include <libubox/usock.h>
 
 #include "libubus.h"
+#include "libubus-internal.h"
 #include "ubusmsg.h"
 
-#define STATIC_IOV(_var) { .iov_base = (char *) &(_var), .iov_len = sizeof(_var) }
-
 const char *__ubus_strerror[__UBUS_STATUS_LAST] = {
 	[UBUS_STATUS_OK] = "Success",
 	[UBUS_STATUS_INVALID_COMMAND] = "Invalid command",
@@ -38,22 +33,14 @@ const char *__ubus_strerror[__UBUS_STATUS_LAST] = {
 	[UBUS_STATUS_TIMEOUT] = "Request timed out",
 	[UBUS_STATUS_NOT_SUPPORTED] = "Operation not supported",
 	[UBUS_STATUS_UNKNOWN_ERROR] = "Unknown error",
+	[UBUS_STATUS_CONNECTION_FAILED] = "Connection failed",
 };
 
-static struct blob_buf b;
-
-static const struct blob_attr_info ubus_policy[UBUS_ATTR_MAX] = {
-	[UBUS_ATTR_STATUS] = { .type = BLOB_ATTR_INT32 },
-	[UBUS_ATTR_OBJID] = { .type = BLOB_ATTR_INT32 },
-	[UBUS_ATTR_OBJPATH] = { .type = BLOB_ATTR_STRING },
-	[UBUS_ATTR_METHOD] = { .type = BLOB_ATTR_STRING },
-};
-static struct blob_attr *attrbuf[UBUS_ATTR_MAX];
+struct blob_buf b __hidden = {};
 
-struct ubus_pending_data {
+struct ubus_pending_msg {
 	struct list_head list;
-	int type;
-	struct blob_attr data[];
+	struct ubus_msghdr_buf hdr;
 };
 
 static int ubus_cmp_id(const void *k1, const void *k2, void *ptr)
@@ -66,12 +53,6 @@ static int ubus_cmp_id(const void *k1, const void *k2, void *ptr)
 		return *id1 > *id2;
 }
 
-static struct blob_attr **ubus_parse_msg(struct blob_attr *msg)
-{
-	blob_parse(msg, attrbuf, ubus_policy, UBUS_ATTR_MAX);
-	return attrbuf;
-}
-
 const char *ubus_strerror(int error)
 {
 	static char err[32];
@@ -89,424 +70,60 @@ out:
 	return err;
 }
 
-static void wait_data(int fd, bool write)
-{
-	struct pollfd pfd = { .fd = fd };
-
-	pfd.events = write ? POLLOUT : POLLIN;
-	poll(&pfd, 1, 0);
-}
-
-static int writev_retry(int fd, struct iovec *iov, int iov_len)
+static void
+ubus_queue_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr)
 {
-	int len = 0;
-
-	do {
-		int cur_len = writev(fd, iov, iov_len);
-		if (cur_len < 0) {
-			switch(errno) {
-			case EAGAIN:
-				wait_data(fd, true);
-				break;
-			case EINTR:
-				break;
-			default:
-				return -1;
-			}
-			continue;
-		}
-		len += cur_len;
-		while (cur_len >= iov->iov_len) {
-			cur_len -= iov->iov_len;
-			iov_len--;
-			iov++;
-			if (!cur_len || !iov_len)
-				return len;
-		}
-		iov->iov_len -= cur_len;
-	} while (1);
-}
-
-static int ubus_send_msg(struct ubus_context *ctx, uint32_t seq,
-			 struct blob_attr *msg, int cmd, uint32_t peer)
-{
-	struct ubus_msghdr hdr;
-	struct iovec iov[2] = {
-		STATIC_IOV(hdr)
-	};
-
-	hdr.version = 0;
-	hdr.type = cmd;
-	hdr.seq = seq;
-	hdr.peer = peer;
-
-	if (!msg) {
-		blob_buf_init(&b, 0);
-		msg = b.head;
-	}
-
-	iov[1].iov_base = (char *) msg;
-	iov[1].iov_len = blob_raw_len(msg);
-
-	return writev_retry(ctx->sock.fd, iov, ARRAY_SIZE(iov));
-}
-
-static int ubus_start_request(struct ubus_context *ctx, struct ubus_request *req,
-			      struct blob_attr *msg, int cmd, uint32_t peer)
-{
-	memset(req, 0, sizeof(*req));
-
-	if (msg && blob_pad_len(msg) > UBUS_MAX_MSGLEN)
-		return -1;
-
-	INIT_LIST_HEAD(&req->list);
-	INIT_LIST_HEAD(&req->pending);
-	req->ctx = ctx;
-	req->peer = peer;
-	req->seq = ++ctx->request_seq;
-	return ubus_send_msg(ctx, req->seq, msg, cmd, peer);
-}
-
-static bool recv_retry(int fd, struct iovec *iov, bool wait)
-{
-	int bytes;
-
-	while (iov->iov_len > 0) {
-		if (wait)
-			wait_data(fd, false);
-
-		bytes = read(fd, iov->iov_base, iov->iov_len);
-		if (bytes < 0) {
-			bytes = 0;
-			if (uloop_cancelled)
-				return false;
-			if (errno == EINTR)
-				continue;
-
-			if (errno != EAGAIN)
-				return false;
-		}
-		if (!wait && !bytes)
-			return false;
-
-		wait = true;
-		iov->iov_len -= bytes;
-		iov->iov_base += bytes;
-	}
-
-	return true;
-}
-
-static bool ubus_validate_hdr(struct ubus_msghdr *hdr)
-{
-	if (hdr->version != 0)
-		return false;
-
-	if (blob_raw_len(hdr->data) < sizeof(*hdr->data))
-		return false;
+	struct ubus_pending_msg *pending;
 
-	if (blob_pad_len(hdr->data) > UBUS_MAX_MSGLEN)
-		return false;
-
-	return true;
-}
-
-static bool get_next_msg(struct ubus_context *ctx)
-{
-	struct iovec iov = STATIC_IOV(ctx->msgbuf.hdr);
-
-	/* receive header + start attribute */
-	iov.iov_len += sizeof(struct blob_attr);
-	if (!recv_retry(ctx->sock.fd, &iov, false))
-		return false;
-
-	iov.iov_len = blob_len(ctx->msgbuf.hdr.data);
-	if (iov.iov_len > 0 && !recv_retry(ctx->sock.fd, &iov, true))
-		return false;
-
-	return ubus_validate_hdr(&ctx->msgbuf.hdr);
-}
-
-static bool ubus_get_status(struct ubus_msghdr *hdr, int *ret)
-{
-	ubus_parse_msg(hdr->data);
-
-	if (!attrbuf[UBUS_ATTR_STATUS])
-		return false;
-
-	*ret = blob_get_u32(attrbuf[UBUS_ATTR_STATUS]);
-	return true;
-}
-
-static void req_data_cb(struct ubus_request *req, int type, struct blob_attr *data)
-{
-	struct blob_attr **attr;
-
-	if (req->raw_data_cb)
-		req->raw_data_cb(req, type, data);
-
-	if (!req->data_cb)
+	pending = calloc(1, sizeof(*pending));
+	if (!pending)
 		return;
-
-	attr = ubus_parse_msg(data);
-	req->data_cb(req, type, attr[UBUS_ATTR_DATA]);
-}
-
-static void ubus_process_req_data(struct ubus_request *req)
-{
-	struct ubus_pending_data *data;
-
-	while (!list_empty(&req->pending)) {
-		data = list_first_entry(&req->pending,
-			struct ubus_pending_data, list);
-		list_del(&data->list);
-		if (!req->cancelled)
-			req_data_cb(req, data->type, data->data);
-		free(data);
-	}
-}
-
-static void ubus_req_complete_cb(struct ubus_request *req)
-{
-	ubus_complete_handler_t cb = req->complete_cb;
-
-	if (!cb)
+	pending->hdr.data = calloc(1, blob_raw_len(ubus_msghdr_data(hdr)));
+	if (!pending->hdr.data)
 		return;
 
-	req->complete_cb = NULL;
-	cb(req, req->status_code);
-}
-
-static int ubus_process_req_status(struct ubus_request *req, struct ubus_msghdr *hdr)
-{
-	int ret = UBUS_STATUS_INVALID_ARGUMENT;
-
-	if (!list_empty(&req->list))
-		list_del_init(&req->list);
-
-	ubus_get_status(hdr, &ret);
-	req->peer = hdr->peer;
-	req->status_msg = true;
-	req->status_code = ret;
-	if (!req->blocked)
-		ubus_req_complete_cb(req);
-
-	return ret;
-}
-
-static void ubus_req_data(struct ubus_request *req, struct ubus_msghdr *hdr)
-{
-	struct ubus_pending_data *data;
-	int len;
-
-	if (!req->blocked) {
-		req->blocked = true;
-		req_data_cb(req, hdr->type, hdr->data);
-		ubus_process_req_data(req);
-		req->blocked = false;
-
-		if (req->status_msg)
-			ubus_req_complete_cb(req);
-
-		return;
-	}
-
-	len = blob_raw_len(hdr->data);
-	data = calloc(1, sizeof(*data) + len);
-	if (!data)
-		return;
-
-	data->type = hdr->type;
-	memcpy(data->data, hdr->data, len);
-	list_add(&data->list, &req->pending);
-}
-
-static struct ubus_request *ubus_find_request(struct ubus_context *ctx, uint32_t seq, uint32_t peer)
-{
-	struct ubus_request *req;
-
-	list_for_each_entry(req, &ctx->requests, list) {
-		if (seq != req->seq || peer != req->peer)
-			continue;
-
-		return req;
-	}
-	return NULL;
-}
-
-static void ubus_process_invoke(struct ubus_context *ctx, struct ubus_msghdr *hdr)
-{
-	struct ubus_request_data req;
-	struct ubus_object *obj;
-	uint32_t objid = 0;
-	int method;
-	int ret = 0;
-
-	req.peer = hdr->peer;
-	req.seq = hdr->seq;
-	ubus_parse_msg(hdr->data);
-
-	if (!attrbuf[UBUS_ATTR_OBJID])
-		return;
-
-	objid = blob_get_u32(attrbuf[UBUS_ATTR_OBJID]);
-
-	if (!attrbuf[UBUS_ATTR_METHOD]) {
-		ret = UBUS_STATUS_INVALID_ARGUMENT;
-		goto send;
-	}
-
-	obj = avl_find_element(&ctx->objects, &objid, obj, avl);
-	if (!obj) {
-		ret = UBUS_STATUS_NOT_FOUND;
-		goto send;
-	}
-
-	for (method = 0; method < obj->n_methods; method++)
-		if (!obj->methods[method].name ||
-		    !strcmp(obj->methods[method].name,
-		            blob_data(attrbuf[UBUS_ATTR_METHOD])))
-			goto found;
-
-	/* not found */
-	ret = UBUS_STATUS_METHOD_NOT_FOUND;
-	goto send;
-
-found:
-	req.object = objid;
-	ret = obj->methods[method].handler(ctx, obj, &req,
-					   blob_data(attrbuf[UBUS_ATTR_METHOD]),
-					   attrbuf[UBUS_ATTR_DATA]);
-
-send:
-	blob_buf_init(&b, 0);
-	blob_put_int32(&b, UBUS_ATTR_STATUS, ret);
-	blob_put_int32(&b, UBUS_ATTR_OBJID, objid);
-	ubus_send_msg(ctx, req.seq, b.head, UBUS_MSG_STATUS, req.peer);
+	memcpy(&pending->hdr.hdr, hdr, sizeof(*hdr));
+	memcpy(pending->hdr.data, ubus_msghdr_data(hdr), blob_raw_len(ubus_msghdr_data(hdr)));
+	list_add(&pending->list, &ctx->pending);
+	if (ctx->sock.registered)
+		uloop_timeout_set(&ctx->pending_timer, 1);
 }
 
-static void ubus_process_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr)
+void __hidden
+ubus_process_msg(struct ubus_context *ctx, struct ubus_msghdr *hdr, int fd)
 {
-	struct ubus_request *req;
 
 	switch(hdr->type) {
 	case UBUS_MSG_STATUS:
-		req = ubus_find_request(ctx, hdr->seq, hdr->peer);
-		if (!req)
-			break;
-
-		ubus_process_req_status(req, hdr);
-		break;
-
 	case UBUS_MSG_DATA:
-		req = ubus_find_request(ctx, hdr->seq, hdr->peer);
-		if (req && (req->data_cb || req->raw_data_cb))
-			ubus_req_data(req, hdr);
+		ubus_process_req_msg(ctx, hdr, fd);
 		break;
 
 	case UBUS_MSG_INVOKE:
-		ubus_process_invoke(ctx, hdr);
-		break;
-	}
-}
-
-void ubus_abort_request(struct ubus_context *ctx, struct ubus_request *req)
-{
-	if (!list_empty(&req->list))
-		return;
-
-	req->cancelled = true;
-	ubus_process_req_data(req);
-	list_del_init(&req->list);
-}
-
-void ubus_complete_request_async(struct ubus_context *ctx, struct ubus_request *req)
-{
-	if (!list_empty(&req->list))
-		return;
-
-	list_add(&req->list, &ctx->requests);
-}
-
-static void ubus_handle_data(struct uloop_fd *u, unsigned int events)
-{
-	struct ubus_context *ctx = container_of(u, struct ubus_context, sock);
-	struct ubus_msghdr *hdr = &ctx->msgbuf.hdr;
-
-	while (get_next_msg(ctx)) {
-		ubus_process_msg(ctx, hdr);
-		if (uloop_cancelled)
+	case UBUS_MSG_UNSUBSCRIBE:
+	case UBUS_MSG_NOTIFY:
+		if (ctx->stack_depth) {
+			ubus_queue_msg(ctx, hdr);
 			break;
-	}
-
-	if (u->eof)
-		ctx->connection_lost(ctx);
-}
-
-static void ubus_sync_req_cb(struct ubus_request *req, int ret)
-{
-	req->status_msg = true;
-	req->status_code = ret;
-	uloop_end();
-}
-
-struct ubus_sync_req_cb {
-	struct uloop_timeout timeout;
-	struct ubus_request *req;
-};
-
-static void ubus_sync_req_timeout_cb(struct uloop_timeout *timeout)
-{
-	struct ubus_sync_req_cb *cb;
+		}
 
-	cb = container_of(timeout, struct ubus_sync_req_cb, timeout);
-	ubus_sync_req_cb(cb->req, UBUS_STATUS_TIMEOUT);
+		ubus_process_obj_msg(ctx, hdr);
+		break;
+	}
 }
 
-int ubus_complete_request(struct ubus_context *ctx, struct ubus_request *req,
-			  int timeout)
+static void ubus_process_pending_msg(struct uloop_timeout *timeout)
 {
-	struct ubus_sync_req_cb cb;
-	ubus_complete_handler_t complete_cb = req->complete_cb;
-	bool registered = ctx->sock.registered;
-	int status = UBUS_STATUS_NO_DATA;
-
-	if (!registered) {
-		uloop_init();
-		ubus_add_uloop(ctx);
-	}
+	struct ubus_context *ctx = container_of(timeout, struct ubus_context, pending_timer);
+	struct ubus_pending_msg *pending;
 
-	if (timeout) {
-		memset(&cb, 0, sizeof(cb));
-		cb.req = req;
-		cb.timeout.cb = ubus_sync_req_timeout_cb;
-		uloop_timeout_set(&cb.timeout, timeout);
+	while (!ctx->stack_depth && !list_empty(&ctx->pending)) {
+		pending = list_first_entry(&ctx->pending, struct ubus_pending_msg, list);
+		list_del(&pending->list);
+		ubus_process_msg(ctx, &pending->hdr.hdr, -1);
+		free(pending->hdr.data);
+		free(pending);
 	}
-
-	ubus_complete_request_async(ctx, req);
-	req->complete_cb = ubus_sync_req_cb;
-
-	while (!req->status_msg) {
-		bool cancelled = uloop_cancelled;
-		uloop_cancelled = false;
-		uloop_run();
-		uloop_cancelled = cancelled;
-	}
-
-	if (timeout)
-		uloop_timeout_cancel(&cb.timeout);
-
-	if (req->status_msg)
-		status = req->status_code;
-
-	req->complete_cb = complete_cb;
-	if (req->complete_cb)
-		req->complete_cb(req, status);
-
-	if (!registered)
-		uloop_fd_delete(&ctx->sock);
-
-	return status;
 }
 
 struct ubus_lookup_request {
@@ -583,173 +200,6 @@ int ubus_lookup_id(struct ubus_context *ctx, const char *path, uint32_t *id)
 	return ubus_complete_request(ctx, &req, 0);
 }
 
-int ubus_send_reply(struct ubus_context *ctx, struct ubus_request_data *req,
-		    struct blob_attr *msg)
-{
-	int ret;
-
-	blob_buf_init(&b, 0);
-	blob_put_int32(&b, UBUS_ATTR_OBJID, req->object);
-	blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
-	ret = ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_DATA, req->peer);
-	if (ret < 0)
-		return UBUS_STATUS_NO_DATA;
-
-	return 0;
-}
-
-int ubus_invoke_async(struct ubus_context *ctx, uint32_t obj, const char *method,
-                       struct blob_attr *msg, struct ubus_request *req)
-{
-	blob_buf_init(&b, 0);
-	blob_put_int32(&b, UBUS_ATTR_OBJID, obj);
-	blob_put_string(&b, UBUS_ATTR_METHOD, method);
-	if (msg)
-		blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
-
-	if (ubus_start_request(ctx, req, b.head, UBUS_MSG_INVOKE, obj) < 0)
-		return UBUS_STATUS_INVALID_ARGUMENT;
-
-	return 0;
-}
-
-int ubus_invoke(struct ubus_context *ctx, uint32_t obj, const char *method,
-                struct blob_attr *msg, ubus_data_handler_t cb, void *priv,
-		int timeout)
-{
-	struct ubus_request req;
-
-	ubus_invoke_async(ctx, obj, method, msg, &req);
-	req.data_cb = cb;
-	req.priv = priv;
-	return ubus_complete_request(ctx, &req, timeout);
-}
-
-static void ubus_add_object_cb(struct ubus_request *req, int type, struct blob_attr *msg)
-{
-	struct ubus_object *obj = req->priv;
-
-	ubus_parse_msg(msg);
-
-	if (!attrbuf[UBUS_ATTR_OBJID])
-		return;
-
-	obj->id = blob_get_u32(attrbuf[UBUS_ATTR_OBJID]);
-
-	if (attrbuf[UBUS_ATTR_OBJTYPE])
-		obj->type->id = blob_get_u32(attrbuf[UBUS_ATTR_OBJTYPE]);
-
-	obj->avl.key = &obj->id;
-	avl_insert(&req->ctx->objects, &obj->avl);
-}
-
-static void ubus_push_method_data(const struct ubus_method *m)
-{
-	void *mtbl;
-	int i;
-
-	mtbl = blobmsg_open_table(&b, m->name);
-
-	for (i = 0; i < m->n_policy; i++)
-		blobmsg_add_u32(&b, m->policy[i].name, m->policy[i].type);
-
-	blobmsg_close_table(&b, mtbl);
-}
-
-static bool ubus_push_object_type(const struct ubus_object_type *type)
-{
-	void *s;
-	int i;
-
-	s = blob_nest_start(&b, UBUS_ATTR_SIGNATURE);
-
-	for (i = 0; i < type->n_methods; i++)
-		ubus_push_method_data(&type->methods[i]);
-
-	blob_nest_end(&b, s);
-
-	return true;
-}
-
-static int __ubus_add_object(struct ubus_context *ctx, struct ubus_object *obj)
-{
-	struct ubus_request req;
-	int ret;
-
-	blob_buf_init(&b, 0);
-
-	if (obj->name && obj->type) {
-		blob_put_string(&b, UBUS_ATTR_OBJPATH, obj->name);
-
-		if (obj->type->id)
-			blob_put_int32(&b, UBUS_ATTR_OBJTYPE, obj->type->id);
-		else if (!ubus_push_object_type(obj->type))
-			return UBUS_STATUS_INVALID_ARGUMENT;
-	}
-
-	if (ubus_start_request(ctx, &req, b.head, UBUS_MSG_ADD_OBJECT, 0) < 0)
-		return UBUS_STATUS_INVALID_ARGUMENT;
-
-	req.raw_data_cb = ubus_add_object_cb;
-	req.priv = obj;
-	ret = ubus_complete_request(ctx, &req, 0);
-	if (ret)
-		return ret;
-
-	if (!obj->id)
-		return UBUS_STATUS_NO_DATA;
-
-	return 0;
-}
-
-int ubus_add_object(struct ubus_context *ctx, struct ubus_object *obj)
-{
-	if (!obj->name || !obj->type)
-		return UBUS_STATUS_INVALID_ARGUMENT;
-
-	return __ubus_add_object(ctx, obj);
-}
-
-static void ubus_remove_object_cb(struct ubus_request *req, int type, struct blob_attr *msg)
-{
-	struct ubus_object *obj = req->priv;
-
-	ubus_parse_msg(msg);
-
-	if (!attrbuf[UBUS_ATTR_OBJID])
-		return;
-
-	obj->id = 0;
-
-	if (attrbuf[UBUS_ATTR_OBJTYPE] && obj->type)
-		obj->type->id = 0;
-
-	avl_delete(&req->ctx->objects, &obj->avl);
-}
-
-int ubus_remove_object(struct ubus_context *ctx, struct ubus_object *obj)
-{
-	struct ubus_request req;
-	int ret;
-
-	blob_buf_init(&b, 0);
-	blob_put_int32(&b, UBUS_ATTR_OBJID, obj->id);
-
-	if (ubus_start_request(ctx, &req, b.head, UBUS_MSG_REMOVE_OBJECT, 0) < 0)
-		return UBUS_STATUS_INVALID_ARGUMENT;
-
-	req.raw_data_cb = ubus_remove_object_cb;
-	req.priv = obj;
-	ret = ubus_complete_request(ctx, &req, 0);
-	if (ret)
-		return ret;
-
-	if (obj->id)
-		return UBUS_STATUS_NO_DATA;
-
-	return 0;
-}
-
 static int ubus_event_cb(struct ubus_context *ctx, struct ubus_object *obj,
 			 struct ubus_request_data *req,
 			 const char *method, struct blob_attr *msg)
@@ -781,7 +231,7 @@ int ubus_register_event_handler(struct ubus_context *ctx,
 		if (!!obj->name ^ !!obj->type)
 			return UBUS_STATUS_INVALID_ARGUMENT;
 
-		ret = __ubus_add_object(ctx, obj);
+		ret = ubus_add_object(ctx, obj);
 		if (ret)
 			return ret;
 	}
@@ -793,8 +243,11 @@ int ubus_register_event_handler(struct ubus_context *ctx,
 	if (pattern)
 		blobmsg_add_string(&b2, "pattern", pattern);
 
-	return ubus_invoke(ctx, UBUS_SYSTEM_OBJECT_EVENT, "register", b2.head,
+	ret = ubus_invoke(ctx, UBUS_SYSTEM_OBJECT_EVENT, "register", b2.head,
 			  NULL, NULL, 0);
+	blob_buf_free(&b2);
+
+	return ret;
 }
 
 int ubus_send_event(struct ubus_context *ctx, const char *id,
@@ -823,72 +276,88 @@ static void ubus_default_connection_lost(struct ubus_context *ctx)
 		uloop_end();
 }
 
-struct ubus_context *ubus_connect(const char *path)
+static int _ubus_connect(struct ubus_context *ctx, const char *path)
 {
-	struct ubus_context *ctx;
-	struct {
-		struct ubus_msghdr hdr;
-		struct blob_attr data;
-	} hdr;
-	struct blob_attr *buf;
-
-	if (!path)
-		path = UBUS_UNIX_SOCKET;
+	ctx->sock.fd = -1;
+	ctx->sock.cb = ubus_handle_data;
+	ctx->connection_lost = ubus_default_connection_lost;
+	ctx->pending_timer.cb = ubus_process_pending_msg;
 
-	ctx = calloc(1, sizeof(*ctx));
-	if (!ctx)
-		goto error;
+	ctx->msgbuf.data = calloc(UBUS_MSG_CHUNK_SIZE, sizeof(char));
+	if (!ctx->msgbuf.data)
+		return -1;
+	ctx->msgbuf_data_len = UBUS_MSG_CHUNK_SIZE;
 
-	ctx->sock.fd = usock(USOCK_UNIX, path, NULL);
-	if (ctx->sock.fd < 0)
-		goto error_free;
+	INIT_LIST_HEAD(&ctx->requests);
+	INIT_LIST_HEAD(&ctx->pending);
+	avl_init(&ctx->objects, ubus_cmp_id, false, NULL);
+	if (ubus_reconnect(ctx, path)) {
+		free(ctx->msgbuf.data);
+		return -1;
+	}
 
-	ctx->sock.cb = ubus_handle_data;
+	return 0;
+}
 
-	if (read(ctx->sock.fd, &hdr, sizeof(hdr)) != sizeof(hdr))
-		goto error_close;
+static void ubus_auto_reconnect_cb(struct uloop_timeout *timeout)
+{
+	struct ubus_auto_conn *conn = container_of(timeout, struct ubus_auto_conn, timer);
 
-	if (!ubus_validate_hdr(&hdr.hdr))
-		goto error_close;
+	if (!ubus_reconnect(&conn->ctx, conn->path))
+		ubus_add_uloop(&conn->ctx);
+	else
+		uloop_timeout_set(timeout, 1000);
+}
 
-	if (hdr.hdr.type != UBUS_MSG_HELLO)
-		goto error_close;
+static void ubus_auto_disconnect_cb(struct ubus_context *ctx)
+{
+	struct ubus_auto_conn *conn = container_of(ctx, struct ubus_auto_conn, ctx);
 
-	buf = calloc(1, blob_raw_len(&hdr.data));
-	if (!buf)
-		goto error_close;
+	conn->timer.cb = ubus_auto_reconnect_cb;
+	uloop_timeout_set(&conn->timer, 1000);
+}
 
-	memcpy(buf, &hdr.data, sizeof(hdr.data));
-	if (read(ctx->sock.fd, blob_data(buf), blob_len(buf)) != blob_len(buf))
-		goto error_free_buf;
+static void ubus_auto_connect_cb(struct uloop_timeout *timeout)
+{
+	struct ubus_auto_conn *conn = container_of(timeout, struct ubus_auto_conn, timer);
 
-	ctx->local_id = hdr.hdr.peer;
-	free(buf);
+	if (_ubus_connect(&conn->ctx, conn->path)) {
+		uloop_timeout_set(timeout, 1000);
+		fprintf(stderr, "failed to connect to ubus\n");
+		return;
+	}
+	conn->ctx.connection_lost = ubus_auto_disconnect_cb;
+	if (conn->cb)
+		conn->cb(&conn->ctx);
+	ubus_add_uloop(&conn->ctx);
+}
 
-	ctx->connection_lost = ubus_default_connection_lost;
+void ubus_auto_connect(struct ubus_auto_conn *conn)
+{
+	conn->timer.cb = ubus_auto_connect_cb;
+	ubus_auto_connect_cb(&conn->timer);
+}
 
-	INIT_LIST_HEAD(&ctx->requests);
-	avl_init(&ctx->objects, ubus_cmp_id, false, NULL);
+struct ubus_context *ubus_connect(const char *path)
+{
+	struct ubus_context *ctx;
 
-	if (!ctx->local_id)
-		goto error_close;
+	ctx = calloc(1, sizeof(*ctx));
+	if (!ctx)
+		return NULL;
 
-	fcntl(ctx->sock.fd, F_SETFL, fcntl(ctx->sock.fd, F_GETFL) | O_NONBLOCK);
+	if (_ubus_connect(ctx, path)) {
+		free(ctx);
+		ctx = NULL;
+	}
 
 	return ctx;
-
-error_free_buf:
-	free(buf);
-error_close:
-	close(ctx->sock.fd);
-error_free:
-	free(ctx);
-error:
-	return NULL;
 }
 
 void ubus_free(struct ubus_context *ctx)
 {
+	blob_buf_free(&b);
 	close(ctx->sock.fd);
+	free(ctx->msgbuf.data);
 	free(ctx);
 }