ubus: Fix issues reported by static code analysis tool Klocwork

[project/ubus.git] / lua / ubus.c

diff --git a/lua/ubus.c b/lua/ubus.c
index 0f2338c..362f932 100644 (file)
--- a/lua/ubus.c
+++ b/lua/ubus.c
@@ -285,6 +285,7 @@ ubus_method_handler(struct ubus_context *ctx, struct ubus_object *obj,
                struct blob_attr *msg)
 {
        struct ubus_lua_object *o = container_of(obj, struct ubus_lua_object, o);
+       int rv = 0;
 
        lua_getglobal(state, "__ubus_cb");
        lua_rawgeti(state, -1, o->r);
@@ -298,11 +299,13 @@ ubus_method_handler(struct ubus_context *ctx, struct ubus_object *obj,
                        lua_pushnil(state);
                else
                        ubus_lua_parse_blob_array(state, blob_data(msg), blob_len(msg), true);
-               lua_call(state, 2, 0);
+               lua_call(state, 2, 1);
+               if (lua_isnumber(state, -1))
+                       rv = lua_tonumber(state, -1);
        } else
                lua_pop(state, 1);
 
-       return 0;
+       return rv;
 }
 
 static int lua_gettablelen(lua_State *L, int index)
@@ -379,6 +382,9 @@ static int ubus_lua_load_methods(lua_State *L, struct ubus_method *m)
 
        /* setup the policy pointers */
        p = malloc(sizeof(struct blobmsg_policy) * plen);
+       if (!p)
+               return 1;
+
        memset(p, 0, sizeof(struct blobmsg_policy) * plen);
        m->policy = p;
        lua_pushnil(L);
@@ -414,6 +420,9 @@ static struct ubus_object* ubus_lua_load_object(lua_State *L)
 
        /* setup object pointers */
        obj = malloc(sizeof(struct ubus_lua_object));
+       if (!obj)
+               return NULL;
+
        memset(obj, 0, sizeof(struct ubus_lua_object));
        obj->o.name = lua_tostring(L, -2);
 
@@ -424,6 +433,11 @@ static struct ubus_object* ubus_lua_load_object(lua_State *L)
 
        /* setup type pointers */
        obj->o.type = malloc(sizeof(struct ubus_object_type));
+       if (!obj->o.type) {
+               free(obj);
+               return NULL;
+       }
+
        memset(obj->o.type, 0, sizeof(struct ubus_object_type));
        obj->o.type->name = lua_tostring(L, -2);
        obj->o.type->id = 0;
@@ -526,10 +540,11 @@ ubus_lua_call_cb(struct ubus_request *req, int type, struct blob_attr *msg)
 {
        lua_State *L = (lua_State *)req->priv;
 
-       if (!msg)
+       if (!msg && L)
                lua_pushnil(L);
 
-       ubus_lua_parse_blob_array(L, blob_data(msg), blob_len(msg), true);
+       if (msg && L)
+               ubus_lua_parse_blob_array(L, blob_data(msg), blob_len(msg), true);
 }
 
 static int
@@ -595,6 +610,9 @@ ubus_lua_load_event(lua_State *L)
        struct ubus_lua_event* event = NULL;
 
        event = malloc(sizeof(struct ubus_lua_event));
+       if (!event)
+               return NULL;
+
        memset(event, 0, sizeof(struct ubus_lua_event));
        event->e.cb = ubus_event_handler;