ubus: Fix issues reported by static code analysis tool Klocwork

[project/ubus.git] / examples / client.c

diff --git a/examples/client.c b/examples/client.c
index 75c61a4..952ab54 100644 (file)
--- a/examples/client.c
+++ b/examples/client.c
@@ -11,9 +11,13 @@
  * GNU General Public License for more details.
  */
 
+#include <sys/time.h>
 #include <unistd.h>
 
+#include <libubox/ustream.h>
+
 #include "libubus.h"
+#include "count.h"
 
 static struct ubus_context *ctx;
 static struct blob_buf b;
@@ -31,23 +35,144 @@ static void test_client_notify_cb(struct uloop_timeout *timeout)
 {
        static int counter = 0;
        int err;
+       struct timeval tv1, tv2;
+       int max = 1000;
+       long delta;
+       int i = 0;
 
        blob_buf_init(&b, 0);
        blobmsg_add_u32(&b, "counter", counter++);
 
-       err = ubus_notify(ctx, &test_client_object, "ping", b.head, 1000);
+       gettimeofday(&tv1, NULL);
+       for (i = 0; i < max; i++)
+               err = ubus_notify(ctx, &test_client_object, "ping", b.head, 1000);
+       gettimeofday(&tv2, NULL);
        if (err)
                fprintf(stderr, "Notify failed: %s\n", ubus_strerror(err));
 
+       delta = (tv2.tv_sec - tv1.tv_sec) * 1000000 + (tv2.tv_usec - tv1.tv_usec);
+       fprintf(stderr, "Avg time per iteration: %ld usec\n", delta / max);
+
        uloop_timeout_set(timeout, 1000);
 }
 
+enum {
+       RETURN_CODE,
+       __RETURN_MAX,
+};
+
+static const struct blobmsg_policy return_policy[__RETURN_MAX] = {
+       [RETURN_CODE] = { .name = "rc", .type = BLOBMSG_TYPE_INT32 },
+};
+
+static void test_count_data_cb(struct ubus_request *req,
+                                   int type, struct blob_attr *msg)
+{
+       struct blob_attr *tb[__RETURN_MAX];
+       int rc;
+       uint32_t count_to = *(uint32_t *)req->priv;
+
+       blobmsg_parse(return_policy, __RETURN_MAX, tb, blob_data(msg), blob_len(msg));
+
+       if (!tb[RETURN_CODE]) {
+               fprintf(stderr, "No return code received from server\n");
+               return;
+       }
+       rc = blobmsg_get_u32(tb[RETURN_CODE]);
+       if (rc)
+               fprintf(stderr, "Corruption of data with count up to '%u'\n", count_to);
+       else
+               fprintf(stderr, "Server validated our count up to '%u'\n", count_to);
+}
+
+static void test_count(struct uloop_timeout *timeout)
+{
+       enum {
+               COUNT_TO_MIN = 10000,
+               COUNT_TO_MAX = 1000000,
+               PROGRESSION  = 100,
+       };
+
+       uint32_t id;
+       static uint32_t count_to = 100000;
+       static int count_progression = PROGRESSION;
+       char *s;
+
+       if (count_to <= COUNT_TO_MIN)
+               count_progression = PROGRESSION;
+       else if (count_to >= COUNT_TO_MAX)
+               count_progression = -PROGRESSION;
+
+       count_to += count_progression;
+
+       s = count_to_number(count_to);
+       if (!s) {
+               fprintf(stderr, "Could not allocate memory to count up to '%u'\n", count_to);
+               return;
+       }
+
+       fprintf(stderr, "Sending count up to '%u'; string has length '%u'\n",
+               count_to, (uint32_t)strlen(s));
+       blob_buf_init(&b, 0);
+       blobmsg_add_u32(&b, "to", count_to);
+       blobmsg_add_string(&b, "string", s);
+
+       if (ubus_lookup_id(ctx, "test", &id)) {
+               fprintf(stderr, "Failed to look up test object\n");
+               return;
+       }
+
+       ubus_invoke(ctx, id, "count", b.head, test_count_data_cb, &count_to, 5000);
+
+       free(s);
+
+       uloop_timeout_set(timeout, 2000);
+}
+
 static struct uloop_timeout notify_timer = {
        .cb = test_client_notify_cb,
 };
 
+static struct uloop_timeout count_timer = {
+       .cb = test_count,
+};
+
+static void test_client_fd_data_cb(struct ustream *s, int bytes)
+{
+       char *data, *sep;
+       int len;
+
+       data = ustream_get_read_buf(s, &len);
+       if (len < 1)
+               return;
+
+       sep = strchr(data, '\n');
+       if (!sep)
+               return;
+
+       *sep = 0;
+       fprintf(stderr, "Got line: %s\n", data);
+       ustream_consume(s, sep + 1 - data);
+}
+
+static void test_client_fd_cb(struct ubus_request *req, int fd)
+{
+       static struct ustream_fd test_fd;
+
+       fprintf(stderr, "Got fd from the server, watching...\n");
+
+       test_fd.stream.notify_read = test_client_fd_data_cb;
+       ustream_fd_init(&test_fd, fd);
+}
+
+static void test_client_complete_cb(struct ubus_request *req, int ret)
+{
+       fprintf(stderr, "completed request, ret: %d\n", ret);
+}
+
 static void client_main(void)
 {
+       static struct ubus_request req;
        uint32_t id;
        int ret;
 
@@ -66,6 +191,16 @@ static void client_main(void)
        blobmsg_add_u32(&b, "id", test_client_object.id);
        ubus_invoke(ctx, id, "watch", b.head, NULL, 0, 3000);
        test_client_notify_cb(&notify_timer);
+
+       blob_buf_init(&b, 0);
+       blobmsg_add_string(&b, "msg", "blah");
+       ubus_invoke_async(ctx, id, "hello", b.head, &req);
+       req.fd_cb = test_client_fd_cb;
+       req.complete_cb = test_client_complete_cb;
+       ubus_complete_request_async(ctx, &req);
+
+       uloop_timeout_set(&count_timer, 2000);
+
        uloop_run();
 }