X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fubox.git;a=blobdiff_plain;f=log%2Flogread.c;h=28c9462904e69e07ae1649fa6ae9658567d320b6;hp=8c9fda8ec06c42d369d54264519f585aac7c9710;hb=06cbdf5bed92313498ea9a21a747777a2907f897;hpb=0c6d5bd1fc1fd28c71290610faeee11b399c869a diff --git a/log/logread.c b/log/logread.c index 8c9fda8..28c9462 100644 --- a/log/logread.c +++ b/log/logread.c @@ -25,6 +25,7 @@ #define SYSLOG_NAMES #include +#include #include #include #include @@ -54,12 +55,11 @@ static const struct blobmsg_policy log_policy[] = { [LOG_TIME] = { .name = "time", .type = BLOBMSG_TYPE_INT64 }, }; -static struct ubus_subscriber log_event; static struct uloop_timeout retry; static struct uloop_fd sender; static const char *log_file, *log_ip, *log_port, *log_prefix, *pid_file, *hostname; static int log_type = LOG_STDOUT; -static int log_size, log_udp; +static int log_size, log_udp, log_follow = 0; static const char* getcodetext(int value, CODE *codetable) { CODE *i; @@ -83,12 +83,6 @@ static void log_handle_reconnect(struct uloop_timeout *timeout) } } -static void log_handle_remove(struct ubus_context *ctx, struct ubus_subscriber *s, - uint32_t id) -{ - fprintf(stderr, "Object %08x went away\n", id); -} - static void log_handle_fd(struct uloop_fd *u, unsigned int events) { if (u->eof) { @@ -99,9 +93,7 @@ static void log_handle_fd(struct uloop_fd *u, unsigned int events) } } -static int log_notify(struct ubus_context *ctx, struct ubus_object *obj, - struct ubus_request_data *req, const char *method, - struct blob_attr *msg) +static int log_notify(struct blob_attr *msg) { struct blob_attr *tb[__LOG_MAX]; struct stat s; @@ -109,13 +101,13 @@ static int log_notify(struct ubus_context *ctx, struct ubus_object *obj, uint32_t p; char *str; time_t t; - char *c; + char *c, *m; if (sender.fd < 0) return 0; blobmsg_parse(log_policy, ARRAY_SIZE(log_policy), tb, blob_data(msg), blob_len(msg)); - if (!tb[LOG_ID] || !tb[LOG_PRIO] || !tb[LOG_SOURCE] || !tb[LOG_TIME]) + if (!tb[LOG_ID] || !tb[LOG_PRIO] || !tb[LOG_SOURCE] || !tb[LOG_TIME] || !tb[LOG_MSG]) return 1; if ((log_type == LOG_FILE) && log_size && (!stat(log_file, &s)) && (s.st_size > log_size)) { @@ -129,11 +121,12 @@ static int log_notify(struct ubus_context *ctx, struct ubus_object *obj, } sender.fd = open(log_file, O_CREAT | O_WRONLY | O_APPEND, 0600); if (sender.fd < 0) { -// fprintf(stderr, "failed to open %s: %s\n", log_file, strerror(errno)); + fprintf(stderr, "failed to open %s: %s\n", log_file, strerror(errno)); exit(-1); } } + m = blobmsg_get_string(tb[LOG_MSG]); t = blobmsg_get_u64(tb[LOG_TIME]) / 1000; c = ctime(&t); p = blobmsg_get_u32(tb[LOG_PRIO]); @@ -151,7 +144,7 @@ static int log_notify(struct ubus_context *ctx, struct ubus_object *obj, } if (blobmsg_get_u32(tb[LOG_SOURCE]) == SOURCE_KLOG) strncat(buf, "kernel: ", sizeof(buf)); - strncat(buf, method, sizeof(buf)); + strncat(buf, m, sizeof(buf)); if (log_udp) err = write(sender.fd, buf, strlen(buf)); else @@ -168,8 +161,7 @@ static int log_notify(struct ubus_context *ctx, struct ubus_object *obj, } else { snprintf(buf, sizeof(buf), "%s %s.%s%s %s\n", c, getcodetext(LOG_FAC(p) << 3, facilitynames), getcodetext(LOG_PRI(p), prioritynames), - (blobmsg_get_u32(tb[LOG_SOURCE])) ? ("") : (" kernel:"), - method); + (blobmsg_get_u32(tb[LOG_SOURCE])) ? ("") : (" kernel:"), m); write(sender.fd, buf, strlen(buf)); } @@ -180,104 +172,6 @@ static int log_notify(struct ubus_context *ctx, struct ubus_object *obj, return 0; } -static void follow_log(struct ubus_context *ctx, int id) -{ - FILE *fp; - int ret; - - signal(SIGPIPE, SIG_IGN); - - if (pid_file) { - fp = fopen(pid_file, "w+"); - if (fp) { - fprintf(fp, "%d", getpid()); - fclose(fp); - } - } - - uloop_init(); - ubus_add_uloop(ctx); - - log_event.remove_cb = log_handle_remove; - log_event.cb = log_notify; - ret = ubus_register_subscriber(ctx, &log_event); - if (ret) - fprintf(stderr, "Failed to add watch handler: %s\n", ubus_strerror(ret)); - - ret = ubus_subscribe(ctx, &log_event, id); - if (ret) - fprintf(stderr, "Failed to add watch handler: %s\n", ubus_strerror(ret)); - - if (log_ip && log_port) { - openlog("logread", LOG_PID, LOG_DAEMON); - log_type = LOG_NET; - sender.cb = log_handle_fd; - retry.cb = log_handle_reconnect; - uloop_timeout_set(&retry, 1000); - } else if (log_file) { - log_type = LOG_FILE; - sender.fd = open(log_file, O_CREAT | O_WRONLY| O_APPEND, 0600); - if (sender.fd < 0) { - fprintf(stderr, "failed to open %s: %s\n", log_file, strerror(errno)); - exit(-1); - } - } else { - sender.fd = STDOUT_FILENO; - } - - uloop_run(); - ubus_free(ctx); - uloop_done(); -} - -enum { - READ_LINE, - __READ_MAX -}; - - - -static const struct blobmsg_policy read_policy[] = { - [READ_LINE] = { .name = "lines", .type = BLOBMSG_TYPE_ARRAY }, -}; - -static void read_cb(struct ubus_request *req, int type, struct blob_attr *msg) -{ - struct blob_attr *cur; - struct blob_attr *_tb[__READ_MAX]; - time_t t; - int rem; - - if (!msg) - return; - - blobmsg_parse(read_policy, ARRAY_SIZE(read_policy), _tb, blob_data(msg), blob_len(msg)); - if (!_tb[READ_LINE]) - return; - blobmsg_for_each_attr(cur, _tb[READ_LINE], rem) { - struct blob_attr *tb[__LOG_MAX]; - uint32_t p; - char *c; - - if (blobmsg_type(cur) != BLOBMSG_TYPE_TABLE) - continue; - - blobmsg_parse(log_policy, ARRAY_SIZE(log_policy), tb, blobmsg_data(cur), blobmsg_data_len(cur)); - if (!tb[LOG_MSG] || !tb[LOG_ID] || !tb[LOG_PRIO] || !tb[LOG_SOURCE] || !tb[LOG_TIME]) - continue; - - t = blobmsg_get_u64(tb[LOG_TIME]); - p = blobmsg_get_u32(tb[LOG_PRIO]); - c = ctime(&t); - c[strlen(c) - 1] = '\0'; - - printf("%s %s.%s%s %s\n", - c, getcodetext(LOG_FAC(p) << 3, facilitynames), getcodetext(LOG_PRI(p), prioritynames), - (blobmsg_get_u32(tb[LOG_SOURCE])) ? ("") : (" kernel:"), - blobmsg_get_string(tb[LOG_MSG])); - } -} - static int usage(const char *prog) { fprintf(stderr, "Usage: %s [options]\n" @@ -296,14 +190,45 @@ static int usage(const char *prog) return 1; } +static void logread_fd_data_cb(struct ustream *s, int bytes) +{ + while (true) { + int len; + struct blob_attr *a; + + a = (void*) ustream_get_read_buf(s, &len); + if (len < sizeof(*a) || len < blob_len(a) + sizeof(*a)) + break; + log_notify(a); + ustream_consume(s, blob_len(a) + sizeof(*a)); + } + if (!log_follow) + uloop_end(); +} + +static void logread_fd_cb(struct ubus_request *req, int fd) +{ + static struct ustream_fd test_fd; + + test_fd.stream.notify_read = logread_fd_data_cb; + ustream_fd_init(&test_fd, fd); +} + +static void logread_complete_cb(struct ubus_request *req, int ret) +{ +} + int main(int argc, char **argv) { + static struct ubus_request req; struct ubus_context *ctx; uint32_t id; const char *ubus_socket = NULL; - int ch, ret, subscribe = 0, lines = 0; + int ch, ret, lines = 0; static struct blob_buf b; - int retry = 5; + int tries = 5; + + signal(SIGPIPE, SIG_IGN); while ((ch = getopt(argc, argv, "ufcs:l:r:F:p:S:P:h:")) != -1) { switch (ch) { @@ -327,7 +252,7 @@ int main(int argc, char **argv) log_prefix = optarg; break; case 'f': - subscribe = 1; + log_follow = 1; break; case 'l': lines = atoi(optarg); @@ -345,12 +270,14 @@ int main(int argc, char **argv) return usage(*argv); } } + uloop_init(); ctx = ubus_connect(ubus_socket); if (!ctx) { fprintf(stderr, "Failed to connect to ubus\n"); return -1; } + ubus_add_uloop(ctx); /* ugly ugly ugly ... we need a real reconnect logic */ do { @@ -360,16 +287,49 @@ int main(int argc, char **argv) sleep(1); continue; } - if (!subscribe || lines) { - blob_buf_init(&b, 0); - if (lines) - blobmsg_add_u32(&b, "lines", lines); - ubus_invoke(ctx, id, "read", b.head, read_cb, 0, 3000); + + blob_buf_init(&b, 0); + if (lines) + blobmsg_add_u32(&b, "lines", lines); + else if (log_follow) + blobmsg_add_u32(&b, "lines", 0); + if (log_follow) { + if (pid_file) { + FILE *fp = fopen(pid_file, "w+"); + if (fp) { + fprintf(fp, "%d", getpid()); + fclose(fp); + } + } + } + + if (log_ip && log_port) { + openlog("logread", LOG_PID, LOG_DAEMON); + log_type = LOG_NET; + sender.cb = log_handle_fd; + retry.cb = log_handle_reconnect; + uloop_timeout_set(&retry, 1000); + } else if (log_file) { + log_type = LOG_FILE; + sender.fd = open(log_file, O_CREAT | O_WRONLY| O_APPEND, 0600); + if (sender.fd < 0) { + fprintf(stderr, "failed to open %s: %s\n", log_file, strerror(errno)); + exit(-1); + } + } else { + sender.fd = STDOUT_FILENO; } - if (subscribe) - follow_log(ctx, id); - } while (ret && retry--); + ubus_invoke_async(ctx, id, "read", b.head, &req); + req.fd_cb = logread_fd_cb; + req.complete_cb = logread_complete_cb; + ubus_complete_request_async(ctx, &req); - return 0; + uloop_run(); + ubus_free(ctx); + uloop_done(); + + } while (ret && tries--); + + return ret; }