X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fubox.git;a=blobdiff_plain;f=kmodloader.c;h=c780379ed47f4349a2bc0c96d3bd9481943ea79f;hp=4300bafc3314bcf65805dceb3b18d17a3b0cc197;hb=9371411715c8dd882f1d65a712f1f38b6d38d01f;hpb=31f0ff358b360ee461d845c1b3b5e5d38fa27925 diff --git a/kmodloader.c b/kmodloader.c index 4300baf..c780379 100644 --- a/kmodloader.c +++ b/kmodloader.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include #include @@ -35,22 +34,10 @@ #include #include #include +#include #define DEF_MOD_PATH "/modules/%s/" -#define INFO(fmt, ...) do { \ - syslog(LOG_INFO, fmt, ## __VA_ARGS__); \ - printf("kmod: "fmt, ## __VA_ARGS__); \ - } while (0) -#define ERROR(fmt, ...) do { \ - syslog(LOG_ERR, fmt, ## __VA_ARGS__); \ - fprintf(stderr,"kmod: "fmt, ## __VA_ARGS__); \ - } while (0) -#define DEBUG(fmt, ...) do { \ - syslog(LOG_DEBUG, fmt, ## __VA_ARGS__); \ - } while (0) - - enum { SCANNED, PROBE, @@ -216,7 +203,7 @@ static int elf_find_section(char *map, const char *section, unsigned int *offset else if (clazz == ELFCLASS64) return elf64_find_section(map, section, offset, size); - ERROR("unknown elf format %d\n", clazz); + ULOG_ERR("unknown elf format %d\n", clazz); return -1; } @@ -259,7 +246,7 @@ static int scan_loaded_modules(void) fp = fopen("/proc/modules", "r"); if (!fp) { - ERROR("failed to open /proc/modules\n"); + ULOG_ERR("failed to open /proc/modules\n"); return -1; } @@ -289,38 +276,40 @@ static struct module* get_module_info(const char *module, const char *name) { int fd = open(module, O_RDONLY); unsigned int offset, size; - char *map, *strings, *dep = NULL; - struct module *m; + char *map = MAP_FAILED, *strings, *dep = NULL; + struct module *m = NULL; struct stat s; - if (!fd) { - ERROR("failed to open %s\n", module); - return NULL; + if (fd < 0) { + ULOG_ERR("failed to open %s\n", module); + goto out; } if (fstat(fd, &s) == -1) { - ERROR("failed to stat %s\n", module); - return NULL; + ULOG_ERR("failed to stat %s\n", module); + goto out; } map = mmap(NULL, s.st_size, PROT_READ, MAP_PRIVATE, fd, 0); if (map == MAP_FAILED) { - ERROR("failed to mmap %s\n", module); - return NULL; + ULOG_ERR("failed to mmap %s\n", module); + goto out; } if (elf_find_section(map, ".modinfo", &offset, &size)) { - ERROR("failed to load the .modinfo section from %s\n", module); - return NULL; + ULOG_ERR("failed to load the .modinfo section from %s\n", module); + goto out; } strings = map + offset; - while (strings && (strings < map + offset + size)) { + while (true) { char *sep; int len; while (!strings[0]) strings++; + if (strings >= map + offset + size) + break; sep = strstr(strings, "="); if (!sep) break; @@ -332,10 +321,16 @@ static struct module* get_module_info(const char *module, const char *name) } m = alloc_module(name, dep, s.st_size); - if (!m) - return NULL; - m->state = SCANNED; + if (m) + m->state = SCANNED; + +out: + if (map != MAP_FAILED) + munmap(map, s.st_size); + + if (fd >= 0) + close(fd); return m; } @@ -391,37 +386,40 @@ static int print_modinfo(char *module) int fd = open(module, O_RDONLY); unsigned int offset, size; struct stat s; - char *map, *strings; + char *map = MAP_FAILED, *strings; + int rv = -1; - if (!fd) { - ERROR("failed to open %s\n", module); - return -1; + if (fd < 0) { + ULOG_ERR("failed to open %s\n", module); + goto out; } if (fstat(fd, &s) == -1) { - ERROR("failed to stat %s\n", module); - return -1; + ULOG_ERR("failed to stat %s\n", module); + goto out; } map = mmap(NULL, s.st_size, PROT_READ, MAP_PRIVATE, fd, 0); if (map == MAP_FAILED) { - ERROR("failed to mmap %s\n", module); - return -1; + ULOG_ERR("failed to mmap %s\n", module); + goto out; } if (elf_find_section(map, ".modinfo", &offset, &size)) { - ERROR("failed to load the .modinfo section from %s\n", module); - return -1; + ULOG_ERR("failed to load the .modinfo section from %s\n", module); + goto out; } strings = map + offset; printf("module:\t\t%s\n", module); - while (strings && (strings < map + offset + size)) { + while (true) { char *dup = NULL; char *sep; while (!strings[0]) strings++; + if (strings >= map + offset + size) + break; sep = strstr(strings, "="); if (!sep) break; @@ -438,7 +436,16 @@ static int print_modinfo(char *module) free(dup); } - return 0; + rv = 0; + +out: + if (map != MAP_FAILED) + munmap(map, s.st_size); + + if (fd >= 0) + close(fd); + + return rv; } static int deps_available(struct module *m, int verbose) @@ -446,7 +453,7 @@ static int deps_available(struct module *m, int verbose) char *dep; int err = 0; - if (!strcmp(m->depends, "-") || !strcmp(m->depends, "")) + if (!m->depends || !strcmp(m->depends, "-") || !strcmp(m->depends, "")) return 0; dep = m->depends; @@ -455,9 +462,9 @@ static int deps_available(struct module *m, int verbose) m = find_module(dep); if (verbose && !m) - ERROR("missing dependency %s\n", dep); + ULOG_ERR("missing dependency %s\n", dep); if (verbose && m && (m->state != LOADED)) - ERROR("dependency not loaded %s\n", dep); + ULOG_ERR("dependency not loaded %s\n", dep); if (!m || (m->state != LOADED)) err++; dep += strlen(dep) + 1; @@ -473,13 +480,13 @@ static int insert_module(char *path, const char *options) int fd, ret = -1; if (stat(path, &s)) { - ERROR("missing module %s\n", path); + ULOG_ERR("missing module %s\n", path); return ret; } fd = open(path, O_RDONLY); - if (!fd) { - ERROR("cannot open %s\n", path); + if (fd < 0) { + ULOG_ERR("cannot open %s\n", path); return ret; } @@ -487,7 +494,7 @@ static int insert_module(char *path, const char *options) if (read(fd, data, s.st_size) == s.st_size) ret = syscall(__NR_init_module, data, (unsigned long) s.st_size, options); else - ERROR("failed to read full module %s\n", path); + ULOG_ERR("failed to read full module %s\n", path); close(fd); free(data); @@ -509,7 +516,7 @@ static void load_moddeps(struct module *_m) m = find_module(dep); if (!m) - ERROR("failed to find dependency %s\n", dep); + ULOG_ERR("failed to find dependency %s\n", dep); if (m && (m->state != LOADED)) { m->state = PROBE; load_moddeps(m); @@ -554,14 +561,14 @@ static int load_modprobe(void) static int print_insmod_usage(void) { - INFO("Usage:\n\tinsmod filename [args]\n"); + ULOG_INFO("Usage:\n\tinsmod filename [args]\n"); return -1; } static int print_usage(char *arg) { - INFO("Usage:\n\t%s module\n", arg); + ULOG_INFO("Usage:\n\t%s module\n", arg); return -1; } @@ -576,7 +583,7 @@ static int main_insmod(int argc, char **argv) name = get_module_name(argv[1]); if (!name) { - ERROR("cannot find module - %s\n", argv[1]); + ULOG_ERR("cannot find module - %s\n", argv[1]); return -1; } @@ -584,7 +591,7 @@ static int main_insmod(int argc, char **argv) return -1; if (find_module(name)) { - ERROR("module is already loaded - %s\n", name); + ULOG_ERR("module is already loaded - %s\n", name); return -1; } @@ -605,6 +612,11 @@ static int main_insmod(int argc, char **argv) cur += sprintf(cur, "%s", argv[i]); } + if (init_module_folders()) { + fprintf(stderr, "Failed to find the folder holding the modules\n"); + return -1; + } + if (get_module_path(argv[1])) { name = argv[1]; } else if (!get_module_path(name)) { @@ -616,7 +628,7 @@ static int main_insmod(int argc, char **argv) free(options); if (ret) - ERROR("failed to insert %s\n", get_module_path(name)); + ULOG_ERR("failed to insert %s\n", get_module_path(name)); return ret; } @@ -636,13 +648,13 @@ static int main_rmmod(int argc, char **argv) name = get_module_name(argv[1]); m = find_module(name); if (!m) { - ERROR("module is not loaded\n"); + ULOG_ERR("module is not loaded\n"); return -1; } ret = syscall(__NR_delete_module, m->name, 0); if (ret) - ERROR("unloading the module failed\n"); + ULOG_ERR("unloading the module failed\n"); free_modules(); @@ -652,15 +664,26 @@ static int main_rmmod(int argc, char **argv) static int main_lsmod(int argc, char **argv) { struct module *m; + char *dep; if (scan_loaded_modules()) return -1; avl_for_each_element(&modules, m, avl) - if (m->state == LOADED) - printf("%-20s%8d%3d %s\n", - m->name, m->size, m->usage, - (*m->depends == '-') ? ("") : (m->depends)); + if (m->state == LOADED) { + printf("%-20s%8d%3d ", + m->name, m->size, m->usage); + if (m->depends && strcmp(m->depends, "-") && strcmp(m->depends, "")) { + dep = m->depends; + while (*dep) { + printf("%s", dep); + dep = dep + strlen(dep) + 1; + if (*dep) + printf(","); + } + } + printf("\n"); + } free_modules(); @@ -681,13 +704,13 @@ static int main_modinfo(int argc, char **argv) name = get_module_name(argv[1]); m = find_module(name); if (!m) { - ERROR("cannot find module - %s\n", argv[1]); + ULOG_ERR("cannot find module - %s\n", argv[1]); return -1; } name = get_module_path(m->name); if (!name) { - ERROR("cannot find path of module - %s\n", m->name); + ULOG_ERR("cannot find path of module - %s\n", m->name); return -1; } @@ -700,8 +723,15 @@ static int main_modprobe(int argc, char **argv) { struct module *m; char *name; + char *mod = NULL; + int i; - if (argc != 2) + for (i = 1; i < argc; i++) + if (argv[i][0] != '-') { + mod = argv[i]; + break; + } + if (!mod) return print_usage("modprobe"); if (scan_loaded_modules()) @@ -710,13 +740,13 @@ static int main_modprobe(int argc, char **argv) if (scan_module_folders()) return -1; - name = get_module_name(argv[1]); + name = get_module_name(mod); m = find_module(name); if (m && m->state == LOADED) { - ERROR("%s is already loaded\n", name); + ULOG_ERR("%s is already loaded\n", name); return -1; } else if (!m) { - ERROR("failed to find a module named %s\n", name); + ULOG_ERR("failed to find a module named %s\n", name); } else { int fail; @@ -725,12 +755,12 @@ static int main_modprobe(int argc, char **argv) fail = load_modprobe(); if (fail) { - ERROR("%d module%s could not be probed\n", - fail, (fail == 1) ? ("") : ("s")); + ULOG_ERR("%d module%s could not be probed\n", + fail, (fail == 1) ? ("") : ("s")); avl_for_each_element(&modules, m, avl) if ((m->state == PROBE) || m->error) - ERROR("- %s\n", m->name); + ULOG_ERR("- %s\n", m->name); } } @@ -742,7 +772,7 @@ static int main_modprobe(int argc, char **argv) static int main_loader(int argc, char **argv) { int gl_flags = GLOB_NOESCAPE | GLOB_MARK; - char *dir = "/etc/modules.d/*"; + char *dir = "/etc/modules.d/"; struct module *m; glob_t gl; char *path; @@ -755,13 +785,17 @@ static int main_loader(int argc, char **argv) strcpy(path, dir); strcat(path, "*"); - if (scan_loaded_modules()) + if (scan_loaded_modules()) { + free (path); return -1; + } - if (scan_module_folders()) + if (scan_module_folders()) { + free (path); return -1; + } - syslog(0, "kmodloader: loading kernel modules from %s\n", path); + ULOG_INFO("loading kernel modules from %s\n", path); if (glob(path, gl_flags, NULL, &gl) < 0) goto out; @@ -772,7 +806,7 @@ static int main_loader(int argc, char **argv) char *mod = NULL; if (!fp) { - ERROR("failed to open %s\n", gl.gl_pathv[j]); + ULOG_ERR("failed to open %s\n", gl.gl_pathv[j]); continue; } @@ -804,15 +838,16 @@ static int main_loader(int argc, char **argv) } fail = load_modprobe(); - DEBUG("ran %d iterations\n", iterations); if (fail) { - ERROR("%d module%s could not be probed\n", - fail, (fail == 1) ? ("") : ("s")); + ULOG_ERR("%d module%s could not be probed\n", + fail, (fail == 1) ? ("") : ("s")); avl_for_each_element(&modules, m, avl) if ((m->state == PROBE) || (m->error)) - ERROR("- %s - %d\n", m->name, deps_available(m, 1)); + ULOG_ERR("- %s - %d\n", m->name, deps_available(m, 1)); + } else { + ULOG_INFO("done loading kernel modules from %s\n", path); } out: @@ -858,5 +893,6 @@ int main(int argc, char **argv) if (!strcmp(exec, "modprobe")) return main_modprobe(argc, argv); + ulog_open(ULOG_KMSG, LOG_USER, "kmodloader"); return main_loader(argc, argv); }