main: fix uninitialized variable
[project/relayd.git] / main.c
diff --git a/main.c b/main.c
index 62d7c2b..7f33d90 100644 (file)
--- a/main.c
+++ b/main.c
 
 #include "relayd.h"
 
+static LIST_HEAD(pending_routes);
 LIST_HEAD(interfaces);
 int debug;
 
 static int host_timeout;
+static int host_ping_tries;
 static int inet_sock;
 static int forward_bcast;
 static int forward_dhcp;
+static int parse_dhcp;
+
+uint8_t local_addr[4];
+int local_route_table;
+
+struct relayd_pending_route {
+       struct relayd_route rt;
+       struct uloop_timeout timeout;
+       uint8_t gateway[4];
+};
 
 static struct relayd_host *find_host_by_ipaddr(struct relayd_interface *rif, const uint8_t *ipaddr)
 {
@@ -81,20 +93,55 @@ static void add_arp(struct relayd_host *host)
        ioctl(inet_sock, SIOCSARP, &arp);
 }
 
+static void timeout_host_route(struct uloop_timeout *timeout)
+{
+       struct relayd_pending_route *rt;
+
+       rt = container_of(timeout, struct relayd_pending_route, timeout);
+       list_del(&rt->rt.list);
+       free(rt);
+}
+
+void relayd_add_host_route(struct relayd_host *host, const uint8_t *dest, uint8_t mask)
+{
+       struct relayd_route *rt;
+
+       list_for_each_entry(rt, &host->routes, list) {
+               if (!memcmp(rt->dest, dest, sizeof(rt->dest)) && rt->mask == mask)
+                       return;
+       }
+
+       rt = calloc(1, sizeof(*rt));
+       if (!rt)
+               return;
+
+       list_add(&rt->list, &host->routes);
+       memcpy(rt->dest, dest, sizeof(rt->dest));
+       rt->mask = mask;
+       relayd_add_route(host, rt);
+}
+
 static void del_host(struct relayd_host *host)
 {
+       struct relayd_route *route, *tmp;
+
        DPRINTF(1, "%s: deleting host "IP_FMT" ("MAC_FMT")\n", host->rif->ifname,
                IP_BUF(host->ipaddr), MAC_BUF(host->lladdr));
 
+       list_for_each_entry_safe(route, tmp, &host->routes, list) {
+               relayd_del_route(host, route);
+               list_del(&route->list);
+               free(route);
+       }
        if (host->rif->managed)
-               relayd_del_route(host);
+               relayd_del_route(host, NULL);
        uloop_timeout_cancel(&host->timeout);
        list_del(&host->list);
        free(host);
 }
 
-static void fill_arp_request(struct arp_packet *pkt, struct relayd_interface *rif,
-                             uint8_t spa[4], uint8_t tpa[4])
+static void fill_arp_packet(struct arp_packet *pkt, struct relayd_interface *rif,
+                             const uint8_t spa[4], const uint8_t tpa[4])
 {
        memset(pkt, 0, sizeof(*pkt));
 
@@ -111,12 +158,11 @@ static void fill_arp_request(struct arp_packet *pkt, struct relayd_interface *ri
        pkt->arp.arp_pln = 4;
 }
 
-static void send_arp_request(struct relayd_host *host)
+static void send_arp_request(struct relayd_interface *rif, const uint8_t *ipaddr)
 {
-       struct relayd_interface *rif = host->rif;
        struct arp_packet pkt;
 
-       fill_arp_request(&pkt, host->rif, host->rif->src_ip, host->ipaddr);
+       fill_arp_packet(&pkt, rif, rif->src_ip, ipaddr);
 
        pkt.arp.arp_op = htons(ARPOP_REQUEST);
        memcpy(pkt.arp.arp_spa, rif->src_ip, ETH_ALEN);
@@ -131,28 +177,83 @@ static void send_arp_request(struct relayd_host *host)
                (struct sockaddr *) &rif->sll, sizeof(rif->sll));
 }
 
-static void send_arp_reply(struct relayd_interface *rif, uint8_t spa[4],
-                           uint8_t tha[ETH_ALEN], uint8_t tpa[4])
+void relayd_add_pending_route(const uint8_t *gateway, const uint8_t *dest, uint8_t mask, int timeout)
+{
+       struct relayd_pending_route *rt;
+       struct relayd_interface *rif;
+       struct relayd_host *host;
+
+       host = find_host_by_ipaddr(NULL, gateway);
+       if (host) {
+               relayd_add_host_route(host, dest, mask);
+               return;
+       }
+
+       rt = calloc(1, sizeof(*rt));
+       if (!rt)
+               return;
+
+       memcpy(rt->gateway, gateway, sizeof(rt->gateway));
+       memcpy(rt->rt.dest, dest, sizeof(rt->rt.dest));
+       rt->rt.mask = mask;
+       list_add(&rt->rt.list, &pending_routes);
+       if (timeout <= 0)
+               return;
+
+       rt->timeout.cb = timeout_host_route;
+       uloop_timeout_set(&rt->timeout, 10000);
+       list_for_each_entry(rif, &interfaces, list) {
+               send_arp_request(rif, gateway);
+       }
+}
+
+static void send_arp_reply(struct relayd_interface *rif, const uint8_t spa[4],
+                           const uint8_t tha[ETH_ALEN], const uint8_t tpa[4])
 {
        struct arp_packet pkt;
 
-       fill_arp_request(&pkt, rif, spa, tpa);
+       fill_arp_packet(&pkt, rif, spa, tpa);
 
-       pkt.arp.arp_op = htons(ARPOP_REPLY);
-       memcpy(pkt.eth.ether_dhost, tha, ETH_ALEN);
-       memcpy(pkt.arp.arp_tha, tha, ETH_ALEN);
+       if (tha) {
+               pkt.arp.arp_op = htons(ARPOP_REPLY);
+               memcpy(pkt.eth.ether_dhost, tha, ETH_ALEN);
+               memcpy(pkt.arp.arp_tha, tha, ETH_ALEN);
 
-       DPRINTF(2, "%s: sending ARP reply to "IP_FMT", "IP_FMT" is at ("MAC_FMT")\n",
-               rif->ifname, IP_BUF(pkt.arp.arp_tpa),
-               IP_BUF(pkt.arp.arp_spa), MAC_BUF(pkt.eth.ether_shost));
+               DPRINTF(2, "%s: sending ARP reply to "IP_FMT", "IP_FMT" is at ("MAC_FMT")\n",
+                       rif->ifname, IP_BUF(pkt.arp.arp_tpa),
+                       IP_BUF(pkt.arp.arp_spa), MAC_BUF(pkt.eth.ether_shost));
+       } else {
+               pkt.arp.arp_op = htons(ARPOP_REQUEST);
+               memset(pkt.eth.ether_dhost, 0xff, ETH_ALEN);
+               memset(pkt.arp.arp_tha, 0xff, ETH_ALEN);
+
+               DPRINTF(2, "%s: sending gratuitous ARP: "IP_FMT" is at ("MAC_FMT")\n",
+                       rif->ifname, IP_BUF(pkt.arp.arp_tpa),
+                       MAC_BUF(pkt.eth.ether_shost));
+       }
+
+       sendto(rif->fd.fd, &pkt, sizeof(pkt), 0,
+               (struct sockaddr *) &rif->sll, sizeof(rif->sll));
+
+       if (tha)
+               return;
+
+       /*
+        * Gratuitous ARP comes in two flavours, request and reply.
+        * Some operating systems only accept request, some only reply.
+        * Let's just send both...
+        */
+       pkt.arp.arp_op = htons(ARPOP_REPLY);
 
        sendto(rif->fd.fd, &pkt, sizeof(pkt), 0,
                (struct sockaddr *) &rif->sll, sizeof(rif->sll));
+
 }
 
 static void host_entry_timeout(struct uloop_timeout *timeout)
 {
        struct relayd_host *host = container_of(timeout, struct relayd_host, timeout);
+       struct relayd_interface *rif;
 
        /*
         * When a host is behind a managed interface, we must not expire its host
@@ -161,8 +262,10 @@ static void host_entry_timeout(struct uloop_timeout *timeout)
         * When the timeout is reached, try pinging the host a few times before
         * giving up on it.
         */
-       if (host->rif->managed && host->cleanup_pending < 2) {
-               send_arp_request(host);
+       if (host->rif->managed && host->cleanup_pending < host_ping_tries) {
+               list_for_each_entry(rif, &interfaces, list) {
+                       send_arp_request(rif, host->ipaddr);
+               }
                host->cleanup_pending++;
                uloop_timeout_set(&host->timeout, 1000);
                return;
@@ -173,11 +276,13 @@ static void host_entry_timeout(struct uloop_timeout *timeout)
 static struct relayd_host *add_host(struct relayd_interface *rif, const uint8_t *lladdr, const uint8_t *ipaddr)
 {
        struct relayd_host *host;
+       struct relayd_pending_route *route, *rtmp;
 
        DPRINTF(1, "%s: adding host "IP_FMT" ("MAC_FMT")\n", rif->ifname,
                        IP_BUF(ipaddr), MAC_BUF(lladdr));
 
        host = calloc(1, sizeof(*host));
+       INIT_LIST_HEAD(&host->routes);
        host->rif = rif;
        memcpy(host->ipaddr, ipaddr, sizeof(host->ipaddr));
        memcpy(host->lladdr, lladdr, sizeof(host->lladdr));
@@ -187,11 +292,37 @@ static struct relayd_host *add_host(struct relayd_interface *rif, const uint8_t
 
        add_arp(host);
        if (rif->managed)
-               relayd_add_route(host);
+               relayd_add_route(host, NULL);
+
+       list_for_each_entry_safe(route, rtmp, &pending_routes, rt.list) {
+               if (memcmp(route->gateway, ipaddr, 4) != 0)
+                       continue;
+
+               relayd_add_host_route(host, route->rt.dest, route->rt.mask);
+               if (!route->timeout.pending)
+                       continue;
+
+               uloop_timeout_cancel(&route->timeout);
+               list_del(&route->rt.list);
+               free(route);
+       }
 
        return host;
 }
 
+static void send_gratuitous_arp(struct relayd_interface *rif, const uint8_t *spa)
+{
+       struct relayd_interface *to_rif;
+
+       list_for_each_entry(to_rif, &interfaces, list) {
+               if (rif == to_rif)
+                       continue;
+
+               send_arp_reply(to_rif, spa, NULL, spa);
+       }
+}
+
+
 struct relayd_host *relayd_refresh_host(struct relayd_interface *rif, const uint8_t *lladdr, const uint8_t *ipaddr)
 {
        struct relayd_host *host;
@@ -207,13 +338,16 @@ struct relayd_host *relayd_refresh_host(struct relayd_interface *rif, const uint
                 * If the old entry is behind a managed interface, it will be pinged
                 * before we expire it
                 */
-               if (host && !host->cleanup_pending)
+               if (host && !host->cleanup_pending) {
                        uloop_timeout_set(&host->timeout, 1);
+                       return NULL;
+               }
 
                host = add_host(rif, lladdr, ipaddr);
        } else {
                host->cleanup_pending = false;
                uloop_timeout_set(&host->timeout, host_timeout * 1000);
+               send_gratuitous_arp(rif, ipaddr);
        }
 
        return host;
@@ -230,7 +364,9 @@ static void relay_arp_request(struct relayd_interface *from_rif, struct arp_pack
                        continue;
 
                memcpy(reqpkt.eth.ether_shost, rif->sll.sll_addr, ETH_ALEN);
+               memset(reqpkt.eth.ether_dhost, 0xff, ETH_ALEN);
                memcpy(reqpkt.arp.arp_sha, rif->sll.sll_addr, ETH_ALEN);
+               memset(reqpkt.arp.arp_tha, 0, ETH_ALEN);
 
                DPRINTF(2, "%s: sending ARP who-has "IP_FMT", tell "IP_FMT" ("MAC_FMT")\n",
                        rif->ifname, IP_BUF(reqpkt.arp.arp_tpa),
@@ -254,7 +390,14 @@ static void recv_arp_request(struct relayd_interface *rif, struct arp_packet *pk
        if (!memcmp(pkt->arp.arp_spa, "\x00\x00\x00\x00", 4))
                return;
 
-       relayd_refresh_host(rif, pkt->eth.ether_shost, pkt->arp.arp_spa);
+       host = find_host_by_ipaddr(NULL, pkt->arp.arp_spa);
+       if (!host || host->rif != rif)
+               relayd_refresh_host(rif, pkt->eth.ether_shost, pkt->arp.arp_spa);
+
+       if (local_route_table && !memcmp(pkt->arp.arp_tpa, local_addr, sizeof(local_addr))) {
+               send_arp_reply(rif, local_addr, pkt->arp.arp_sha, pkt->arp.arp_spa);
+               return;
+       }
 
        host = find_host_by_ipaddr(NULL, pkt->arp.arp_tpa);
 
@@ -270,7 +413,6 @@ static void recv_arp_request(struct relayd_interface *rif, struct arp_packet *pk
        relay_arp_request(rif, pkt);
 }
 
-
 static void recv_arp_reply(struct relayd_interface *rif, struct arp_packet *pkt)
 {
        struct relayd_host *host;
@@ -281,10 +423,8 @@ static void recv_arp_reply(struct relayd_interface *rif, struct arp_packet *pkt)
                MAC_BUF(pkt->eth.ether_shost),
                IP_BUF(pkt->arp.arp_tpa));
 
-       relayd_refresh_host(rif, pkt->arp.arp_sha, pkt->arp.arp_spa);
-
-       if (!memcmp(pkt->arp.arp_tpa, rif->src_ip, 4))
-               return;
+       if (memcmp(pkt->arp.arp_sha, rif->sll.sll_addr, ETH_ALEN) != 0)
+               relayd_refresh_host(rif, pkt->arp.arp_sha, pkt->arp.arp_spa);
 
        host = find_host_by_ipaddr(NULL, pkt->arp.arp_tpa);
        if (!host)
@@ -368,7 +508,7 @@ static void recv_bcast_packet(struct uloop_fd *fd, unsigned int events)
                if (!forward_bcast && !forward_dhcp)
                        continue;
 
-               if (relayd_handle_dhcp_packet(rif, pktbuf, pktlen, forward_dhcp))
+               if (relayd_handle_dhcp_packet(rif, pktbuf, pktlen, forward_dhcp, parse_dhcp))
                        continue;
 
                if (forward_bcast)
@@ -450,7 +590,7 @@ static int init_interface(struct relayd_interface *rif)
        }
 
 #ifdef PACKET_RECV_TYPE
-       pkt_type = (1 << PACKET_BROADCAST);
+       pkt_type = (1 << PACKET_BROADCAST) | (1 << PACKET_MULTICAST);
        setsockopt(fd, SOL_PACKET, PACKET_RECV_TYPE, &pkt_type, sizeof(pkt_type));
 #endif
 
@@ -459,6 +599,16 @@ static int init_interface(struct relayd_interface *rif)
        return 0;
 }
 
+static void ping_static_routes(void)
+{
+       struct relayd_pending_route *rt;
+       struct relayd_interface *rif;
+
+       list_for_each_entry(rt, &pending_routes, rt.list)
+               list_for_each_entry(rif, &interfaces, list)
+                       send_arp_request(rif, rt->gateway);
+}
+
 static int init_interfaces(void)
 {
        struct relayd_interface *rif;
@@ -496,24 +646,23 @@ static void free_interfaces(void)
        }
 }
 
-static int alloc_interface(const char *ifname, bool managed)
+static struct relayd_interface *alloc_interface(const char *ifname, bool managed)
 {
        struct relayd_interface *rif;
 
        if (strlen(ifname) >= IFNAMSIZ)
-               return -1;
+               return NULL;
 
        rif = calloc(1, sizeof(*rif));
        if (!rif)
-               return -1;
+               return NULL;
 
-       INIT_LIST_HEAD(&rif->list);
        INIT_LIST_HEAD(&rif->hosts);
        strcpy(rif->ifname, ifname);
        list_add(&rif->list, &interfaces);
        rif->managed = managed;
 
-       return 0;
+       return rif;
 }
 
 static void die(int signo)
@@ -522,9 +671,7 @@ static void die(int signo)
         * When we hit SIGTERM, clean up interfaces directly, so that we
         * won't leave our routing in an invalid state.
         */
-       cleanup_hosts();
-       free_interfaces();
-       exit(1);
+       uloop_end();
 }
 
 static int usage(const char *progname)
@@ -536,10 +683,16 @@ static int usage(const char *progname)
                        "       -i <ifname>     Add an interface for relaying\n"
                        "       -I <ifname>     Same as -i, except with ARP cache and host route management\n"
                        "                       You need to specify at least two interfaces\n"
+                       "       -G <ip>         Set a gateway IP for clients\n"
+                       "       -R <gateway>:<net>/<mask>\n"
+                       "                       Add a static route for <net>/<mask> via <gateway>\n"
                        "       -t <timeout>    Host entry expiry timeout\n"
+                       "       -p <tries>      Number of ARP ping attempts before considering a host dead\n"
                        "       -T <table>      Set routing table number for automatically added routes\n"
                        "       -B              Enable broadcast forwarding\n"
                        "       -D              Enable DHCP forwarding\n"
+                       "       -P              Disable DHCP options parsing\n"
+                       "       -L <ipaddr>     Enable local access using <ipaddr> as source address\n"
                        "\n",
                progname);
        return -1;
@@ -547,8 +700,13 @@ static int usage(const char *progname)
 
 int main(int argc, char **argv)
 {
-       bool managed;
+       struct relayd_interface *rif = NULL;
+       struct in_addr addr, addr2;
+       bool local_addr_valid = false;
+       bool managed = false;
        int ifnum = 0;
+       char *s, *s2;
+       int mask;
        int ch;
 
        debug = 0;
@@ -558,18 +716,22 @@ int main(int argc, char **argv)
                return 1;
        }
 
-       host_timeout = 60;
+       host_timeout = 30;
+       host_ping_tries = 5;
        forward_bcast = 0;
+       local_route_table = 0;
+       parse_dhcp = 1;
        uloop_init();
 
-       while ((ch = getopt(argc, argv, "I:i:t:BDdT:")) != -1) {
+       while ((ch = getopt(argc, argv, "I:i:t:p:BDPdT:G:R:L:")) != -1) {
                switch(ch) {
                case 'I':
                        managed = true;
                        /* fall through */
                case 'i':
                        ifnum++;
-                       if (alloc_interface(optarg, managed) < 0)
+                       rif = alloc_interface(optarg, managed);
+                       if (!rif)
                                return 1;
 
                        managed = false;
@@ -579,6 +741,11 @@ int main(int argc, char **argv)
                        if (host_timeout <= 0)
                                return usage(argv[0]);
                        break;
+               case 'p':
+                       host_ping_tries = atoi(optarg);
+                       if (host_ping_tries <= 0)
+                               return usage(argv[0]);
+                       break;
                case 'd':
                        debug++;
                        break;
@@ -588,11 +755,56 @@ int main(int argc, char **argv)
                case 'D':
                        forward_dhcp = 1;
                        break;
+               case 'P':
+                       parse_dhcp = 0;
+                       break;
                case 'T':
                        route_table = atoi(optarg);
                        if (route_table <= 0)
                                return usage(argv[0]);
                        break;
+               case 'G':
+                       if (!inet_aton(optarg, &addr)) {
+                               fprintf(stderr, "Address '%s' not found\n", optarg);
+                               return 1;
+                       }
+                       relayd_add_pending_route((uint8_t *) &addr.s_addr, (const uint8_t *) "\x00\x00\x00\x00", 0, 0);
+                       break;
+               case 'L':
+                       if (!inet_aton(optarg, &addr)) {
+                               fprintf(stderr, "Address '%s' not found\n", optarg);
+                               return 1;
+                       }
+                       memcpy(&local_addr, &addr.s_addr, sizeof(local_addr));
+                       local_addr_valid = true;
+                       break;
+               case 'R':
+                       s = strchr(optarg, ':');
+                       if (!s)
+                               return usage(argv[0]);
+
+                       *(s++) = 0;
+                       if (!inet_aton(optarg, &addr)) {
+                               fprintf(stderr, "Address '%s' not found\n", optarg);
+                               return 1;
+                       }
+
+                       s2 = strchr(s, '/');
+                       if (!s2)
+                               return usage(argv[0]);
+
+                       *(s2++) = 0;
+                       if (!inet_aton(s, &addr2)) {
+                               fprintf(stderr, "Address '%s' not found\n", s);
+                               return 1;
+                       }
+
+                       mask = atoi(s2);
+                       if (mask < 0 || mask > 32)
+                               return usage(argv[0]);
+
+                       relayd_add_pending_route((uint8_t *) &addr.s_addr, (uint8_t *) &addr2.s_addr, mask, 0);
+                       break;
                case '?':
                default:
                        return usage(argv[0]);
@@ -615,12 +827,17 @@ int main(int argc, char **argv)
        signal(SIGUSR1, die);
        signal(SIGUSR2, die);
 
+       if (local_addr_valid)
+               local_route_table = route_table++;
+
        if (relayd_rtnl_init() < 0)
                return 1;
 
        if (init_interfaces() < 0)
                return 1;
 
+       ping_static_routes();
+
        uloop_run();
        uloop_done();