system: fix undefined behavior in wdt offline check

watchdog_fd() is returning a char* and not a int. checking against < 0 could
lead in undefined behaviour.

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>

diff --git a/system.c b/system.c
index 82c672e..fb7fbe4 100644 (file)
--- a/system.c
+++ b/system.c
@@ -282,7 +282,7 @@ static int watchdog_set(struct ubus_context *ctx, struct ubus_object *obj,
        if (tb[WDT_STOP])
                watchdog_set_stopped(blobmsg_get_bool(tb[WDT_STOP]));
 
        if (tb[WDT_STOP])
                watchdog_set_stopped(blobmsg_get_bool(tb[WDT_STOP]));
 

-       if (watchdog_fd() < 0)
+       if (watchdog_fd() == NULL)

                status = "offline";
        else if (watchdog_get_stopped())
                status = "stopped";
                status = "offline";
        else if (watchdog_get_stopped())
                status = "stopped";