INSTANCE_ATTR_JAIL,
INSTANCE_ATTR_TRACE,
INSTANCE_ATTR_SECCOMP,
+ INSTANCE_ATTR_PIDFILE,
__INSTANCE_ATTR_MAX
};
[INSTANCE_ATTR_JAIL] = { "jail", BLOBMSG_TYPE_TABLE },
[INSTANCE_ATTR_TRACE] = { "trace", BLOBMSG_TYPE_BOOL },
[INSTANCE_ATTR_SECCOMP] = { "seccomp", BLOBMSG_TYPE_STRING },
+ [INSTANCE_ATTR_PIDFILE] = { "pidfile", BLOBMSG_TYPE_STRING },
};
enum {
JAIL_ATTR_NAME,
+ JAIL_ATTR_HOSTNAME,
JAIL_ATTR_PROCFS,
JAIL_ATTR_SYSFS,
JAIL_ATTR_UBUS,
static const struct blobmsg_policy jail_attr[__JAIL_ATTR_MAX] = {
[JAIL_ATTR_NAME] = { "name", BLOBMSG_TYPE_STRING },
+ [JAIL_ATTR_HOSTNAME] = { "hostname", BLOBMSG_TYPE_STRING },
[JAIL_ATTR_PROCFS] = { "procfs", BLOBMSG_TYPE_BOOL },
[JAIL_ATTR_SYSFS] = { "sysfs", BLOBMSG_TYPE_BOOL },
[JAIL_ATTR_UBUS] = { "ubus", BLOBMSG_TYPE_BOOL },
{ "data", RLIMIT_DATA },
{ "fsize", RLIMIT_FSIZE },
{ "memlock", RLIMIT_MEMLOCK },
- { "msgqueue", RLIMIT_MSGQUEUE },
- { "nice", RLIMIT_NICE },
{ "nofile", RLIMIT_NOFILE },
{ "nproc", RLIMIT_NPROC },
{ "rss", RLIMIT_RSS },
+ { "stack", RLIMIT_STACK },
+#ifdef linux
+ { "nice", RLIMIT_NICE },
{ "rtprio", RLIMIT_RTPRIO },
+ { "msgqueue", RLIMIT_MSGQUEUE },
{ "sigpending", RLIMIT_SIGPENDING },
- { "stack", RLIMIT_STACK },
+#endif
{ NULL, 0 }
};
argv[argc++] = jail->name;
}
+ if (jail->hostname) {
+ argv[argc++] = "-h";
+ argv[argc++] = jail->hostname;
+ }
+
if (in->seccomp) {
argv[argc++] = "-S";
argv[argc++] = in->seccomp;
return argc;
}
+static int
+instance_removepid(struct service_instance *in) {
+ if (!in->pidfile)
+ return 0;
+ if (unlink(in->pidfile)) {
+ ERROR("Failed to removed pidfile: %s: %d - %s\n",
+ in->pidfile, errno, strerror(errno));
+ return 1;
+ }
+ return 0;
+}
+
+static int
+instance_writepid(struct service_instance *in)
+{
+ FILE *_pidfile;
+
+ if (!in->pidfile) {
+ return 0;
+ }
+ _pidfile = fopen(in->pidfile, "w");
+ if (_pidfile == NULL) {
+ ERROR("failed to open pidfile for writing: %s: %d (%s)",
+ in->pidfile, errno, strerror(errno));
+ return 1;
+ }
+ if (fprintf(_pidfile, "%d\n", in->proc.pid) < 0) {
+ ERROR("failed to write pidfile: %s: %d (%s)",
+ in->pidfile, errno, strerror(errno));
+ return 2;
+ }
+ if (fclose(_pidfile)) {
+ ERROR("failed to close pidfile: %s: %d (%s)",
+ in->pidfile, errno, strerror(errno));
+ return 3;
+ }
+
+ return 0;
+}
+
static void
instance_run(struct service_instance *in, int _stdout, int _stderr)
{
return;
}
- DEBUG(2, "Started instance %s::%s\n", in->srv->name, in->name);
+ DEBUG(2, "Started instance %s::%s[%d]\n", in->srv->name, in->name, pid);
in->proc.pid = pid;
+ instance_writepid(in);
clock_gettime(CLOCK_MONOTONIC, &in->start);
uloop_process_add(&in->proc);
uloop_timeout_cancel(&in->timeout);
if (in->halt) {
- /* no action */
+ instance_removepid(in);
} else if (in->restart) {
instance_start(in);
} else if (in->respawn) {
in->srv->name, in->name, in->respawn_count, runtime);
in->restart = in->respawn = 0;
in->halt = 1;
+ service_event("instance.fail", in->srv->name, in->name);
} else {
+ service_event("instance.respawn", in->srv->name, in->name);
uloop_timeout_set(&in->timeout, in->respawn_timeout * 1000);
}
}
in->halt = false;
in->restart = true;
kill(in->proc.pid, SIGTERM);
+ instance_removepid(in);
}
static bool
if (in->gid != in_new->gid)
return true;
+ if (in->pidfile && in_new->pidfile)
+ if (strcmp(in->pidfile, in_new->pidfile))
+ return true;
+
+ if (in->pidfile && !in_new->pidfile)
+ return true;
+
+ if (!in->pidfile && in_new->pidfile)
+ return true;
+
if (!blobmsg_list_equal(&in->limits, &in_new->limits))
return true;
jail->name = blobmsg_get_string(tb[JAIL_ATTR_NAME]);
jail->argc += 2;
}
+ if (tb[JAIL_ATTR_HOSTNAME]) {
+ jail->hostname = blobmsg_get_string(tb[JAIL_ATTR_HOSTNAME]);
+ jail->argc += 2;
+ }
if (tb[JAIL_ATTR_PROCFS]) {
jail->procfs = blobmsg_get_bool(tb[JAIL_ATTR_PROCFS]);
jail->argc++;
else
in->seccomp = seccomp;
}
+
+ if (tb[INSTANCE_ATTR_PIDFILE]) {
+ char *pidfile = blobmsg_get_string(tb[INSTANCE_ATTR_PIDFILE]);
+ if (pidfile)
+ in->pidfile = pidfile;
+ }
+
if (!in->trace && tb[INSTANCE_ATTR_JAIL])
in->has_jail = instance_jail_parse(in, tb[INSTANCE_ATTR_JAIL]);
blobmsg_list_move(&in->jail.mount, &in_src->jail.mount);
in->trigger = in_src->trigger;
in->command = in_src->command;
+ in->pidfile = in_src->pidfile;
in->name = in_src->name;
in->node.avl.key = in_src->node.avl.key;
if (in->seccomp)
blobmsg_add_string(b, "seccomp", in->seccomp);
+ if (in->pidfile)
+ blobmsg_add_string(b, "pidfile", in->pidfile);
+
if (in->has_jail) {
void *r = blobmsg_open_table(b, "jail");
if (in->jail.name)
blobmsg_add_string(b, "name", in->jail.name);
+ if (in->jail.hostname)
+ blobmsg_add_string(b, "hostname", in->jail.hostname);
blobmsg_add_u8(b, "procfs", in->jail.procfs);
blobmsg_add_u8(b, "sysfs", in->jail.sysfs);
blobmsg_add_u8(b, "ubus", in->jail.ubus);