service: initialize supplementary group ids

[project/procd.git] / plug / coldplug.c

diff --git a/plug/coldplug.c b/plug/coldplug.c
index d3a607d..c6a89c3 100644 (file)
--- a/plug/coldplug.c
+++ b/plug/coldplug.c
@@ -19,6 +19,7 @@
 #include <unistd.h>
 
 #include "../procd.h"
+#include "../libc-compat.h"
 
 #include "hotplug.h"
 
@@ -44,21 +45,21 @@ void procd_coldplug(void)
 
        umount2("/dev/pts", MNT_DETACH);
        umount2("/dev/", MNT_DETACH);
-       mount("tmpfs", "/dev", "tmpfs", 0, "mode=0755,size=512K");
-       mkdir("/dev/shm", 01777);
+       mount("tmpfs", "/dev", "tmpfs", MS_NOSUID, "mode=0755,size=512K");
+       ignore(symlink("/tmp/shm", "/dev/shm"));
        mkdir("/dev/pts", 0755);
        umask(oldumask);
-       mount("devpts", "/dev/pts", "devpts", 0, 0);
+       mount("devpts", "/dev/pts", "devpts", MS_NOEXEC | MS_NOSUID, 0);
        udevtrigger.cb = udevtrigger_complete;
        udevtrigger.pid = fork();
        if (!udevtrigger.pid) {
                execvp(argv[0], argv);
-               ERROR("Failed to start coldplug\n");
+               ERROR("Failed to start coldplug: %m\n");
                exit(-1);
        }
 
        if (udevtrigger.pid <= 0) {
-               ERROR("Failed to start new coldplug instance\n");
+               ERROR("Failed to start new coldplug instance: %m\n");
                return;
        }