X-Git-Url: http://git.archive.openwrt.org/?p=project%2Fodhcpd.git;a=blobdiff_plain;f=src%2Fconfig.c;h=f6a5327179228f03f61a2ba4c39b83495ca766b9;hp=ebc664262d8331788ec31449446c6ab946d55d9f;hb=b61c3f98223a264de219be37720b3bee5f19cf81;hpb=78c5e4b032c420852abc2a9e1e6f429a4d803c21

diff --git a/src/config.c b/src/config.c
index ebc6642..f6a5327 100644
--- a/src/config.c
+++ b/src/config.c
@@ -254,26 +254,29 @@ err:
 }
 
 
-int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite)
+int config_parse_interface(void *data, size_t len, const char *name, bool overwrite)
 {
 	struct blob_attr *tb[IFACE_ATTR_MAX], *c;
-	blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, blob_data(b), blob_len(b));
+	blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, data, len);
 
 	if (tb[IFACE_ATTR_INTERFACE])
-		name = blobmsg_data(tb[IFACE_ATTR_INTERFACE]);
+		name = blobmsg_get_string(tb[IFACE_ATTR_INTERFACE]);
+
+	if (!name)
+		return -1;
 
 	struct interface *iface = get_interface(name);
 	if (!iface) {
 		iface = calloc(1, sizeof(*iface));
 		strncpy(iface->name, name, sizeof(iface->name) - 1);
 		list_add(&iface->head, &interfaces);
-	} else {
+	} else if (overwrite) {
 		clean_interface(iface);
 	}
 
 	const char *ifname = NULL;
 #ifdef WITH_UBUS
-	if (overwrite)
+	if (overwrite || !iface->ifname[0])
 		ifname = ubus_get_ifname(name);
 #endif
 	if ((c = tb[IFACE_ATTR_IFNAME]))
@@ -281,7 +284,12 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 	else if ((c = tb[IFACE_ATTR_NETWORKID]))
 		ifname = blobmsg_get_string(c);
 
-	strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+	if (!iface->ifname[0] && !ifname)
+		return -1;
+
+	if (ifname)
+		strncpy(iface->ifname, ifname, sizeof(iface->ifname) - 1);
+
 	iface->inuse = true;
 
 	if (overwrite)
@@ -331,7 +339,7 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 
 	if ((c = tb[IFACE_ATTR_UPSTREAM])) {
 		struct blob_attr *cur;
-		int rem;
+		unsigned rem;
 
 		blobmsg_for_each_attr(cur, c, rem) {
 			if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, NULL))
@@ -344,25 +352,38 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 		}
 	}
 
-	if ((c = tb[IFACE_ATTR_RA]))
-		if ((iface->ra = parse_mode(blobmsg_get_string(c))) < 0)
+	int mode;
+	if ((c = tb[IFACE_ATTR_RA])) {
+		if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+			iface->ra = mode;
+		else
 			goto err;
+	}
 
-	if ((c = tb[IFACE_ATTR_DHCPV4]))
-		if ((iface->dhcpv4 = parse_mode(blobmsg_get_string(c))) < 0)
+	if ((c = tb[IFACE_ATTR_DHCPV4])) {
+		if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+			iface->dhcpv4 = mode;
+		else
 			goto err;
+	}
 
-	if ((c = tb[IFACE_ATTR_DHCPV6]))
-		if ((iface->dhcpv6 = parse_mode(blobmsg_get_string(c))) < 0)
+	if ((c = tb[IFACE_ATTR_DHCPV6])) {
+		if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+			iface->dhcpv6 = mode;
+		else
 			goto err;
+	}
 
-	if ((c = tb[IFACE_ATTR_NDP]))
-		if ((iface->ndp = parse_mode(blobmsg_get_string(c))) < 0)
+	if ((c = tb[IFACE_ATTR_NDP])) {
+		if ((mode = parse_mode(blobmsg_get_string(c))) >= 0)
+			iface->ndp = mode;
+		else
 			goto err;
+	}
 
 	if ((c = tb[IFACE_ATTR_DNS])) {
 		struct blob_attr *cur;
-		int rem;
+		unsigned rem;
 
 		iface->always_rewrite_dns = true;
 		blobmsg_for_each_attr(cur, c, rem) {
@@ -387,7 +408,7 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 
 	if ((c = tb[IFACE_ATTR_DOMAIN])) {
 		struct blob_attr *cur;
-		int rem;
+		unsigned rem;
 
 		blobmsg_for_each_attr(cur, c, rem) {
 			if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, NULL))
@@ -437,7 +458,7 @@ int config_parse_interface(struct blob_attr *b, const char *name, bool overwrite
 
 	if ((c = tb[IFACE_ATTR_NDPROXY_STATIC])) {
 		struct blob_attr *cur;
-		int rem;
+		unsigned rem;
 
 		blobmsg_for_each_attr(cur, c, rem) {
 			if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING || !blobmsg_check_attr(cur, NULL))
@@ -462,14 +483,21 @@ static int set_interface(struct uci_section *s)
 {
 	blob_buf_init(&b, 0);
 	uci_to_blob(&b, s, &interface_attr_list);
-	return config_parse_interface(b.head, s->e.name, true);
+	return config_parse_interface(blob_data(b.head), blob_len(b.head), s->e.name, true);
+}
+
+
+static volatile int do_reload = false;
+void odhcpd_reload(void)
+{
+	uloop_cancelled = true;
+	do_reload = true;
 }
 
 
-static volatile bool do_reload = false;
 static void set_stop(int signal)
 {
-	uloop_end();
+	uloop_cancelled = true;
 	do_reload = (signal == SIGHUP);
 }
 
@@ -480,8 +508,12 @@ void odhcpd_run(void)
 	signal(SIGHUP, set_stop);
 	signal(SIGINT, set_stop);
 
+#ifdef WITH_UBUS
+	init_ubus();
+#endif
+
 	do {
-		do_reload = false;
+		do_reload = uloop_cancelled = false;
 
 		struct lease *l;
 		list_for_each_entry(l, &leases, head) {
@@ -513,7 +545,7 @@ void odhcpd_run(void)
 #endif
 
 		// Evaluate hybrid mode for master
-		struct interface *master = NULL, *i;
+		struct interface *master = NULL, *i, *n;
 		list_for_each_entry(i, &interfaces, head) {
 			if (!i->master)
 				continue;
@@ -538,8 +570,8 @@ void odhcpd_run(void)
 		}
 
 
-		list_for_each_entry(i, &interfaces, head) {
-			if (i->inuse && !i->ignore) {
+		list_for_each_entry_safe(i, n, &interfaces, head) {
+			if (i->inuse) {
 				// Resolve hybrid mode
 				if (i->dhcpv6 == RELAYD_HYBRID)
 					i->dhcpv6 = (master && master->dhcpv6 == RELAYD_RELAY) ?
@@ -557,6 +589,7 @@ void odhcpd_run(void)
 				setup_dhcpv6_interface(i, true);
 				setup_ndp_interface(i, true);
 				setup_dhcpv4_interface(i, true);
+				i->inuse = false;
 			} else {
 				close_interface(i);
 			}